b5fbef2 | Axel Naumann | 11 December 2017, 07:09:42 UTC | Do not make it look as if TTreeReader is removed! (cherry picked from commit 5bb0002ea1eb402076c0e8cf539d419a66946020) | 11 December 2017, 08:09:31 UTC |
fb8a3e9 | Axel Naumann | 11 December 2017, 07:07:24 UTC | Whitespace (nfc). (cherry picked from commit db32c4b4248ff8c25f868cf39f3f645e135763a0) | 11 December 2017, 08:09:24 UTC |
bedcf06 | Vassil Vassilev | 30 November 2017, 11:38:38 UTC | Set the SourceManager flag to enable -fmodules-embed-all-files. This marks all files in the PCH/PCM transient. This allows clang to stream them back within the zip in the PCH rather than requiring the files to be physically present on disk. This should resolve an introduced regression which materializes if the files are moved/deleted after the generation of the PCH. | 10 December 2017, 19:37:21 UTC |
e63f492 | Philippe Canal | 10 December 2017, 19:15:31 UTC | typo | 10 December 2017, 19:15:57 UTC |
551c1e6 | Philippe Canal | 10 December 2017, 01:14:05 UTC | Resolve race condition between TDirectory and TContext destructor. The race condition could lead to the TContext indirectly spinning the lock indefinitively | 10 December 2017, 19:03:03 UTC |
31ded19 | Guilherme Amadio | 08 December 2017, 10:35:24 UTC | Match declarations of at_quick_exit and __cxa_atexit symbols for libc++ and C++17 On Linux, the same adjustments are needed as for libstdc++ and libc++, so turn the condition into just #ifdef __linux__. However, since the __cxa_atexit function is declared as extern "C" in libc++, we cannot add "noexcept" to it, as is done for libstdc++. | 09 December 2017, 10:50:02 UTC |
f6ede52 | Guilherme Amadio | 08 December 2017, 14:01:25 UTC | Replace deprecated std::random_shuffle with std::shuffle and default engine Removed in C++17. No functionality change intended. | 09 December 2017, 10:50:02 UTC |
5e24a3f | Guilherme Amadio | 08 December 2017, 14:04:20 UTC | Replace deprecated std::bind2nd with equivalent code Removed in C++17. No functionality change intended. | 09 December 2017, 10:50:01 UTC |
19dd322 | Guilherme Amadio | 08 December 2017, 13:53:58 UTC | Replace deprecated std::bind1st with equivalent code Removed in C++17. No functionality change intended. | 09 December 2017, 10:50:01 UTC |
09e970b | Guilherme Amadio | 08 December 2017, 14:06:57 UTC | Replace deprecated std::ptr_fun and std::mem_fun with equivalent code Removed in C++17. No functionality change intended. | 09 December 2017, 10:50:01 UTC |
fe44554 | Guilherme Amadio | 08 December 2017, 10:36:55 UTC | Do not use deprecated code in stressIterators test Removed in C++17. No functionality change intended. | 09 December 2017, 10:50:00 UTC |
f79690c | Benjamin Kramer | 17 September 2017, 11:12:57 UTC | Remove uses of deprecated std::pointer_to_unary_function It's removed in C++17. No functionality change intended. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@313481 91177308-0d34-0410-b5e6-96231b3b80d8 Signed-off-by: Guilherme Amadio <amadio@cern.ch> | 09 December 2017, 10:50:00 UTC |
76a0938 | Chris Burr | 07 December 2017, 13:14:38 UTC | BUG: Fix iterator type in RooRandomizeParamMCSModule | 09 December 2017, 10:18:45 UTC |
c5772d9 | Christopher Burr | 27 November 2017, 22:52:49 UTC | BUG: Fix misnamed variable in RooRandomizeParamMCSModule | 09 December 2017, 10:18:45 UTC |
38a075f | Enrico Guiraud | 08 December 2017, 17:15:27 UTC | [TDF] Fix missing re-initialization of variable on second event-loop `fLastCheckedEntry` was not re-initialized after the first event-loop of a data-frame, providing wrong results in filters and custom columns rare occasions. This should fix ROOT-9136. | 09 December 2017, 10:17:05 UTC |
e1e6d79 | Philippe Canal | 08 December 2017, 22:07:13 UTC | Update release note [WriteObject(const T *objptr, Bool_t cacheReuse = kTRUE)] | 08 December 2017, 22:08:38 UTC |
853399c | Xavier Valls | 08 December 2017, 15:42:29 UTC | Fix typo | 08 December 2017, 15:50:03 UTC |
6a2e19f | moneta | 08 December 2017, 10:29:37 UTC | Fix IsValid for compiled functions based on functors. | 08 December 2017, 12:15:23 UTC |
02783d0 | Philippe Canal | 07 December 2017, 17:56:43 UTC | Update Relase notes | 07 December 2017, 17:57:29 UTC |
3464562 | moneta | 07 December 2017, 14:31:08 UTC | Fix for integer overflows (e.g. for histograms with very large bin contents). This fixes ROOT-9074 | 07 December 2017, 14:32:05 UTC |
b288f16 | moneta | 07 December 2017, 14:05:37 UTC | Fix Info message | 07 December 2017, 14:07:23 UTC |
32059f3 | Bastian Beischer | 12 October 2017, 12:19:20 UTC | TEfficiency::SetUseWeightedEvents(): Do not assume Sumw2() was called on histograms. In Debug and RelWithDebInfo builds (when assertions are active) the following code caused an assertion to fire: root [0] TEfficiency* eff = new TEfficiency; root [1] eff->SetUseWeightedEvents(); Info in <TROOT::TEfficiency::SetUseWeightedEvents>: Histograms are filled with weights root.exe: ../hist/hist/src/TEfficiency.cxx:3593: void TEfficiency::SetUseWeightedEvents(bool): Assertion `fTotalHistogram->GetSumw2N() > 0 && fPassedHistogram->GetSumw2N() > 0' failed This fixes ROOT-9058. | 07 December 2017, 14:06:33 UTC |
12f537c | Philippe Canal | 07 December 2017, 12:21:16 UTC | Merge sixth part of using a RW lock (improved performance) | 07 December 2017, 12:21:16 UTC |
8205dee | Philippe Canal | 07 December 2017, 11:41:08 UTC | Use std::mutex inner lock of gCoreMutex RWLock. This avoid the virtual call of TMutex. | 07 December 2017, 12:20:03 UTC |
12e6227 | Philippe Canal | 07 December 2017, 02:14:02 UTC | Avoid copying shared_pointer in RecursiveRemove when list in empty. | 07 December 2017, 12:20:03 UTC |
b1bb2d8 | Philippe Canal | 07 December 2017, 02:02:37 UTC | Add definition and test of std::mutex for RW lock | 07 December 2017, 12:20:02 UTC |
148c52d | Philippe Canal | 07 December 2017, 02:02:15 UTC | Add missing lnk->SetObject(nullptr) when marking the link for removal | 07 December 2017, 12:20:02 UTC |
4302132 | Philippe Canal | 07 December 2017, 00:12:07 UTC | Speed-up RW unlocking. Avoid to search 'again' for the thread local information (the reader count) in the Unlock when we already did in the lock and we have good way to pass it from one to the other (The LockGuard) | 07 December 2017, 12:20:02 UTC |
0fa8fb2 | Philippe Canal | 06 December 2017, 22:11:29 UTC | Typo in documentation. | 07 December 2017, 12:20:02 UTC |
c3e3443 | Philippe Canal | 06 December 2017, 22:07:39 UTC | Rely on TROOT::RecursiveRemove to take the read lock. Since RecursiveRemove is called for each object (directly and indirectly) in the list of cleanups by each object delete, it is called O(N^2) times, so avoid the 'redundant' read-lock taking is a boost | 07 December 2017, 12:20:01 UTC |
15beebb | Olivier Couet | 07 December 2017, 10:41:09 UTC | Fix to avoid a crash when DrawPanel was invoked from the popup menu on an histogram. | 07 December 2017, 12:20:01 UTC |
2d2e853 | moneta | 06 December 2017, 22:49:22 UTC | Update list of contributors in Release notes | 06 December 2017, 22:50:11 UTC |
195d4ce | Xavier Valls | 06 December 2017, 15:28:42 UTC | Update release notes | 06 December 2017, 22:29:38 UTC |
35ed77b | moneta | 06 December 2017, 16:23:27 UTC | Update reference file for changes in RooStats to use GlobalObservables option in createNLL | 06 December 2017, 22:29:26 UTC |
06e0b38 | moneta | 06 December 2017, 16:19:54 UTC | Add GlobalObservables to all createNLL in RooStats. This makes the NLL computing correctly the normalisation of the constraint terms. Some tests in stressRooStats have a different result when the normalisation of the constraints plays a role (e.g. when the global observables have a range which is not large enough and therefore the integral of the constraint pdf is not 1) | 06 December 2017, 22:29:16 UTC |
54df0fe | moneta | 06 December 2017, 13:51:33 UTC | Revert "Revert changes in RooAbsPdf::createNLL which deal with the constraint terms and introduced in ab6de0cac6f9d37b48be1a86e4e043bfc24bc298." This reverts commit 63829864218426edd86de57512c5c16d77ea8bc7. | 06 December 2017, 22:29:06 UTC |
9e6515a | Philippe Canal | 06 December 2017, 16:11:10 UTC | Merge fifth part of using a RW lock. | 06 December 2017, 16:11:10 UTC |
09e370f | Philippe Canal | 05 December 2017, 15:29:12 UTC | Reduce use of shared_from_this to minimum | 06 December 2017, 16:10:55 UTC |
b6457e1 | Philippe Canal | 04 December 2017, 22:59:10 UTC | Properly deal with TClassTable Init delay. See 65ed97fc8d This fixes ROOT-9139. | 06 December 2017, 15:33:58 UTC |
fe9860c | Guilherme Amadio | 06 December 2017, 14:25:53 UTC | Fix memory leak in TBufferMerger memfiles.clear() needs std::unique_ptr<TMemFile> to free the memory. Bug introduced by commit 8594906728abdedc563eacd04e9a6bdded77e837. Closes ROOT-9133. | 06 December 2017, 15:26:45 UTC |
efeede3 | Guilherme Amadio | 06 December 2017, 09:37:53 UTC | [test/ios] Use unique_ptr instead of deprecated auto_ptr | 06 December 2017, 15:26:41 UTC |
e3200c0 | Guilherme Amadio | 06 December 2017, 09:37:05 UTC | Remove comments with auto_ptr from stressMathMore test | 06 December 2017, 15:26:37 UTC |
d9749a1 | Guilherme Amadio | 06 December 2017, 09:33:35 UTC | [graf2d/cocoa] Use unique_ptr instead of deprecated auto_ptr | 06 December 2017, 15:26:33 UTC |
401f129 | Guilherme Amadio | 06 December 2017, 09:22:07 UTC | [RooFit] Use unique_ptr instead of deprecated auto_ptr | 06 December 2017, 15:26:28 UTC |
fa19c9f | Axel Naumann | 06 December 2017, 03:11:26 UTC | Mark compiler include paths as -cxx-isystem (ROOT-8991). (cherry picked from commit c48aa92477cb13d09bbf9642cd807932bba444f5) | 06 December 2017, 14:26:12 UTC |
346ad9a | Axel Naumann | 05 December 2017, 23:10:44 UTC | Claim #include <auto-parse-hdr> to remember the full path (ROOT-8863). (cherry picked from commit 7f159090a4749498d6bc341c1d152b52bc45c013) | 06 December 2017, 03:13:22 UTC |
6ee9b29 | Danilo Piparo | 04 December 2017, 14:18:55 UTC | [RN] Elaborate more on TDF Histo models | 05 December 2017, 21:26:07 UTC |
7b44199 | Axel Naumann | 05 December 2017, 04:53:42 UTC | Adjust after increased fp precision. (cherry picked from commit 61c4504589bdbb398171ea30573ba6f87b31143e) | 05 December 2017, 14:50:22 UTC |
a7feaa8 | Axel Naumann | 05 December 2017, 04:53:15 UTC | Print float with number of signif digits, double with 8. (cherry picked from commit 8ae60a20f6ca50f8f6342289ab856d71aa9870f1) | 05 December 2017, 14:50:22 UTC |
045e3e2 | Axel Naumann | 04 December 2017, 21:35:44 UTC | Update to new output format. Use CHECK-NEXT. (cherry picked from commit dc1d928d55fca51b70e2c69b757a95a2f672b93b) | 05 December 2017, 14:50:22 UTC |
bcd9f15 | Axel Naumann | 04 December 2017, 21:35:20 UTC | Update ref to include <invalid memory address> (cherry picked from commit 77ea691e0ce3420d1fceecc5e4852c7da5e0a79d) | 05 December 2017, 14:50:22 UTC |
6e1246a | Axel Naumann | 04 December 2017, 20:51:40 UTC | Adapt to new=old value printer: "1.000000" for a double 1 instead of "1". Revert "Adapt to format changes in floating point value printing." This reverts commit a15ef54fb4c5152eeff740cc1f3be6249ede26e6. (cherry picked from commit d08f924ee8e616da53826dc0f3078c39443e2ab3) | 05 December 2017, 14:50:22 UTC |
c09e940 | Axel Naumann | 04 December 2017, 20:54:09 UTC | Print "1.000000" for a double 1 instead of "1", as in 6.10. Uses the # modifier to printf using the "alternate form". (cherry picked from commit 68a8d09a9ce23a8cb61aa1ab404d37ac4e7d4613) | 05 December 2017, 14:50:22 UTC |
df3be07 | Olivier Couet | 05 December 2017, 14:45:23 UTC | Update release notes | 05 December 2017, 14:45:35 UTC |
985df4f | Guilherme Amadio | 28 November 2017, 10:57:04 UTC | Bump builtin version of Vc to 1.3.3 | 05 December 2017, 14:36:06 UTC |
82abd3f | Guilherme Amadio | 28 November 2017, 10:42:38 UTC | Fix problems with conversions between TString and std::string in C++17 | 05 December 2017, 14:36:05 UTC |
8b8ad98 | Guilherme Amadio | 28 November 2017, 09:51:19 UTC | Help compiler to convert from llvm::cl::opt to its std::string value Fixes the error below when compiling with C++17: lib/Transforms/IPO/PassManagerBuilder.cpp:175:19: error: call to deleted constructor of 'llvm::cl::opt<std::string>' PGOInstrGen = PGOOutputFile; ^~~~~~~~~~~~~ include/llvm/Support/CommandLine.h:1325:3: note: 'opt' has been explicitly marked deleted here opt(const opt &) = delete; | 05 December 2017, 14:36:05 UTC |
e5692eb | Guilherme Amadio | 21 November 2017, 17:08:05 UTC | Pass reference to fstat() in RetryAfterSignal() Without this patch llvm fails to compile due to a mismatch in argument types since RetryAfterSignal() expects a reference to the callable. | 05 December 2017, 14:36:05 UTC |
06ec6c1 | Guilherme Amadio | 21 November 2017, 14:45:00 UTC | Enable C++17 build option | 05 December 2017, 14:36:05 UTC |
69d1e2b | Guilherme Amadio | 05 December 2017, 13:52:51 UTC | Update documentation of rootcp to reflect new behaviour | 05 December 2017, 14:20:44 UTC |
e3a7417 | Guilherme Amadio | 05 December 2017, 11:05:48 UTC | [rootcp] Write out keys only if cycle number increases Fixes https://sft.its.cern.ch/jira/browse/ROOT-8528. | 05 December 2017, 14:20:43 UTC |
62cff7e | Guilherme Amadio | 28 November 2017, 16:48:47 UTC | Fail to add class to TClassTable when type deduction fails | 05 December 2017, 14:20:43 UTC |
321ce89 | Guilherme Amadio | 05 December 2017, 08:21:14 UTC | Fix deduction of type names in TGenericClassInfo Due to differences in the __PRETTY_FUNCTION__ macro from different compilers, TTypeNameExtraction::Get() returned an empty string if type deduction failed due to errors when trying to extract the type from the name. Since in AddClass() this condition was not checked for, any class that failed type deduction would be added with an empty string as key. We now rely on demangling the output of typeid(T).name() with this commit. | 05 December 2017, 14:20:43 UTC |
460073e | Evgueni Tcherniaev | 05 December 2017, 10:08:27 UTC | Fix of 3d axis drawing at theta=90 | 05 December 2017, 14:16:34 UTC |
1aadd02 | Philippe Canal | 04 December 2017, 16:40:46 UTC | Add TGWindow to the white list of consistent hash. This avoid having to use the content of libGui's dictionary during the static initialization of libGui itself (TGClientInit creates a TGClient which creats a TGWindow which register itself in TGClient's THashList). | 04 December 2017, 17:47:33 UTC |
a7bff54 | Philippe Canal | 01 December 2017, 20:19:37 UTC | Merge fourth part of using a RW lock (improved performance) | 01 December 2017, 20:19:37 UTC |
1dba78e | Philippe Canal | 30 November 2017, 04:45:27 UTC | Use RW lock in TClass::GetClass(const std::type_info&...) | 01 December 2017, 20:19:09 UTC |
5a73f7e | Philippe Canal | 01 December 2017, 03:42:01 UTC | Make the mutable member of TBaseClass atomic. This make their testing outside the lock (and setting inside the lock) to be actually thread safe | 01 December 2017, 20:18:16 UTC |
b80433b | Philippe Canal | 30 November 2017, 21:37:54 UTC | Remove obsolete code. (STL is in std) | 01 December 2017, 20:18:15 UTC |
0818da1 | Philippe Canal | 30 November 2017, 04:46:02 UTC | Avoid having to mod TStreamerInfo when streaming it. This also avoid to have to take a lock during this streaming | 01 December 2017, 20:18:15 UTC |
91f4597 | Philippe Canal | 29 November 2017, 21:24:58 UTC | Allow writing temporary objects (with same address) in same TBuffer(s). A new flag to TBuffer*::WriteObject allows to skip the mechanism that prevent the 2nd streaming of an object. This allows the (re)use of temporary objects to store different data in the same buffer. | 01 December 2017, 20:18:15 UTC |
552bc5e | Philippe Canal | 29 November 2017, 20:33:17 UTC | Move reset from entry point to Reset function in TMessage. Now that TMessage::WriteObject is not the only entry point (actually this has been true for along time), we need to move the reset of the gathering of StreamerInfo information from that entry point to the Reset function. | 01 December 2017, 20:18:15 UTC |
6ac6dd6 | Philippe Canal | 29 November 2017, 20:31:58 UTC | Remove no longer necessary overload | 01 December 2017, 20:18:15 UTC |
284bc62 | Philippe Canal | 29 November 2017, 20:15:43 UTC | Add templated TBuffer::WriteObject | 01 December 2017, 20:18:15 UTC |
1d93bad | Sergey Linev | 28 November 2017, 12:45:58 UTC | sqlfile: clang-format and syntax erros fixes | 01 December 2017, 20:18:15 UTC |
e46b687 | Sergey Linev | 28 November 2017, 12:34:18 UTC | xml: clang-format of the source code | 01 December 2017, 20:18:15 UTC |
10f1619 | Sergey Linev | 28 November 2017, 12:27:52 UTC | sqlfile: re-enable subdirectory supports in TSQLFile | 01 December 2017, 20:18:15 UTC |
c7411ae | Sergey Linev | 28 November 2017, 12:23:51 UTC | xml: read TDirectoryFile keys also when using ReadObjectAny Sinse a while ReadObjectAny is used for TDirectoryFile reading. And this was not taken into account correctly. | 01 December 2017, 20:18:15 UTC |
b5bffbf | Sergey Linev | 28 November 2017, 10:24:02 UTC | xml: fix annoying syntax errors in comments | 01 December 2017, 20:18:15 UTC |
3dfd782 | Olivier Couet | 01 December 2017, 16:42:14 UTC | Update release notes | 01 December 2017, 16:42:14 UTC |
311fc84 | Olivier Couet | 01 December 2017, 16:36:00 UTC | Implement auto-coloring for TF1. Drawing options PFC, PLC and PMC. | 01 December 2017, 16:39:26 UTC |
9ef5ad1 | Philippe Canal | 29 November 2017, 19:19:23 UTC | Take global lock in TDirectoryFile constructor. This is to insure that RecursiveRemove does not see partially initialized TDirectoryFile. This should be replace by a delaying of the publishing of TDirectoryFile (to the list of cleanups via its parent list of objects) until the end of the constructor. | 30 November 2017, 15:26:24 UTC |
08c85c9 | Philippe Canal | 29 November 2017, 19:12:33 UTC | Publish TDirectory only when complete. As soon as a TDirectory is added to its parent's list of object, it is visible to other threads via the list of Cleanups so we need to make it, and its component, are complete before publishing. | 30 November 2017, 15:26:24 UTC |
6885183 | Philippe Canal | 29 November 2017, 19:10:57 UTC | Remove useless lock acquisition. This was inadvertently left over by commit 7b4ccc3fcea0f199dca909f5d9c26d3dd3080373 | 30 November 2017, 15:26:24 UTC |
f9da931 | Philippe Canal | 30 November 2017, 15:22:40 UTC | Repair TList removal of last remaining element. This was inadvertently broken in b5f8a69424. | 30 November 2017, 15:25:59 UTC |
2371fff | Philippe Canal | 30 November 2017, 15:16:38 UTC | White space | 30 November 2017, 15:25:58 UTC |
eeeab6e | Olivier Couet | 30 November 2017, 13:29:44 UTC | Change the default fill color to white to avoid black box in legend when `gPad->BuildLegend()` is called. | 30 November 2017, 14:15:26 UTC |
22fd24e | Philippe Canal | 29 November 2017, 20:05:08 UTC | Merge third part of using a RW lock to address RecursiveRemove concurrency | 29 November 2017, 20:05:08 UTC |
9cbb8a6 | Philippe Canal | 27 November 2017, 18:52:18 UTC | In LoadHandlersFromPluginDirs fix race condition. Handle the case that two thread may attempt to load the same plugin as the 'same' time and avoid the script from being loaded twice | 28 November 2017, 19:19:51 UTC |
c2fdd8f | Philippe Canal | 28 November 2017, 15:59:46 UTC | Add missing transient flag for TDirectory::fSpinLock | 28 November 2017, 19:18:48 UTC |
78cdfae | Philippe Canal | 27 November 2017, 19:57:22 UTC | Delete object before library unload | 28 November 2017, 19:18:47 UTC |
6e9f17a | Philippe Canal | 27 November 2017, 18:53:26 UTC | Properly reattach TF1 to their parent in SavePrimitive. Also avoid those functions from being added to the global list of function. | 28 November 2017, 19:18:47 UTC |
8fad1a6 | Philippe Canal | 28 November 2017, 16:50:42 UTC | Delete UUIDs after TFile(s) | 28 November 2017, 19:18:47 UTC |
0222e67 | Enrico Guiraud | 28 November 2017, 10:38:39 UTC | [TDF] Correctly deduce type of Float_t branches when jitting | 28 November 2017, 12:55:12 UTC |
e726c1d | Enrico Guiraud | 27 November 2017, 22:12:38 UTC | [TDF] Reset `fMustRunEventLoop` when a new named filter is added This fixes ROOT-9117: TDF now correctly re-runs the event-loop if users ask for a cutflow report for a named filter that has been added after a first event-loop has already been performed. In the future we might want to improve the inner logic so that only the new named filters (and possibly new actions) are executed, but the old filters are not re-run if not needed. | 28 November 2017, 12:52:59 UTC |
2034fc7 | Enrico Guiraud | 27 November 2017, 21:46:53 UTC | [TDF] Make Filter::ResetReportCount non-virtual | 28 November 2017, 12:52:59 UTC |
44aa65a | Bastian Beischer | 27 November 2017, 14:33:35 UTC | Backport LLVM patch to fix compilation with Intel Compiler. This commit backports the following LLVM patch: https://github.com/llvm-mirror/llvm/commit/061e7017039f963caff79bff51c0fb43a88bebdd which also fixes compilation of ROOT with the Intel Compiler. | 28 November 2017, 10:37:33 UTC |
c028c8d | Gerardo Ganis | 28 November 2017, 09:30:51 UTC | hist/TH1Merger: do not issue a Warning for empty histograms | 28 November 2017, 09:44:46 UTC |
09a0e10 | Nicolas Morange | 24 November 2017, 09:39:16 UTC | Make TEnv::GetValue functions const Requires that TEnv:: Getvalue, Lookup are const as well. Also mark Defined const. Local compilation of ROOT succeeds after the patch. | 27 November 2017, 22:06:08 UTC |
fc61b0e | Philippe Canal | 27 November 2017, 15:42:53 UTC | Revert "Address ROOT-9114 (Issues with dictionary's enum forward decl)" This reverts commit 59c69dc2ce449eff8cabcf73405b04b07aaf9eb3. This commit leads to the following type of failures: I rebuilt ROOT6 CMSSW IB based on new commit but now I see compilation errors [a] while running edmCheckClassTransients [a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_10_0_ROOT6_X_2017-11-18-1100/DataFormats/BTauReco In file included from CMSSW_10_0_ROOT6_X_2017-11-18-1100/src/DataFormats/BTauReco/interface/TrackIPTagInfo.h:7: CMSSW_10_0_ROOT6_X_2017-11-18-1100/src/DataFormats/BTauReco/interface/IPTagInfo.h:179:24: error: no member named 'trackMomentum' in namespace 'reco::btau' vars.insert(btau::trackMomentum, trackMag, true); ~~~~~~^ CMSSW_10_0_ROOT6_X_2017-11-18-1100/src/DataFormats/BTauReco/interface/IPTagInfo.h:180:24: error: no member named 'trackEta' in namespace 'reco::btau' vars.insert(btau::trackEta, trackMom.Eta(), true); ~~~~~~^ CMSSW_10_0_ROOT6_X_2017-11-18-1100/src/DataFormats/BTauReco/interface/IPTagInfo.h:181:24: error: no member named 'trackEtaRel' in namespace 'reco::btau' vars.insert(btau::trackEtaRel, reco::btau::etaRel(jetDir, trackMom), true); | 27 November 2017, 22:06:08 UTC |