Skip to main content

Browse the archive

Revision b6202a0cf154a0e0e7cbacf165a995cc37e5cd3e authored by Valentin Lorentz on 29 July 2020, 08:26:32 UTC, committed by Valentin Lorentz on 29 July 2020, 14:24:11 UTC 
Make API endpoints take Lists instead of Iterables as arguments
 
1. clients crash when they call the API with an iterator
2. some backend implementations violate the contract by assuming
   the argument is a sequence (eg. by iterating twice on it, and
   assuming the elements are the same)
3. no matter what we do, the endpoints will always get a list
   as argument in practice, because they go through the RPC framework
4. there is no concrete (ha!) advantage in taking an Iterable rather
   than a List.
1 parent 21b7730
Raw File
pyproject.toml 
[tool.black]
target-version = ['py37']
back to top