https://github.com/Kitware/CMake
Revision b665966933c8656d1dafde06b8f29fe7e4901738 authored by Ben Boeckel on 22 July 2023, 10:46:31 UTC, committed by Ben Boeckel on 22 July 2023, 11:12:43 UTC
In commit b6a5382217 (Ninja: depend on language module information files directly, 2023-02-10), introduced via !8197, language-specific module information files (`CMakeFiles/<target>.dir/<lang>Modules.json`) files were added as real dependencies to the dyndep collation steps. Previously, the behavior was to inform the collator of all possible targets and search for the files manually ignoring those which did not exist with ordering enforced by depending on the linker output of all dependent targets. This behavior could lead to stale information being used (e.g., if a target stops providing any targets) and also did not reliably build everything needed on rebuilds. Afterwards, the internal computation changed the dependency from all possible targets to an exact set of "these targets might have modules" query, however one that did not include `OBJECT` libraries since do not have `LinkEntry` items internally (their objects are instead treated as source files). As a stopgap measure, track `OBJECT` libraries in a separate list and query them explicitly when gathering targets which may have interesting information. Future work can add `LinkEntry` items to represent these targets once all `LinkEntry` consumers have been audited to make sure they are not surprised by any `OBJECT` library entries. Fixes: #25112
1 parent a99b87a
Tip revision: b665966933c8656d1dafde06b8f29fe7e4901738 authored by Ben Boeckel on 22 July 2023, 10:46:31 UTC
cmComputeLinkInformation: track OBJECT library dependencies
cmComputeLinkInformation: track OBJECT library dependencies
Tip revision: b665966
File | Mode | Size |
---|---|---|
.github | ||
.gitlab | ||
Auxiliary | ||
Help | ||
Licenses | ||
Modules | ||
Packaging | ||
Source | ||
Templates | ||
Tests | ||
Utilities | ||
.clang-format | -rw-r--r-- | 1.4 KB |
.clang-tidy | -rw-r--r-- | 1.8 KB |
.codespellrc | -rw-r--r-- | 644 bytes |
.editorconfig | -rw-r--r-- | 164 bytes |
.gitattributes | -rw-r--r-- | 1.2 KB |
.gitignore | -rw-r--r-- | 422 bytes |
.gitlab-ci.yml | -rw-r--r-- | 34.5 KB |
.hooks-config | -rw-r--r-- | 418 bytes |
CMakeCPack.cmake | -rw-r--r-- | 9.9 KB |
CMakeCPackOptions.cmake.in | -rw-r--r-- | 12.0 KB |
CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
CMakeLists.txt | -rw-r--r-- | 21.0 KB |
CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
CONTRIBUTING.rst | -rw-r--r-- | 3.0 KB |
CTestConfig.cmake | -rw-r--r-- | 566 bytes |
CTestCustom.cmake.in | -rw-r--r-- | 7.3 KB |
CompileFlags.cmake | -rw-r--r-- | 5.0 KB |
Copyright.txt | -rw-r--r-- | 5.3 KB |
DartConfig.cmake | -rw-r--r-- | 374 bytes |
README.rst | -rw-r--r-- | 3.9 KB |
bootstrap | -rwxr-xr-x | 64.6 KB |
cmake_uninstall.cmake.in | -rw-r--r-- | 789 bytes |
configure | -rwxr-xr-x | 99 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...