Revision b77cb2ac458448dbf0dfcbdc42859c74812c4408 authored by Nathan Shively-Sanders on 26 September 2018, 17:54:26 UTC, committed by GitHub on 26 September 2018, 17:54:26 UTC
I'm surprised we haven't seen more of this; I suspect it's because the mixed `module.exports=` + `export.foo=` pattern isn't that common. However, it'll happen any time that the exported symbol is unknown; getCommonJsExportEquals blithely clones unknownSymbol and proceeds to stick the `exports.foo=` properties onto it. This causes problems later, because the compiler checks for unknownSymbol with `===`. The fix is to not stick properties onto a clone of unknownSymbol. This makes the correct errors appear and removes the crash.
1 parent f4a643f
File | Mode | Size |
---|---|---|
cs | ||
de | ||
enu | ||
es | ||
fr | ||
it | ||
ja | ||
ko | ||
pl | ||
pt-br | ||
ru | ||
tr | ||
zh-cn | ||
zh-tw | ||
.gitattributes | -rw-r--r-- | 13 bytes |
README.md | -rw-r--r-- | 270 bytes |
cancellationToken.js | -rw-r--r-- | 2.9 KB |
diagnosticMessages.generated.json | -rw-r--r-- | 142.1 KB |
lib.d.ts | -rw-r--r-- | 1001 bytes |
lib.dom.d.ts | -rw-r--r-- | 677.7 KB |
lib.dom.iterable.d.ts | -rw-r--r-- | 6.0 KB |
lib.es2015.collection.d.ts | -rw-r--r-- | 2.8 KB |
lib.es2015.core.d.ts | -rw-r--r-- | 19.1 KB |
lib.es2015.d.ts | -rw-r--r-- | 1.2 KB |
lib.es2015.generator.d.ts | -rw-r--r-- | 2.1 KB |
lib.es2015.iterable.d.ts | -rw-r--r-- | 14.2 KB |
lib.es2015.promise.d.ts | -rw-r--r-- | 10.4 KB |
lib.es2015.proxy.d.ts | -rw-r--r-- | 1.9 KB |
lib.es2015.reflect.d.ts | -rw-r--r-- | 1.9 KB |
lib.es2015.symbol.d.ts | -rw-r--r-- | 1.6 KB |
lib.es2015.symbol.wellknown.d.ts | -rw-r--r-- | 10.0 KB |
lib.es2016.array.include.d.ts | -rw-r--r-- | 4.8 KB |
lib.es2016.d.ts | -rw-r--r-- | 937 bytes |
lib.es2016.full.d.ts | -rw-r--r-- | 1.0 KB |
lib.es2017.d.ts | -rw-r--r-- | 1.1 KB |
lib.es2017.full.d.ts | -rw-r--r-- | 1.0 KB |
lib.es2017.intl.d.ts | -rw-r--r-- | 1.2 KB |
lib.es2017.object.d.ts | -rw-r--r-- | 2.4 KB |
lib.es2017.sharedmemory.d.ts | -rw-r--r-- | 6.0 KB |
lib.es2017.string.d.ts | -rw-r--r-- | 2.3 KB |
lib.es2017.typedarrays.d.ts | -rw-r--r-- | 1.4 KB |
lib.es2018.d.ts | -rw-r--r-- | 1006 bytes |
lib.es2018.full.d.ts | -rw-r--r-- | 1.0 KB |
lib.es2018.intl.d.ts | -rw-r--r-- | 1.8 KB |
lib.es2018.promise.d.ts | -rw-r--r-- | 1.3 KB |
lib.es2018.regexp.d.ts | -rw-r--r-- | 1.2 KB |
lib.es5.d.ts | -rw-r--r-- | 191.6 KB |
lib.es6.d.ts | -rw-r--r-- | 1.0 KB |
lib.esnext.array.d.ts | -rw-r--r-- | 7.5 KB |
lib.esnext.asynciterable.d.ts | -rw-r--r-- | 1.5 KB |
lib.esnext.d.ts | -rw-r--r-- | 1.0 KB |
lib.esnext.full.d.ts | -rw-r--r-- | 1.0 KB |
lib.esnext.intl.d.ts | -rw-r--r-- | 1.2 KB |
lib.esnext.symbol.d.ts | -rw-r--r-- | 1002 bytes |
lib.scripthost.d.ts | -rw-r--r-- | 9.2 KB |
lib.webworker.d.ts | -rw-r--r-- | 109.5 KB |
lib.webworker.importscripts.d.ts | -rw-r--r-- | 1.0 KB |
protocol.d.ts | -rw-r--r-- | 82.6 KB |
tsc.js | -rw-r--r-- | 3.7 MB |
tsserver.js | -rw-r--r-- | 6.8 MB |
tsserverlibrary.d.ts | -rw-r--r-- | 395.9 KB |
tsserverlibrary.js | -rw-r--r-- | 6.9 MB |
typesMap.json | -rw-r--r-- | 16.4 KB |
typescript.d.ts | -rw-r--r-- | 276.1 KB |
typescript.js | -rw-r--r-- | 6.4 MB |
typescriptServices.d.ts | -rw-r--r-- | 276.1 KB |
typescriptServices.js | -rw-r--r-- | 6.4 MB |
typingsInstaller.js | -rw-r--r-- | 5.0 MB |
watchGuard.js | -rw-r--r-- | 1.1 KB |
Computing file changes ...