Revision b79a2ef0d4dc6b8a4093334db29f7c221c1ac8bd authored by Cédric Le Goater on 25 January 2024, 13:27:36 UTC, committed by Michael Tokarev on 29 January 2024, 20:08:46 UTC
When doing device assignment of a physical device, MSI-X can be
enabled with no vectors enabled and this sets the IRQ index to
VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ
index is left untouched if no vectors are in use. Then, when INTx
is enabled, the IRQ index value is considered incompatible (set to
MSI-X) and VFIO_DEVICE_SET_IRQS fails. QEMU complains with :
qemu-system-x86_64: vfio 0000:08:00.0: Failed to set up TRIGGER eventfd signaling for interrupt INTX-0: VFIO_DEVICE_SET_IRQS failure: Invalid argument
To avoid that, unconditionaly clear the IRQ index when MSI-X is
disabled.
Buglink: https://issues.redhat.com/browse/RHEL-21293
Fixes: 5ebffa4e87e7 ("vfio/pci: use an invalid fd to enable MSI-X")
Cc: Jing Liu <jing2.liu@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
(cherry picked from commit d2b668fca5652760b435ce812a743bba03d2f316)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
1 parent 106aa13
| File | Mode | Size |
|---|---|---|
| 9p-iov-marshal.c | -rw-r--r-- | 10.1 KB |
| 9p-iov-marshal.h | -rw-r--r-- | 768 bytes |
| 9p-marshal.c | -rw-r--r-- | 872 bytes |
| 9p-marshal.h | -rw-r--r-- | 1.6 KB |
| file-op-9p.h | -rw-r--r-- | 5.1 KB |
| meson.build | -rw-r--r-- | 730 bytes |
| p9array.h | -rw-r--r-- | 5.4 KB |
| qemu-fsdev-dummy.c | -rw-r--r-- | 372 bytes |
| qemu-fsdev-opts.c | -rw-r--r-- | 2.6 KB |
| qemu-fsdev-throttle.c | -rw-r--r-- | 4.6 KB |
| qemu-fsdev-throttle.h | -rw-r--r-- | 965 bytes |
| qemu-fsdev.c | -rw-r--r-- | 5.0 KB |
| qemu-fsdev.h | -rw-r--r-- | 492 bytes |
| virtfs-proxy-helper.c | -rw-r--r-- | 31.4 KB |
Computing file changes ...
