https://github.com/torvalds/linux
Revision b8ddafd759e356c839774a8b87011b768deb53b3 authored by Zhu Yi on 27 November 2008, 05:42:20 UTC, committed by John W. Linville on 05 December 2008, 14:18:35 UTC
In "ipw2200: Call netif_*_queue() interfaces properly", netif_stop_queue()
and netif_wake_queue() were removed with the reason
"netif_carrier_{on,off}() handles starting and stopping packet flow into
the driver". The patch also removes a valid condition check that
ipw_tx_skb() cannot be called if device is not in STATUS_ASSOCIATED state.
But netif_carrier_off() doesn't guarantee netdev->hard_start_xmit won't
be called because linkwatch event is handled in a delayed workqueue. This
caused a kernel oops reported by Frank Seidel:
https://bugzilla.novell.com/show_bug.cgi?id=397390
This patch fixes the problem by moving the STATUS_ASSOCIATED check back
to ipw_tx_skb(). It also adds a missing netif_carrier_off() call to
ipw_disassociate().
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: Chatre, Reinette <reinette.chatre@intel.com>
Tested-by: Frank Seidel <fseidel@suse.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
1 parent 40a9a82
Tip revision: b8ddafd759e356c839774a8b87011b768deb53b3 authored by Zhu Yi on 27 November 2008, 05:42:20 UTC
ipw2200: fix netif_*_queue() removal regression
ipw2200: fix netif_*_queue() removal regression
Tip revision: b8ddafd
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| firmware | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| usr | ||
| virt | ||
| .gitignore | -rw-r--r-- | 867 bytes |
| .mailmap | -rw-r--r-- | 3.8 KB |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 91.0 KB |
| Kbuild | -rw-r--r-- | 2.4 KB |
| MAINTAINERS | -rw-r--r-- | 103.3 KB |
| Makefile | -rw-r--r-- | 55.9 KB |
| README | -rw-r--r-- | 16.5 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.1 KB |
Computing file changes ...
