Revision - b8e9b3d - fix(compiler): skipping leading whitespace should not break [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

01 September 2024, 02:13:37 UTC

Revision b8e9b3d60110c3372b0f4721308fc25b1457d0b2 authored by Pete Bacon Darwin on 29 October 2020, 09:45:01 UTC, committed by Misko Hevery on 05 November 2020, 15:58:34 UTC

fix(compiler): skipping leading whitespace should not break placeholder source-spans (#39486)

Tokenized text node may have leading whitespace skipped from their
source-span. But the source-span is used to compute where there are
interpolated blocks, resulting in placeholder nodes whose source-spans
are offset by the amount of skipped characters.

This fix uses the `fullStart` location of text source-spans for computing
the source-span of placeholders, so that they are accurate.

Fixes #39195

PR Close #39486

1 parent 94d0013

Files
Changes

Permalinks

Tip revision: b8e9b3d60110c3372b0f4721308fc25b1457d0b2 authored by Pete Bacon Darwin on 29 October 2020, 09:45:01 UTC
fix(compiler): skipping leading whitespace should not break placeholder source-spans (#39486)

Tip revision: b8e9b3d

File	Mode	Size
.circleci
.devcontainer
.github
.ng-dev
.vscode
.yarn
aio
dev-infra
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	4.3 KB
.bazelrc	-rw-r--r--	6.2 KB
.bazelversion	-rw-r--r--	213 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	314 bytes
.gitignore	-rw-r--r--	837 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.nvmrc	-rw-r--r--	8 bytes
.pullapprove.yml	-rw-r--r--	45.8 KB
.yarnrc	-rw-r--r--	128 bytes
BUILD.bazel	-rw-r--r--	1.8 KB
CHANGELOG.md	-rw-r--r--	758.8 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	14.9 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.3 KB
WORKSPACE	-rw-r--r--	4.0 KB
browser-providers.conf.js	-rw-r--r--	8.4 KB
gulpfile.js	-rw-r--r--	1.3 KB
karma-js.conf.js	-rw-r--r--	7.8 KB
package.json	-rw-r--r--	8.4 KB
test-events.js	-rw-r--r--	259 bytes
test-main.js	-rw-r--r--	11.3 KB
tslint.json	-rw-r--r--	2.3 KB
yarn.lock	-rw-r--r--	698.0 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(compiler): skipping leading whitespace should not break placeholder source-spans (#39486)

README.md