Revision b90d72a6bfdb5e5c62cd223a8cdf4045bfbcb94d authored by Will Deacon on 12 January 2021, 22:18:55 UTC, committed by Catalin Marinas on 13 January 2021, 15:08:41 UTC
This reverts commit 367c820ef08082e68df8a3bc12e62393af21e4b5. lockup_detector_init() makes heavy use of per-cpu variables and must be called with preemption disabled. Usually, it's handled early during boot in kernel_init_freeable(), before SMP has been initialised. Since we do not know whether or not our PMU interrupt can be signalled as an NMI until considerably later in the boot process, the Arm PMU driver attempts to re-initialise the lockup detector off the back of a device_initcall(). Unfortunately, this is called from preemptible context and results in the following splat: | BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1 | caller is debug_smp_processor_id+0x20/0x2c | CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.10.0+ #276 | Hardware name: linux,dummy-virt (DT) | Call trace: | dump_backtrace+0x0/0x3c0 | show_stack+0x20/0x6c | dump_stack+0x2f0/0x42c | check_preemption_disabled+0x1cc/0x1dc | debug_smp_processor_id+0x20/0x2c | hardlockup_detector_event_create+0x34/0x18c | hardlockup_detector_perf_init+0x2c/0x134 | watchdog_nmi_probe+0x18/0x24 | lockup_detector_init+0x44/0xa8 | armv8_pmu_driver_init+0x54/0x78 | do_one_initcall+0x184/0x43c | kernel_init_freeable+0x368/0x380 | kernel_init+0x1c/0x1cc | ret_from_fork+0x10/0x30 Rather than bodge this with raw_smp_processor_id() or randomly disabling preemption, simply revert the culprit for now until we figure out how to do this properly. Reported-by: Lecopzer Chen <lecopzer.chen@mediatek.com> Signed-off-by: Will Deacon <will@kernel.org> Acked-by: Mark Rutland <mark.rutland@arm.com> Cc: Sumit Garg <sumit.garg@linaro.org> Cc: Alexandru Elisei <alexandru.elisei@arm.com> Link: https://lore.kernel.org/r/20201221162249.3119-1-lecopzer.chen@mediatek.com Link: https://lore.kernel.org/r/20210112221855.10666-1-will@kernel.org Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent df06824
File | Mode | Size |
---|---|---|
internal | ||
acompress.h | -rw-r--r-- | 8.8 KB |
aead.h | -rw-r--r-- | 18.3 KB |
aes.h | -rw-r--r-- | 2.5 KB |
akcipher.h | -rw-r--r-- | 12.9 KB |
algapi.h | -rw-r--r-- | 8.1 KB |
arc4.h | -rw-r--r-- | 484 bytes |
asym_tpm_subtype.h | -rw-r--r-- | 521 bytes |
authenc.h | -rw-r--r-- | 635 bytes |
b128ops.h | -rw-r--r-- | 2.4 KB |
blake2s.h | -rw-r--r-- | 2.4 KB |
blowfish.h | -rw-r--r-- | 415 bytes |
cast5.h | -rw-r--r-- | 590 bytes |
cast6.h | -rw-r--r-- | 607 bytes |
cast_common.h | -rw-r--r-- | 232 bytes |
chacha.h | -rw-r--r-- | 3.1 KB |
chacha20poly1305.h | -rw-r--r-- | 1.7 KB |
cryptd.h | -rw-r--r-- | 2.0 KB |
ctr.h | -rw-r--r-- | 1.4 KB |
curve25519.h | -rw-r--r-- | 2.0 KB |
des.h | -rw-r--r-- | 1.7 KB |
dh.h | -rw-r--r-- | 2.5 KB |
drbg.h | -rw-r--r-- | 8.9 KB |
ecdh.h | -rw-r--r-- | 2.5 KB |
engine.h | -rw-r--r-- | 4.1 KB |
gcm.h | -rw-r--r-- | 867 bytes |
gf128mul.h | -rw-r--r-- | 9.4 KB |
ghash.h | -rw-r--r-- | 388 bytes |
hash.h | -rw-r--r-- | 33.9 KB |
hash_info.h | -rw-r--r-- | 998 bytes |
hmac.h | -rw-r--r-- | 173 bytes |
if_alg.h | -rw-r--r-- | 6.6 KB |
kpp.h | -rw-r--r-- | 9.8 KB |
md5.h | -rw-r--r-- | 497 bytes |
nhpoly1305.h | -rw-r--r-- | 2.2 KB |
null.h | -rw-r--r-- | 346 bytes |
padlock.h | -rw-r--r-- | 438 bytes |
pcrypt.h | -rw-r--r-- | 815 bytes |
pkcs7.h | -rw-r--r-- | 1.2 KB |
poly1305.h | -rw-r--r-- | 2.4 KB |
public_key.h | -rw-r--r-- | 2.4 KB |
rng.h | -rw-r--r-- | 6.5 KB |
scatterwalk.h | -rw-r--r-- | 3.1 KB |
serpent.h | -rw-r--r-- | 696 bytes |
sha1.h | -rw-r--r-- | 1.2 KB |
sha1_base.h | -rw-r--r-- | 2.5 KB |
sha2.h | -rw-r--r-- | 3.8 KB |
sha256_base.h | -rw-r--r-- | 2.6 KB |
sha3.h | -rw-r--r-- | 879 bytes |
sha512_base.h | -rw-r--r-- | 3.2 KB |
skcipher.h | -rw-r--r-- | 19.9 KB |
sm2.h | -rw-r--r-- | 749 bytes |
sm3.h | -rw-r--r-- | 897 bytes |
sm3_base.h | -rw-r--r-- | 2.5 KB |
sm4.h | -rw-r--r-- | 754 bytes |
streebog.h | -rw-r--r-- | 949 bytes |
twofish.h | -rw-r--r-- | 743 bytes |
xts.h | -rw-r--r-- | 1.1 KB |
Computing file changes ...