| 2b7f36f | Todd Fiala | 14 January 2016, 18:00:13 UTC | lldb build: allow optional xcodebuild flags to be passed to build-script-impl | 14 January 2016, 20:02:18 UTC |
| c9c8def | Doug Gregor | 14 January 2016, 19:44:02 UTC | [Clang importer] Teach importFullName to provide argument labels for functions. importFullName was inconsistent in the kinds of names it produced for imported C functions. swift_name'd functions would get argument labels, but non-swift_name'd functions would not, and other parts of the important were working around the oddity. Make importFullName() always provide the argument labels. | 14 January 2016, 19:51:02 UTC |
| b52abd5 | Doug Gregor | 14 January 2016, 16:49:18 UTC | Fix link ordering. | 14 January 2016, 19:51:02 UTC |
| 8bd5987 | Doug Gregor | 14 January 2016, 06:46:10 UTC | Add a "-swift3-migration" frontend option and corresponding language option. This is intended to enable various Fix-Its to perform the one-way migration from Swift 2.x to Swift 3, with a focus on the issues involving naming. | 14 January 2016, 16:21:22 UTC |
| 2274db4 | Doug Gregor | 14 January 2016, 06:22:21 UTC | Remove the "-disable-self-type-mangling" flag and corresponding language option NFC | 14 January 2016, 16:21:21 UTC |
| ffd6054 | Doug Gregor | 14 January 2016, 05:42:05 UTC | Attempt to fix linking on Linux | 14 January 2016, 16:21:06 UTC |
| 1a8427b | Doug Gregor | 14 January 2016, 00:18:47 UTC | Add a swift3_migration attribute to describe how an API gets migrated. Introduce a new attribute, swift3_migration, that lets us describe the transformation required to map a Swift 2.x API into its Swift 3 equivalent. The only transformation understood now is "renamed" (to some other declaration name), but there's a message field where we can record information about other changes. The attribute can grow somewhat (e.g., to represent parameter reordering) as we need it. Right now, we do nothing but store and validate this attribute. | 14 January 2016, 00:58:27 UTC |
| ce45559 | Doug Gregor | 13 January 2016, 22:10:11 UTC | Revert "[AST] Introduce internal attribute '_migration_id'." This reverts commit 042efbfb267febc4bf598cc65ce87996b8222a37. We're going to take a different approach to the migration attribute. | 14 January 2016, 00:58:26 UTC |
| ae250af | Dmitri Gribenko | 13 January 2016, 16:32:10 UTC | Merge remote-tracking branch 'origin/master' into swift-2.2-branch | 13 January 2016, 16:32:10 UTC |
| e711d5e | Slava Pestov | 13 January 2016, 00:07:18 UTC | Preliminary evolution tests Checking these in to get some discussion over FileCheck style and test file structure going before I write too many more tests. | 13 January 2016, 09:32:27 UTC |
| 199468f | Dmitri Gribenko | 13 January 2016, 09:08:06 UTC | Merge pull request #954 from apple/revert-950-gyb-without-encoding Revert "[gyb] Force UTF-8 encoding when parsing templates on Linux" | 13 January 2016, 09:08:06 UTC |
| 1b44809 | Dmitri Gribenko | 13 January 2016, 09:07:53 UTC | Revert "[gyb] Force UTF-8 encoding when parsing templates on Linux" | 13 January 2016, 09:07:53 UTC |
| 81dfb77 | rjmccall | 13 January 2016, 08:52:41 UTC | Merge pull request #953 from practicalswift/typo-fixes-20160113 [gardening] Remove recently introduced typo | 13 January 2016, 08:52:41 UTC |
| 4a49c2d | practicalswift | 13 January 2016, 08:33:23 UTC | [gardening] Remove recently introduced typo :-) | 13 January 2016, 08:33:23 UTC |
| 92175c4 | rjmccall | 13 January 2016, 08:24:25 UTC | Merge pull request #952 from practicalswift/remove-binary [gardening] Remove binary "nix" - should not be in repo | 13 January 2016, 08:24:25 UTC |
| 6f0ac35 | practicalswift | 13 January 2016, 08:09:48 UTC | Remove binary "nix" introduced in commit 94ebcb847b3aae799da1cdb9374ad090f75d86dc $ file nix nix: Mach-O 64-bit x86_64 executable $ git log nix commit 94ebcb847b3aae799da1cdb9374ad090f75d86dc Author: John McCall <rjmccall@apple.com> Date: Tue Jan 12 23:34:54 2016 -0800 Handle inherited concrete conformances correctly on witness_method instructions. rdar://24141848 | 13 January 2016, 08:09:48 UTC |
| 94ebcb8 | John McCall | 13 January 2016, 07:34:54 UTC | Handle inherited concrete conformances correctly on witness_method instructions. rdar://24141848 | 13 January 2016, 07:36:21 UTC |
| 094098a | Slava Pestov | 13 January 2016, 07:06:55 UTC | IRGen: Don't walk into resilient types when emitting static value witness tables references This was the first real bug caught by the library evolution tests that I'm working on! | 13 January 2016, 07:29:22 UTC |
| 1c14b49 | Ted Kremenek | 13 January 2016, 05:51:54 UTC | Merge pull request #950 from RLovelett/gyb-without-encoding [gyb] Force UTF-8 encoding when parsing templates on Linux | 13 January 2016, 05:51:54 UTC |
| c8b1aa2 | Dmitri Gribenko | 13 January 2016, 04:39:02 UTC | Merge remote-tracking branch 'origin/master' into swift-2.2-branch | 13 January 2016, 04:39:02 UTC |
| 03f5f01 | Dmitri Gribenko | 13 January 2016, 04:38:31 UTC | test/Frontend/filelist.swift: don't fail if a temporary file does not exist | 13 January 2016, 04:38:31 UTC |
| ad94542 | Jordan Rose | 13 January 2016, 02:05:43 UTC | Teach the frontend about -filelist for input files. With this, we're out of the business of passing large numbers of input files on the command line to the frontend, which means we no longer overflow argv with a mere 1100 input files under whole-module optimization. In order to make sure this doesn't happen again, I'd like to also get this working for - swiftmodule inputs to the merge-module build phase - /output/ files for multithreading single-frontend builds (WMO) - object file inputs to the linker on OS X (response files for binutils ld have different quoting rules) Part 3 of https://bugs.swift.org/browse/SR-280. | 13 January 2016, 03:20:50 UTC |
| fe00083 | Jordan Rose | 13 January 2016, 01:04:25 UTC | [Driver] Actually write out the source file list file. This is simply a newline-separated list of files, matching the format from Darwin ld's -filelist option. Part 2 of https://bugs.swift.org/browse/SR-280. | 13 January 2016, 03:20:50 UTC |
| b45a69e | Jordan Rose | 13 January 2016, 00:43:21 UTC | [Driver] Allow passing all source files in a filelist. Generate frontend commands with -filelist in them. This isn't actually implemented yet, but we can start testing at this point. Part 1 of https://bugs.swift.org/browse/SR-280. | 13 January 2016, 03:20:50 UTC |
| 67eaab6 | John McCall | 13 January 2016, 03:11:25 UTC | Give _swift_dead_method_stub internal linkage; the Mach-O linker doesn't support aliases to weak symbols. rdar://24121475 | 13 January 2016, 03:12:20 UTC |
| 9f2105b | Luke Larson | 13 January 2016, 02:29:14 UTC | [CMake] Globally track produced libraries per platform rdar://problem/23955856 | 13 January 2016, 02:36:36 UTC |
| 35ed595 | Dmitri Gribenko | 13 January 2016, 01:58:05 UTC | Merge pull request #949 from apple/revert-673-sr215-fix Revert "[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215)" | 13 January 2016, 01:58:05 UTC |
| f40c2a5 | Dmitri Gribenko | 13 January 2016, 01:57:56 UTC | Revert "[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215)" | 13 January 2016, 01:57:56 UTC |
| c9e32b8 | Ryan Lovelett | 12 January 2016, 22:07:27 UTC | [gyb] Force UTF-8 encoding when parsing templates on Linux Python 3 on Linux reads the system locale information to determine what it should use as the default encoding for strings read from files (this is different from OS X which is always UTF-8 by default [1]). Since all the Swift gyb templates are UTF-8 encoded there is effectively no reason to parse them as anything else. This patch forces the gyb template parser to read the template using UTF-8 encoding. It accounts for both reading and writing to a file as well as reading from stdin and writing to stdout. Two changes of note are that it now includes a __future__ import that should make Python 2 behave a little closer to Python 3 in terms of unicode support. Additionally Python 2 can no longer use cStringIO because it does not support unicode [2]. To test this patch I ran these commands before and after the patch. Note: that before the patch if the locale was set to something other than UTF-8, ASCII for instance, the Python 3 runs would fail. See [3] for example failure message. Without stdin/stdout: $ python2 utils/gyb -o Arrays.2.7.swift stdlib/public/core/Arrays.swift.gyb $ python3 utils/gyb -o Arrays.3.5.swift stdlib/public/core/Arrays.swift.gyb $ diff -u Arrays.2.7.swift Arrays.3.5.swift With stdin/stdout: $ cat stdlib/public/core/Arrays.swift.gyb | python2 utils/gyb > Arrays.2.7.stdin.stdout.swift $ cat stdlib/public/core/Arrays.swift.gyb | python3 utils/gyb > Arrays.3.5.stdin.stdout.swift $ diff -u Arrays.2.7.stdin.stdout.swift Arrays.3.5.stdin.stdout.swift [1] https://docs.python.org/3/howto/unicode.html#unicode-filenames [2] https://docs.python.org/2/library/stringio.html#cStringIO.StringIO [3] https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160111/000780.html | 13 January 2016, 01:56:33 UTC |
| 72fdaff | Dmitri Gribenko | 13 January 2016, 01:49:10 UTC | Merge pull request #673 from SquaredTiki/sr215-fix [Parser] Fix-it for declaration attributes being applied to parameter types (SR-215) | 13 January 2016, 01:49:10 UTC |
| 7026909 | Michael Gottesman | 12 January 2016, 23:53:00 UTC | Refactor SILArgument to use TermKind and refactor a bunch of the code there to use one helper function to find incoming values. This improves the quality of code but more importantly makes it easier to ensure that new terminators are handled in this code since all of the switches are now covered switches. | 13 January 2016, 01:24:34 UTC |
| 9e1d3ab | Michael Gottesman | 13 January 2016, 01:03:19 UTC | [test] Change basic-aa.sil to no longer be dependent on the Swift standard library. | 13 January 2016, 01:24:34 UTC |
| c77f7b6 | Michael Gottesman | 13 January 2016, 01:01:30 UTC | [test] Convert allocbox_to_stack to no longer depend on the standard library. | 13 January 2016, 01:24:34 UTC |
| 21d273e | Greg Parker | 13 January 2016, 00:57:04 UTC | Merge pull request #947 from modocache/build-script [build-script] Remove unused function | 13 January 2016, 00:57:04 UTC |
| e1312f4 | Brian Gesiak | 12 January 2016, 22:29:03 UTC | [build-script] Remove unused function `is_native_tools_deployment_target` is never used. Remove it. | 13 January 2016, 00:54:07 UTC |
| 851f3ab | Michael Gottesman | 13 January 2016, 00:44:34 UTC | [test] Make earlycodemotion.sil not dependent on the swift standard library. | 13 January 2016, 00:53:13 UTC |
| d1b72c7 | Jordan Rose | 13 January 2016, 00:17:14 UTC | [test] Fix test case to account for temporary file names. | 13 January 2016, 00:17:27 UTC |
| 7be3eff | Jordan Rose | 12 January 2016, 21:54:34 UTC | [Driver] Remove an unused accessor. No one should be accessing the raw input argument list; it's there merely to keep the info about the derived argument list alive. | 13 January 2016, 00:17:27 UTC |
| 7552d49 | Jordan Rose | 12 January 2016, 21:36:06 UTC | [Driver] Eliminate unused fields from Compilation. No functionality change. | 13 January 2016, 00:17:27 UTC |
| 8bac086 | Chris Lattner | 13 January 2016, 00:04:12 UTC | My changes fixed this test, and swift-ide-test is returning a successful exit code, I should have removed the "not" as well as the --crash. | 13 January 2016, 00:04:40 UTC |
| f93b855 | Michael Gottesman | 12 January 2016, 22:43:19 UTC | [gardening] Add some textual flags and organize the code a little bit. NFC. | 12 January 2016, 22:43:19 UTC |
| 1b83009 | Michael Gottesman | 12 January 2016, 22:31:10 UTC | [gardening][rc-id] Move the main RCIdentityRoot analysis entry point into the RCIdentityRoot analysis section. | 12 January 2016, 22:31:10 UTC |
| 9a5970d | Michael Gottesman | 11 January 2016, 23:56:41 UTC | Remove standard library dependency from side-effect.sil. A gift for Dmitri. = ). | 12 January 2016, 22:26:46 UTC |
| 9ced244 | Joshua Garnham | 12 January 2016, 21:54:35 UTC | Corrected check for declaration attribute | 12 January 2016, 21:54:35 UTC |
| 5f78d24 | Jordan Rose | 12 January 2016, 19:49:07 UTC | [Driver] Make the list of input files available when creating Jobs. Previously jobs had to grovel this information out of the raw argument list, which dropped the types we had inferred on input files. This makes things more consistent across the compiler, though arguably we should be able to designate "primary" and "non-primary" inputs on a per-action basis rather than resorting to "global" state. Use this new information to stop passing object file inputs to the Swift frontend, fixing rdar://problem/23213785. The list wouldn't have to live on the Compilation, but I'm going to use it to fix SR-280 / rdar://problem/23878192 as well. | 12 January 2016, 19:52:31 UTC |
| af8eb37 | Jordan Rose | 12 January 2016, 19:07:58 UTC | [Driver] Constify a parameter. No functionality change. | 12 January 2016, 19:52:31 UTC |
| dbd0d47 | Jordan Rose | 12 January 2016, 02:00:13 UTC | [Driver] Only JobActions have inputs, not InputActions. Also, cluster the flags on Action into a single word. This probably doesn't make any real difference, but it's the convention. No functionality change. | 12 January 2016, 19:52:31 UTC |
| 1890de0 | Jordan Rose | 12 January 2016, 01:04:00 UTC | [Driver] Collapse duplicated code. No functionality change. | 12 January 2016, 19:52:31 UTC |
| 2d094d0 | Dmitri Gribenko | 12 January 2016, 19:34:49 UTC | Merge pull request #944 from practicalswift/swiftc-28200-swift-typebase-getdesugaredtype [swiftc] Add test case for crash triggered in swift::TypeBase::getDesugaredType() | 12 January 2016, 19:34:49 UTC |
| 9b81ff9 | Dmitri Gribenko | 12 January 2016, 19:34:39 UTC | Merge pull request #945 from EZ-NET/correct_oldstyle_array [docs] Replace old-style array type annotations. | 12 January 2016, 19:34:39 UTC |
| c554308 | Ben Langmuir | 12 January 2016, 18:45:20 UTC | [sourcekit] Remove unused variable to silence warning | 12 January 2016, 19:28:12 UTC |
| 93e3c72 | Ben Langmuir | 17 December 2015, 16:52:51 UTC | [swift-ide-test] Don't go past the end of input in removeCodeCompletionTokens When matching an incomplete code-completion token #^... | 12 January 2016, 19:28:11 UTC |
| 473b156 | Tomohiro Kumagai | 12 January 2016, 19:09:39 UTC | [docs] Replace old-style array type annotations. | 12 January 2016, 19:09:39 UTC |
| ab78cad | practicalswift | 12 January 2016, 18:04:56 UTC | [swiftc] Add test case for crash triggered in swift::TypeBase::getDesugaredType() Stack trace: ``` 4 swift 0x0000000001019a40 swift::TypeBase::getDesugaredType() + 32 5 swift 0x0000000000e89d9c swift::constraints::Solution::computeSubstitutions(swift::Type, swift::DeclContext*, swift::Type, swift::constraints::ConstraintLocator*, llvm::SmallVectorImpl<swift::Substitution>&) const + 828 9 swift 0x0000000000f6eb55 swift::Expr::walk(swift::ASTWalker&) + 69 10 swift 0x0000000000e8db66 swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::Expr*, swift::Type, bool, bool, bool) + 502 11 swift 0x0000000000e006ab swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 683 16 swift 0x0000000000ea8d28 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) + 104 17 swift 0x0000000000ead62e swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) + 4046 18 swift 0x0000000000dfa2a5 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 661 19 swift 0x0000000000e00639 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 569 20 swift 0x0000000000e017b0 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*) + 112 21 swift 0x0000000000e01959 swift::TypeChecker::typeCheckPatternBinding(swift::PatternBindingDecl*, unsigned int) + 265 26 swift 0x0000000000e1b266 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 150 27 swift 0x0000000000de77a2 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int) + 1474 28 swift 0x0000000000c9f042 swift::CompilerInstance::performSema() + 2946 30 swift 0x00000000007645a2 frontend_main(llvm::ArrayRef<char const*>, char const*, void*) + 2482 31 swift 0x000000000075f181 main + 2705 Stack dump: 0. Program arguments: /path/to/build/Ninja-ReleaseAssert/swift-linux-x86_64/bin/swift -frontend -c -primary-file validation-test/compiler_crashers/28200-swift-typebase-getdesugaredtype.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-name main -o /tmp/28200-swift-typebase-getdesugaredtype-20fee1.o 1. While type-checking 'S' at validation-test/compiler_crashers/28200-swift-typebase-getdesugaredtype.swift:7:1 2. While type-checking expression at [validation-test/compiler_crashers/28200-swift-typebase-getdesugaredtype.swift:8:7 - line:8:9] RangeText="c<T" 3. While type-checking expression at [validation-test/compiler_crashers/28200-swift-typebase-getdesugaredtype.swift:8:7 - line:8:7] RangeText="c" <unknown>:0: error: unable to execute command: Segmentation fault <unknown>:0: error: compile command failed due to signal (use -v to see invocation) ``` | 12 January 2016, 18:04:56 UTC |
| f82389a | Maxim Moiseev | 12 January 2016, 17:29:50 UTC | Merge pull request #923 from johnlui/master [stdlib] Change C-style for loop to Swift-style for-in loop | 12 January 2016, 17:29:50 UTC |
| e8886a4 | Maxim Moiseev | 12 January 2016, 17:27:48 UTC | Merge pull request #920 from practicalswift/gyb-fixes [gardening] Clean up .gyb-files: Remove unused imports. Non-controversial PEP8 fixes. | 12 January 2016, 17:27:48 UTC |
| 755156a | Dmitri Gribenko | 12 January 2016, 16:50:06 UTC | Merge pull request #942 from practicalswift/swiftc-28199-swift-constraints-constraintsystem-performmemberlookup [swiftc] Add test case for crash triggered in swift::constraints::ConstraintSystem::performMemberLookup(…) | 12 January 2016, 16:50:06 UTC |
| fab6738 | Dmitri Gribenko | 12 January 2016, 16:45:41 UTC | Merge pull request #937 from smikes/bootstrap-ninja-set-make-program [build-script-impl][SR-58] When bootstrapping ninja, set CMAKE_MAKE_COMMAND | 12 January 2016, 16:45:41 UTC |
| 206d410 | Erik Eckstein | 12 January 2016, 16:13:46 UTC | disable an IDE test to unblock the bots | 12 January 2016, 16:13:46 UTC |
| 3e4d6c7 | Sam Mikes | 12 January 2016, 14:39:34 UTC | Reduce visibility of variables NINJA_BIN doesn't have to be exported, so don't export it PATH doesn't have to be changed, so don't change it | 12 January 2016, 14:39:34 UTC |
| 6b7eb00 | Joshua Garnham | 20 December 2015, 00:11:07 UTC | Removed reference to bug ID | 12 January 2016, 11:52:26 UTC |
| 429524a | Joshua Garnham | 20 December 2015, 00:10:06 UTC | Added a test to check the fix-it works correctly | 12 January 2016, 11:49:45 UTC |
| d231cb0 | Joshua Garnham | 19 December 2015, 21:19:51 UTC | Add check for decl attributes being applied to types in function declaration (fixes SR-215) | 12 January 2016, 11:49:45 UTC |
| 85231a2 | Chris Lattner | 12 January 2016, 07:17:15 UTC | Merge pull request #943 from practicalswift/typo-fixes-20160112 [gardening] Fix recently introduced typos | 12 January 2016, 07:17:15 UTC |
| ec113a3 | practicalswift | 12 January 2016, 06:45:50 UTC | Fix recently introduced typos. | 12 January 2016, 06:45:50 UTC |
| 2f78b70 | Chris Lattner | 12 January 2016, 06:43:27 UTC | recent diagnostics changes fixed 5 crashers and broke 1. | 12 January 2016, 06:43:27 UTC |
| e30cd93 | Chris Lattner | 12 January 2016, 06:18:55 UTC | Fix rdar://20395243 QoI: type variable reconstruction failing for tuple types ASTPrinter of type variables was trying to dig an original type out of the locator and archetype that opened the type variable in the first place. This was prone to failure and never helped, so just always print type vars as _. The affected diagnostics always come out better and this saves a word of storage for each type variable. | 12 January 2016, 06:20:19 UTC |
| 4a22cfe | Chris Lattner | 12 January 2016, 06:06:31 UTC | enhance diagnoseGeneralConversionFailure to handle conversions between tuple types with mismatched labels better, even if the element types cannot be resolved. | 12 January 2016, 06:20:19 UTC |
| a4a2f96 | practicalswift | 12 January 2016, 06:13:49 UTC | [swiftc] Add test case for crash triggered in swift::constraints::ConstraintSystem::performMemberLookup(swift::constraints::ConstraintKind, swift::DeclName, swift::Type, swift::constraints::ConstraintLocator*) Stack trace: ``` swift: /path/to/swift/include/swift/AST/Decl.h:2191: swift::Type swift::ValueDecl::getType() const: Assertion `hasType() && "declaration has no type set yet"' failed. 9 swift 0x0000000000edd28f swift::constraints::ConstraintSystem::performMemberLookup(swift::constraints::ConstraintKind, swift::DeclName, swift::Type, swift::constraints::ConstraintLocator*) + 3119 10 swift 0x0000000000ede9fa swift::constraints::ConstraintSystem::simplifyMemberConstraint(swift::constraints::Constraint const&) + 458 11 swift 0x0000000000ee0235 swift::constraints::ConstraintSystem::simplifyConstraint(swift::constraints::Constraint const&) + 69 12 swift 0x0000000000e81d47 swift::constraints::ConstraintSystem::addConstraint(swift::constraints::Constraint*, bool, bool) + 23 15 swift 0x0000000000f6eb55 swift::Expr::walk(swift::ASTWalker&) + 69 16 swift 0x0000000000ec0898 swift::constraints::ConstraintSystem::generateConstraints(swift::Expr*) + 200 17 swift 0x0000000000dfa110 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 256 18 swift 0x0000000000e00639 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 569 19 swift 0x0000000000e017b0 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*) + 112 20 swift 0x0000000000e01959 swift::TypeChecker::typeCheckPatternBinding(swift::PatternBindingDecl*, unsigned int) + 265 22 swift 0x0000000000e168a4 swift::TypeChecker::validateDecl(swift::ValueDecl*, bool) + 3876 23 swift 0x000000000100595c swift::DeclContext::lookupQualified(swift::Type, swift::DeclName, unsigned int, swift::LazyResolver*, llvm::SmallVectorImpl<swift::ValueDecl*>&) const + 2908 24 swift 0x000000000100436d swift::UnqualifiedLookup::UnqualifiedLookup(swift::DeclName, swift::DeclContext*, swift::LazyResolver*, bool, swift::SourceLoc, bool, bool) + 2269 25 swift 0x0000000000e3ca8b swift::TypeChecker::lookupUnqualified(swift::DeclContext*, swift::DeclName, swift::SourceLoc, swift::OptionSet<swift::NameLookupFlags, unsigned int>) + 187 28 swift 0x0000000000e6611e swift::TypeChecker::resolveIdentifierType(swift::DeclContext*, swift::IdentTypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 158 30 swift 0x0000000000e67024 swift::TypeChecker::resolveType(swift::TypeRepr*, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 164 31 swift 0x0000000000e6602a swift::TypeChecker::validateType(swift::TypeLoc&, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 42 32 swift 0x0000000000e13b4a swift::TypeChecker::checkInheritanceClause(swift::Decl*, swift::GenericTypeResolver*) + 4890 33 swift 0x0000000000e160a9 swift::TypeChecker::validateDecl(swift::ValueDecl*, bool) + 1833 34 swift 0x000000000100595c swift::DeclContext::lookupQualified(swift::Type, swift::DeclName, unsigned int, swift::LazyResolver*, llvm::SmallVectorImpl<swift::ValueDecl*>&) const + 2908 35 swift 0x000000000100436d swift::UnqualifiedLookup::UnqualifiedLookup(swift::DeclName, swift::DeclContext*, swift::LazyResolver*, bool, swift::SourceLoc, bool, bool) + 2269 36 swift 0x0000000000e3ca8b swift::TypeChecker::lookupUnqualified(swift::DeclContext*, swift::DeclName, swift::SourceLoc, swift::OptionSet<swift::NameLookupFlags, unsigned int>) + 187 39 swift 0x0000000000e6611e swift::TypeChecker::resolveIdentifierType(swift::DeclContext*, swift::IdentTypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 158 41 swift 0x0000000000e67024 swift::TypeChecker::resolveType(swift::TypeRepr*, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 164 42 swift 0x0000000000e6602a swift::TypeChecker::validateType(swift::TypeLoc&, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 42 43 swift 0x0000000000e13b4a swift::TypeChecker::checkInheritanceClause(swift::Decl*, swift::GenericTypeResolver*) + 4890 44 swift 0x0000000000e160a9 swift::TypeChecker::validateDecl(swift::ValueDecl*, bool) + 1833 49 swift 0x0000000000e1b266 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 150 50 swift 0x0000000000de77a2 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int) + 1474 51 swift 0x0000000000c9f042 swift::CompilerInstance::performSema() + 2946 53 swift 0x00000000007645a2 frontend_main(llvm::ArrayRef<char const*>, char const*, void*) + 2482 54 swift 0x000000000075f181 main + 2705 Stack dump: 0. Program arguments: /path/to/build/Ninja-ReleaseAssert/swift-linux-x86_64/bin/swift -frontend -c -primary-file validation-test/compiler_crashers/28199-swift-constraints-constraintsystem-performmemberlookup.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-name main -o /tmp/28199-swift-constraints-constraintsystem-performmemberlookup-bedf87.o 1. While type-checking 'A' at validation-test/compiler_crashers/28199-swift-constraints-constraintsystem-performmemberlookup.swift:8:1 2. While resolving type A at [validation-test/compiler_crashers/28199-swift-constraints-constraintsystem-performmemberlookup.swift:9:12 - line:9:12] RangeText="A" 3. While resolving type e at [validation-test/compiler_crashers/28199-swift-constraints-constraintsystem-performmemberlookup.swift:10:9 - line:10:9] RangeText="e" 4. While type-checking expression at [validation-test/compiler_crashers/28199-swift-constraints-constraintsystem-performmemberlookup.swift:9:20 - line:9:22] RangeText="A.e" <unknown>:0: error: unable to execute command: Aborted <unknown>:0: error: compile command failed due to signal (use -v to see invocation) ``` | 12 January 2016, 06:13:49 UTC |
| 481fb4c | Doug Gregor | 12 January 2016, 05:48:30 UTC | Merge pull request #938 from milseman/suppress_warnings_api API to suppress warnings | 12 January 2016, 05:48:30 UTC |
| 10c8ce8 | Slava Pestov | 09 January 2016, 10:07:04 UTC | SILGen: Correctly emit accessors synthesized to witness protocol requirements We weren't adding them as external decls unless they were for storage on an imported type, which meant SILGen wasn't emitting them if the conforming type was from a different Swift source file, or in whole-module mode, a different module. This led to linker errors. Instead, always add accessors to the external decl list, but skip them in SILGen if they are contained in the DeclContext we are currently emitting (which is a source file or module). Note that they are still emitted with the wrong linkage, from a resilience perspective. Clients must only ever see public exports for getters, setters and materializeForSet emitted because they are required by resilience or the access pattern; 'accidental' accessors synthesized for protocol conformance should not be public. | 12 January 2016, 05:40:25 UTC |
| 80270a9 | Michael Ilseman | 12 January 2016, 05:30:18 UTC | Incorporate Doug's review suggestions | 12 January 2016, 05:30:18 UTC |
| 162becc | Doug Gregor | 12 January 2016, 05:07:36 UTC | Merge pull request #941 from apple/revert-244-dev Revert "Remove unnecessary 'visitDecl' default cases." | 12 January 2016, 05:07:36 UTC |
| d1707c0 | Doug Gregor | 12 January 2016, 05:07:21 UTC | Revert "Remove unnecessary 'visitDecl' default cases." | 12 January 2016, 05:07:21 UTC |
| bef0657 | Doug Gregor | 12 January 2016, 04:48:58 UTC | Merge pull request #244 from mohammadg/dev Remove unnecessary 'visitDecl' default cases. | 12 January 2016, 04:48:58 UTC |
| 8d835de | Chris Lattner | 12 January 2016, 04:47:47 UTC | My diagnostics fix fixed this test along the way. | 12 January 2016, 04:47:47 UTC |
| a5a988e | Chris Lattner | 12 January 2016, 04:41:18 UTC | Fix rdar://22509125 QoI: Error when unable to infer generic archetype lacks greatness Rearrange diagnoseGeneralConversionFailure to diagnose structural problems even if we have some UnresolvedTypes floating around, then reject constraint failures with UnresolvedTypes in them even harder. This keeps us giving good errors about failures where we have a structural problem (with buried irrelevant details) while not complaining about cases that are actually ambiguous. The end result of this is that we produce a lot better error messages in the case of failed archetype inference. This also highlights the poor job we do handling multi-stmt closureexprs... | 12 January 2016, 04:45:11 UTC |
| 13d96b3 | Chris Lattner | 12 January 2016, 04:31:16 UTC | Spell out these diagnostics more, they are embarassing, but we should fix that not hide it. | 12 January 2016, 04:45:11 UTC |
| 3c5c93a | Doug Gregor | 12 January 2016, 04:42:54 UTC | Merge pull request #669 from practicalswift/perl-fixes [Perl] Use pragma to restrict unsafe constructs | 12 January 2016, 04:42:54 UTC |
| f0d294b | Dmitri Gribenko | 12 January 2016, 04:41:24 UTC | Merge pull request #884 from practicalswift/apostrophes [gardening] Replace left/right quotation marks | 12 January 2016, 04:41:24 UTC |
| 1915b06 | Doug Gregor | 12 January 2016, 04:39:21 UTC | Merge pull request #781 from JaSpa/highlight-generic-args [Sema] Highlight angle brackets <…> in diagnostics | 12 January 2016, 04:39:21 UTC |
| a9e1fc0 | Doug Gregor | 12 January 2016, 04:35:14 UTC | Merge pull request #899 from gregomni/sr-427 [SR-427][AST] Report DoesNotConform for failed substitutions in a bound generic type. | 12 January 2016, 04:35:14 UTC |
| ab35b15 | Doug Gregor | 12 January 2016, 04:34:32 UTC | Merge pull request #932 from practicalswift/swiftc-28197-swift-typebase-getdesugaredtype [swiftc] Add test case for crash triggered in swift::TypeBase::getDesugaredType() | 12 January 2016, 04:34:32 UTC |
| 0e48b9c | Jordan Rose | 12 January 2016, 04:01:30 UTC | [docs] Note that the Lexicon file uses Sphinx-specific features. I don't like this not being viewable on GitHub, but I don't want to reformat it all to use bare definition lists and refs at the moment. | 12 January 2016, 04:01:30 UTC |
| daca24f | Jordan Rose | 12 January 2016, 03:56:29 UTC | [docs] Add a "Lexicon" file that defines common Swift jargon terms. Inspired by LLVM's similar file. (Thanks for reminding me about that, Chris!) | 12 January 2016, 03:57:19 UTC |
| 5e1d65c | Slava Pestov | 11 January 2016, 23:14:39 UTC | SILGen: Remove some Builtins that are no longer needed These were only used by the Sema-synthesized materializeForSet. | 12 January 2016, 03:55:46 UTC |
| 249242b | Slava Pestov | 10 January 2016, 09:23:57 UTC | SILGen: Always open-code materializeForSet This improves MaterializeForSetEmitter to support emission of static materializeForSet thunks, as well as witnesses. This is now done by passing in a nullptr as the conformance and requirement parameters, and adding some conditional code. Along the way, I fixed a few limitations of the old code, namely weak/unowned and static stored properties weren't completely plumbed through. There was also a memory leak in addressed materializeForSet, the valueBuffer was never freed. Finally, remove the materializeForSet synthesis in Sema since it is no longer needed, which fixes at least one known crash case. | 12 January 2016, 03:53:16 UTC |
| 3085094 | Chris Lattner | 12 January 2016, 03:37:12 UTC | fix <rdar://problem/23942743> [QoI] Bad diagnostic when errors inside enum constructor On something like this: let x = .Tomato(cloud: .None) we previously emitted a "type of expression is ambiguous without more context" error while pointing to .None. With a previous fix, we now produce the same error pointing to the .Tomato. With this fix, we now produce: error: reference to member 'Tomato' cannot be resolved without a contextual type to really drive the problem home. | 12 January 2016, 03:37:12 UTC |
| 26b51bf | Chris Lattner | 12 January 2016, 03:17:08 UTC | Fix rdar://19710848 QoI: Friendlier error message for "[] as Set" This makes diagnoseGeneralConversionFailure more conservative: it now never diagnoses a failed conversion when it involves a type that has unresolved type in it. These types could not be resolved, so it is better to let ambiguity resolution handle the problem. On "[] as Set", we would previously get: error: 'Set<_>' is not convertible to 'Set<Element>' now we get: error: generic parameter 'Element' could not be inferred | 12 January 2016, 03:19:06 UTC |
| 1dff04e | Slava Pestov | 12 January 2016, 02:35:12 UTC | SILGen: Add a new RValue(AbstractionPattern, CanType) constructor | 12 January 2016, 02:41:29 UTC |
| a6de984 | Dmitri Gribenko | 12 January 2016, 02:22:51 UTC | Merge pull request #936 from EZ-NET/correct_document_array-type-parameter-name [stdlib] [docs] Modify names of Array's type parameter and Slice in comments. | 12 January 2016, 02:22:51 UTC |
| e4bf75f | Tomohiro Kumagai | 12 January 2016, 02:09:15 UTC | [stdlib] [docs] Re-wrap some paragraphs to fit within 80 characters. #936 | 12 January 2016, 02:09:15 UTC |
| 09149ae | Chris Lattner | 12 January 2016, 01:32:41 UTC | Fix some validation test failures introduced by b5500b8, by handling UnresolvedType in a couple places I missed. | 12 January 2016, 01:33:10 UTC |
| 7b5741d | Erik Eckstein | 12 January 2016, 01:10:29 UTC | SideEffectAnalysis: consider that @callee_owned calls implicitly release the context. fixes rdar://problem/24112977 | 12 January 2016, 01:32:15 UTC |
| 41bcdb3 | Chris Lattner | 12 January 2016, 01:14:27 UTC | add newline at end of file to silence warning. | 12 January 2016, 01:14:27 UTC |
| b5500b8 | Chris Lattner | 12 January 2016, 01:02:25 UTC | Generalize the conditions in which we'll accept an ambiguous solution to a constraint system in "allowFreeTypeVariables" mode. Previously, we only allowed a few specific constraints, now we allow any relational and member constraints. The later one is a big deal because it means that we can allow ".Foo" expressions as ambiguous solutions, which CSDiags can handle well. This unblocks solving 23942743 and enables some minor improvements across the board, including diagnosing things like this better: Optional(.none) // now: generic parameter 'T' could not be inferred That said, it also just permutes some non-awesome diagnostics. | 12 January 2016, 01:04:46 UTC |
| d282fd7 | Michael Ilseman | 12 January 2016, 00:48:42 UTC | Allow suppressing individual diagnostics. Extend DiagnosticState to track per-diagnostic desired behaviors, allowing users of the APIs to individually suppress diagnostics. | 12 January 2016, 00:48:42 UTC |
| d78bb0f | Dmitri Gribenko | 12 January 2016, 00:27:47 UTC | Merge branch 'master' into swift-2.2-branch | 12 January 2016, 00:27:47 UTC |
| 42591f7 | Dmitri Gribenko | 11 January 2016, 23:46:50 UTC | SourceKit CMake: use the C compiler and linker flags computed by the Swift build system | 12 January 2016, 00:23:54 UTC |
| 08854d1 | Dmitri Gribenko | 11 January 2016, 23:47:29 UTC | SourceKit CMake: remove code to handle legacy SDKs | 12 January 2016, 00:23:54 UTC |
