https://github.com/torvalds/linux
Revision b98749cac4a695f084a5ff076f4510b23e353ecd authored by Aurelien Aptel on 29 March 2019, 09:49:12 UTC, committed by Steve French on 16 April 2019, 14:38:38 UTC
In the oplock break handler, writing pending changes from pages puts
the FileInfo handle. If the refcount reaches zero it closes the handle
and waits for any oplock break handler to return, thus causing a deadlock.
To prevent this situation:
* We add a wait flag to cifsFileInfo_put() to decide whether we should
wait for running/pending oplock break handlers
* We keep an additionnal reference of the SMB FileInfo handle so that
for the rest of the handler putting the handle won't close it.
- The ref is bumped everytime we queue the handler via the
cifs_queue_oplock_break() helper.
- The ref is decremented at the end of the handler
This bug was triggered by xfstest 464.
Also important fix to address the various reports of
oops in smb2_push_mandatory_locks
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
CC: Stable <stable@vger.kernel.org>
1 parent e6d0fb7
Tip revision: b98749cac4a695f084a5ff076f4510b23e353ecd authored by Aurelien Aptel on 29 March 2019, 09:49:12 UTC
CIFS: keep FileInfo handle live during oplock break
CIFS: keep FileInfo handle live during oplock break
Tip revision: b98749c
| File | Mode | Size |
|---|---|---|
| 6lowpan | ||
| 802 | ||
| 8021q | ||
| 9p | ||
| appletalk | ||
| atm | ||
| ax25 | ||
| batman-adv | ||
| bluetooth | ||
| bpf | ||
| bpfilter | ||
| bridge | ||
| caif | ||
| can | ||
| ceph | ||
| core | ||
| dcb | ||
| dccp | ||
| decnet | ||
| dns_resolver | ||
| dsa | ||
| ethernet | ||
| hsr | ||
| ieee802154 | ||
| ife | ||
| ipv4 | ||
| ipv6 | ||
| iucv | ||
| kcm | ||
| key | ||
| l2tp | ||
| l3mdev | ||
| lapb | ||
| llc | ||
| mac80211 | ||
| mac802154 | ||
| mpls | ||
| ncsi | ||
| netfilter | ||
| netlabel | ||
| netlink | ||
| netrom | ||
| nfc | ||
| nsh | ||
| openvswitch | ||
| packet | ||
| phonet | ||
| psample | ||
| qrtr | ||
| rds | ||
| rfkill | ||
| rose | ||
| rxrpc | ||
| sched | ||
| sctp | ||
| smc | ||
| strparser | ||
| sunrpc | ||
| switchdev | ||
| tipc | ||
| tls | ||
| unix | ||
| vmw_vsock | ||
| wimax | ||
| wireless | ||
| x25 | ||
| xdp | ||
| xfrm | ||
| Kconfig | -rw-r--r-- | 13.9 KB |
| Makefile | -rw-r--r-- | 2.5 KB |
| compat.c | -rw-r--r-- | 23.9 KB |
| socket.c | -rw-r--r-- | 91.8 KB |
| sysctl_net.c | -rw-r--r-- | 3.0 KB |
Computing file changes ...
