Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
b9a07d6 Andrew Scott 27 April 2022, 19:01:09 UTC release: cut the v14.0.0-next.15 release (#45784) 27 April 2022, 19:01:09 UTC
c589e4d Andrew Scott 27 April 2022, 18:50:36 UTC docs: release notes for the v13.3.5 release (#45781) 27 April 2022, 18:50:36 UTC
4d6a1d6 dario-piotrowicz 20 June 2021, 11:03:48 UTC fix(compiler): scope css keyframes in emulated view encapsulation (#42608) Ensure that keyframes rules, defined within components with emulated view encapsulation, are scoped to avoid collisions with keyframes in other components. This is achieved by renaming these keyframes to add a prefix that makes them unique across the application. In order to enable the handling of keyframes names defined as strings the previous strategy of replacing quoted css content with `%QUOTED%` (introduced in commit 7f689a2) has been removed and in its place now only specific characters inside quotes are being replaced with placeholder text (those are `;`, `:` and `,`, more can be added in the future if the need arises). Closes #33885 BREAKING CHANGE: Keyframes names are now prefixed with the component's "scope name". For example, the following keyframes rule in a component definition, whose "scope name" is host-my-cmp: @keyframes foo { ... } will become: @keyframes host-my-cmp_foo { ... } Any TypeScript/JavaScript code which relied on the names of keyframes rules will no longer match. The recommended solutions in this case are to either: - change the component's view encapsulation to the `None` or `ShadowDom` - define keyframes rules in global stylesheets (e.g styles.css) - define keyframes rules programmatically in code. PR Close #42608 27 April 2022, 17:27:17 UTC
3d45484 Alex Rickabaugh 22 April 2022, 21:29:23 UTC refactor(compiler-cli): support schemas in standalone components (#45752) This commit adds support for `@Component.schemas` in both JIT and AOT. PR Close #45752 27 April 2022, 17:25:53 UTC
2eb39c0 Sumit Arora 25 April 2022, 21:50:43 UTC fix(devtools): inline loading svg (#45762) * inlined loading animation svg instead of using absolute url * removing unused assets folder from the build PR Close #45762 27 April 2022, 16:07:38 UTC
7d8998c dario-piotrowicz 23 April 2022, 21:12:10 UTC docs: empty alt of aio home decorative images (#45740) in the aio home page the sections' decorative images provide an alt texts, which shouldn't actually be present (see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such alt text for a better user experience PR Close #45740 27 April 2022, 16:06:12 UTC
a895da6 dario-piotrowicz 23 April 2022, 21:09:52 UTC docs: use proper sections in aio home (#45740) convert the `div` groups in the aio home page to proper `section`s with a valid heading/title PR Close #45740 27 April 2022, 16:06:12 UTC
d1a9fd5 dario-piotrowicz 23 April 2022, 21:06:18 UTC docs: make sure aio home has a non-ignored h1 (#45740) currently the aio home page presents a single h1 which is ignored by assistive technologies since it has its display set none, so replace it with a new h1 containing the main text of the page instead PR Close #45740 27 April 2022, 16:06:12 UTC
882f595 Alex Rickabaugh 21 April 2022, 20:32:13 UTC refactor(core): support `ModuleWithProviders` directly in `importProvidersFrom` (#45722) There were two problems with the `importProvidersFrom` function related to `ModuleWithProviders` values: * The public type did not accept `ModuleWithProviders` values directly. * The implementation of `walkProviderTree` delegates collection of MWP providers to its caller, in order for the ordering of such providers to be correct. However, `importProvidersFrom` was not performing that collection, causing MWP providers passed in at the top level to be dropped. PR Close #45722 27 April 2022, 16:05:51 UTC
3896f57 Alex Rickabaugh 21 April 2022, 20:27:14 UTC refactor(core): move ModuleWithProviders type (#45722) This commit moves the ModuleWithProviders type from `metadata` to `di`, avoiding the need for `di` to reference `metadata` (in this particular case). PR Close #45722 27 April 2022, 16:05:51 UTC
39c1681 Pawel Kozlowski 21 April 2022, 08:33:56 UTC test(core): add more tests for the standalone components (#45709) Add more tests verifying the following conditions: - discovery of DI providers from exported NgModules - forwardRef in standalone component imports PR Close #45709 27 April 2022, 16:05:33 UTC
f282ca4 dario-piotrowicz 25 April 2022, 20:57:22 UTC fix(docs-infra): fix alert child margin issue (#45761) replace the generic `*` selector used in the alert styling with `p` (which is what gets generated from the markdown) as the styling adds margins which are not always wanted PR Close #45761 27 April 2022, 16:04:30 UTC
71f64f2 George Kalpakas 27 April 2022, 10:32:09 UTC docs(upgrade): move import back into docregion in `rollup-config.js` (#45778) This was accidentally broken in #45405. PR Close #45778 27 April 2022, 16:04:09 UTC
2b5c2d6 Pawel Kozlowski 26 April 2022, 12:39:30 UTC refactor(core): create a standalone injector during applicationBootstrap (#45766) This commit changes the injectors hiearchy created during applicationBootstrap. From now on a standalone injector (holding all the ambient providers of a standalone component) is create as a child of the application injector. This change alligns injectors hierarchy for bootstrapped and dynamically created standalone components. PR Close #45766 27 April 2022, 16:03:50 UTC
7b367d9 Andrew Scott 23 April 2022, 14:25:21 UTC refactor(router): Remove unnecessary setTimeout in UrlTree redirects (#45735) Using `setTimeout` in the Router navigation pipeline creates fragile and unpredictable behavior. Additionally, it creates a new macrotask, which would trigger an unnecessary change detection in the application. This `setTimeout` was added in https://github.com/angular/angular/commit/15e397816f98ec16839c30fd5c1ea01c7444fb84. Both tests added in that commit still pass. Additionally, the comment for _why_ the `setTimeout` was added doesn't really explain how the described bug would occur. There has been a lot of work in the Router since then to stabalize edge case scenarios so it's possible it existed before but doesn't anymore. Removing this `setTimeout` revealed tests that relied on the navigation not completing. For example, the test suite did not have a route which matched the redirect, but the test passed because it ended before the redirect was flushed, so the `Router` never threw an error. Similar situations exist for the other use of `setTimeout` in the Route (the one in the location change listener). There were no other failures in TGP other than incorrectly written tests. BREAKING CHANGE: When a guard returns a `UrlTree`, the router would previously schedule the redirect navigation within a `setTimeout`. This timeout is now removed, which can result in test failures due to incorrectly written tests. Tests which perform navigations should ensure that all timeouts are flushed before making assertions. Tests should ensure they are capable of handling all redirects from the original navigation. PR Close #45735 27 April 2022, 15:56:31 UTC
f1cc4a6 Paul Gschwendtner 26 April 2022, 14:06:16 UTC build: update tsec and drop corresponding postinstall patch (#45767) Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: https://github.com/google/tsec/pull/25 PR Close #45767 26 April 2022, 18:48:34 UTC
9d755fa Renovate Bot 26 April 2022, 10:16:36 UTC build: update actions/checkout action to v3.0.2 (#45764) PR Close #45764 26 April 2022, 17:11:43 UTC
284329e Alex Rickabaugh 21 April 2022, 19:42:49 UTC refactor(core): delay standalone component scoping in JIT (#45720) This commit moves standalone component scoping into the closures for `directiveDefs` and `pipeDefs` in JIT mode. This is necessary to support recursive standalone components, which necessarily use a `forwardRef` within their import cycle. Previously, the JIT compiler for standalone components attempted immediate `forwardRef` resolution, resulting in infinite recursion. PR Close #45720 26 April 2022, 17:07:41 UTC
4e0784c Alex Rickabaugh 20 April 2022, 15:00:50 UTC refactor(compiler-cli): optimize InjectorDef imports generation (#45701) Before standalone, everything that could appear in an NgModule's `imports` was relevant to DI, and needed to be emitted in the `imports` of the generated `InjectorDef` definition. With the introduction of standalone types, NgModule `imports` can now contain components, directives, and pipes which are standalone. Only standalone components need to be included in the `imports` of the generated injector definition - directives and pipes have no effect on DI. Having them present doesn't cause any errors in the runtime (they're filtered out by the injector itself) but it does prevent tree-shaking. With this commit, the generation of `InjectorDef` now filters the `imports` to exclude directives and pipes as much as possible. It's not _always_ possible because an expression in `imports` may pull in both a directive and a `ModuleWithProviders` reference, and we have no way of referencing just the MWP part of that expression. Therefore this is an optimization, not a rule of `InjectorDef` compilation. PR Close #45701 26 April 2022, 17:07:23 UTC
b0379c8 Alex Rickabaugh 20 April 2022, 18:45:48 UTC refactor(compiler-cli): NgModule handler resolves `imports` individually (#45701) Previously, the NgModule handler would resolve the `imports` field as one unit, producing an array of `Reference`s. With this refactoring, if `imports` is a literal array, each individual element will be resolved independently. This will allow filtering in the future at the element level, since there will be a separate `ts.Expression` for each individual element. PR Close #45701 26 April 2022, 17:07:23 UTC
18db4ef Alex Rickabaugh 20 April 2022, 18:03:34 UTC refactor(compiler-cli): introduce ResolvedModuleWithProviders (#45701) This commit updates the `ForeignFunctionResolver` used by the NgModule handler to resolve `ModuleWithProvider` types. Previously, this resolver returned the NgModule `Reference` directly, but there are two problems with this: * It's not completely accurate, as the expression returned by the MWP call will not return the NgModule at runtime. * We need the ability to distinguish the MWP call itself from an ordinary NgModule reference in future optimizations. PR Close #45701 26 April 2022, 17:07:23 UTC
c614f31 Alex Rickabaugh 20 April 2022, 16:30:59 UTC refactor(compiler-cli): rework ForeignFunctionResolvers (#45701) This commit reworks the partial evaluation system's concept of a ForeignFunctionResolver. Previously, resolvers were expected to return a `ts.Expression` which the partial evaluator would continue evaluating, eventually returning a value. This works well for "transparent" foreign functions like `forwardRef`, but for things like `ModuleWithProviders` it breaks down, because the desired resolution value (the NgModule `Reference`) is _not_ the "correct" evaluation of the function call. To support better FFR implementations, this commit refactors the FFR system so that resolvers operate on the `ts.CallExpression` instead, and are given a callback to resolve further expressions if needed. If they cannot resolve a given call expression, they have an `unresolvable` value that they can return to indicate that. PR Close #45701 26 April 2022, 17:07:23 UTC
7992132 Pawel Kozlowski 22 April 2022, 13:27:01 UTC test(core): dynamic component creation and standalone injectors hierarchy (#45726) This commits adds more tests around dynamic component creation and environement injectors hierarchy. PR Close #45726 25 April 2022, 22:00:33 UTC
31d7c3b Michal Materowski 15 April 2022, 17:38:50 UTC feat(common): add getState method to LocationStrategy interface (#45648) Adds getState to LocationStrategy interface as it suppose to be the place to control all window.location interactions. BREAKING CHANGE: Adds new required class member that any implementors of the LocationStrategy will need to satisfy. Location does not depend on PlatformLocation anymore. PR Close #45648 25 April 2022, 17:41:30 UTC
50004c1 Andrew Scott 13 April 2022, 18:40:38 UTC feat(router): Support lazy loading standalone components with `loadComponent` (#45705) Similarly to the symmetry being strengthened between children and loadChildren, a new loadComponent property will be introduced as the asynchronous version of component. This will allow for direct single-component lazy loading: ``` {path: 'lazy/a', loadComponent: () => import('./lazy/a.component').then(m => m.ACmp)}, {path: 'lazy/b', loadComponent: () => import('./lazy/b.component').then(m => m.BCmp)}, ``` This option requires that the component being loaded is standalone and is implemented as a runtime check. Other notes: * Components are not loaded until all guards and resolvers complete. * Loading the component is included in the function passed to the router preloading strategy * `RouteConfigLoadStart` and `RouteConfigLoadEnd` events emit at the start and end of the component loading * `CanLoad` guards _do not_ apply to `loadComponent`. `canActivate` should be used instead, just like you would do if it were simply `component` instead. PR Close #45705 25 April 2022, 16:39:44 UTC
970a3b5 Joey Perrott 22 April 2022, 15:33:17 UTC fix(bazel): add this_is_bazel marker (#45728) Add marker for noting that this check confirms we are running in a bazel environment. PR Close #45728 22 April 2022, 19:46:23 UTC
4962a4a Andrew Scott 04 April 2022, 21:05:32 UTC feat(router): Allow `loadChildren` to return a `Route` array (#45700) This commit expands the `LoadChildrenCallback` to accept returning `Routes` in addition to the existing `NgModule` type. In addition, it adds a check to ensure these loaded routes all use standalone components. The components must be standalone because if they were not, we would not have the required `NgModule` which the component is declared in. Existing API: ``` {path: 'lazy/route', loadChildren: import('./lazy').then(m => m.LazyModule)} @NgModule({ imports: [ ExtraCmpModule, RouterModule.forChild([ {path: 'extra/route', component: ExtraCmp}, ]), ], }) export class LazyModule {} ``` The new API for lazy loading route configs with standalone components (no NgModule) is to expand `loadChildren` to allow returning simply a `Routes` array. ``` // parent.ts { path: 'parent', loadChildren: () => import('./children').then(m => m.ROUTES), } // children.ts export const ROUTES: Route[] = [ {path: 'child', component: ChildCmp}, ]; ``` Note that this includes minimal documentation updates. We need to include a holistic update to the documentation for standalone components in the future that includes this feature. PR Close #45700 22 April 2022, 16:25:20 UTC
3e46a42 Andrew Kushnir 21 April 2022, 02:32:33 UTC test(core): add integration test apps for the `bootstrapApplication` API (#45674) This commit adds 2 integration apps to verify the `bootstrapApplication` API behavior as well as keep track of the bundle size and retained symbols (tree-shaking). PR Close #45674 22 April 2022, 00:47:54 UTC
5771b18 Andrew Kushnir 21 April 2022, 02:31:35 UTC feat(core): add the `bootstrapApplication` function (#45674) This commit implements the `bootstrapApplication` function that allows bootstrapping an application and pass a standalone component as a root component. PR Close #45674 22 April 2022, 00:47:54 UTC
612d6e0 Paul Gschwendtner 13 April 2022, 13:02:54 UTC test: update size golden for hello-world-ivy-compat integration test (#45405) The main bundle fell below the 500b threshold. Likely because the global constant was fixed and is now tree-shakeable. The actual diff in the commit is a little confusing since it makes it seem that polyfills increased as part of this commit. This is not the case but just a side-effect of us accumulating various changes which are not reflected on a per-commit basis in the size golden. The actual sizes in master were: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 1105, actual: 1102). SUCCESS: Commit undefined uncompressed polyfills did NOT cross size threshold of 500 bytes or >1% (expected: 33846, actual: 33957). SUCCESS: Commit undefined uncompressed main did NOT cross size threshold of 500 bytes or >1% (expected: 132392, actual: 131893). ``` Now with this change: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 1105, actual: 1102). SUCCESS: Commit undefined uncompressed polyfills did NOT cross size threshold of 500 bytes or >1% (expected: 33846, actual: 33957). FAIL: Commit undefined uncompressed main fell below expected size by 500 bytes or >1% (expected: 132392, actual: 131883). ``` PR Close #45405 21 April 2022, 18:09:39 UTC
067e4c2 Paul Gschwendtner 13 April 2022, 08:16:37 UTC build: update systemjs aio boilerplate to work with APF v13+ `exports` field (#45405) The SystemJS examples were using an outdated version of rollup that did not support export fields. Now with the recent changes where we removed secondary package.json files, the rather old/somewhat outdated SystemJS examples failed bundling since exports were not considered. PR Close #45405 21 April 2022, 18:09:39 UTC
a50e2da Paul Gschwendtner 12 April 2022, 13:28:28 UTC fix(localize): ensure transitively loaded compiler code is tree-shakable (#45405) The localize primary entry-point (used at runtime in application code) indirectly loads from the compiler package for computing message ids. The compiler package has a couple of constants which cannot be DCE-ded/ tree-shaken due to side-effect reliance that is detected by Terser. We fix these constants to be three-shakable. Note that another issue technically would be that the compiler package has a side-effect call for `publishFacade` (for JIT), but that invocation is marked as pure by the Angular CLI babel optimization pipeline. So this results is no unused code currently but is risky and should be addressed in the future. PR Close #45405 21 April 2022, 18:09:39 UTC
4c56c45 Paul Gschwendtner 21 March 2022, 16:43:31 UTC refactor(localize): init APF entry-point should not duplicate code (#45405) This commit addresses two issues: * The init entry-point currenly access code from another entry-point using relative imports, resulting in code to be duplicated. * The init types are now bundled as part of the ng_package APF rule. There is an API extractor bundling issue with global module augmentations. API extractor does not properly handle module augmentation. We need to disable dts bundling for this entry-point to ensure `$localize` remains globally accessible for users. This is an option in the `ng_package` rule. Note that this worked before because `localize/init` was a `ts_library` that did not have its types bundled. As part of this change, the `MessageId` and `TargetMessage` exports are also made public. The localize exported functions rely on these types but they were not exported. Related to types, an exception is added for three private exports from the primary entry-point so that they will show up in the API golden. These private exports are re-exposed publicly in the init entry-point but no golden would capture them due to the private symbol prefix. One might wonder why the symbols are not guarded in the init golden. The reason is that goldens never inline signatures from cross-entry-points/packages to avoid duplication. Lastly, the i18n integration test golden had to be updated because the polyfills bundle increased slightly. After thorough and time-consuming investigation, this mostly happens due to different mangle identifies being used (the input code changed --> so the mangling determinism) Size before this change: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 929, actual: 926). SUCCESS: Commit undefined uncompressed main did NOT cross size threshold of 500 bytes or >1% (expected: 124544, actual: 124660). SUCCESS: Commit undefined uncompressed polyfills did NOT cross size threshold of 500 bytes or >1% (expected: 34530, actual: 34641). ``` After: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 929, actual: 926). SUCCESS: Commit undefined uncompressed main did NOT cross size threshold of 500 bytes or >1% (expected: 124544, actual: 124650). FAIL: Commit undefined uncompressed polyfills exceeded expected size by 500 bytes or >1% (expected: 34530, actual: 35252). ``` Inspecting/comparing without mangling shows that the new changes would actually result in a bundle reduction (potentially visible with gzip/brotli): ``` ➜ Desktop stat -f%z master-nomangle.js 101357 ➜ Desktop stat -f%z with-changes-nomangle.js 101226 ``` PR Close #45405 21 April 2022, 18:09:39 UTC
7a8a929 Paul Gschwendtner 21 March 2022, 16:40:42 UTC refactor: fix duplication in platform-server NPM package (#45405) The platform-server init entry-point imported code from another entry-point using a relative import. This resulted in the code to be bundled into the `init` entry-point as well. This has no breaking impact but resulted in a little code duplication that we should clean up. PR Close #45405 21 April 2022, 18:09:39 UTC
dd0fc0f Paul Gschwendtner 14 April 2022, 19:52:33 UTC test: add test for new `types_bundle` rule from Angular bazel package (#45405) Adds a little golden test for the new `types_bundle` rule that ensures the rule works at a general level. This rule will be useful for non-APF ESM packages like the Angular compiler-cli (for which we also want to bundle types to make them compatible with TypeScripts ESM type resolution) PR Close #45405 21 April 2022, 18:09:39 UTC
68597bb Paul Gschwendtner 21 March 2022, 11:24:52 UTC feat(bazel): speed up dev-turnaround by bundling types only when packaging (#45405) Speeds up the dev-turnaround by only bundling types when packaging. Currently bundling occurs for all the `ng_module` targets in devmode. This has various positive benefits: * Avoidance of this rather slower operation in development * Makes APF-built packages also handle types for `ts_library` targets consistently. * Allows us to ensure APF entry-points have `d.ts` _always_ bundled (working with ESM module resolution in TypeScript -- currently experimental) * Allows us to remove the secondary `package.json` files from APF (maybe APF v14? - seems low-impact). This would clean-up the APF even more and fix resolution issues (like in Vite) PR Close #45405 21 April 2022, 18:09:39 UTC
3dee3d1 George Kalpakas 14 April 2022, 14:10:45 UTC fix(docs-infra): fix placement of "Edit source" button on errors and diagnostics pages (#45634) This commit aligns the layout of errors and extended diagnostics pages more closely with other docs pages to ensure that the "Edit source" button is displayed correctly even when the heading is too long to fit on a single line. For error pages, in particular, this ensures that the button is not obscured by the error video. **Before:** ![error-pages before][1] **After:** ![error-pages after][2] [1]: https://user-images.githubusercontent.com/8604205/163408291-7aebd029-891c-4045-8fa2-a8e2b2b06dab.png [2]: https://user-images.githubusercontent.com/8604205/163408296-40e6df8e-aadc-4a82-978a-ab4d902b6f6e.png PR Close #45634 21 April 2022, 18:07:27 UTC
9292953 Andrew Kushnir 21 April 2022, 06:04:23 UTC fix(docs-infra): include `tslib` into SystemJS config in `upgrade-module` example app (#45706) This commit updates the SystemJS for one of the example apps (the `upgrade-module` one) to include a resolution rule for the `tslib`. This is needed in case `tslib` is referenced from the framework code (for example in case of downleveling of some operators). This makes it consistent with other example app configs. PR Close #45706 21 April 2022, 18:05:37 UTC
9e4c4bc Pawel Kozlowski 19 April 2022, 11:45:27 UTC docs(core): add API documentation to standalone-related classes (#45687) This commit adds some internal documentation. PR Close #45687 20 April 2022, 23:01:56 UTC
e162fa3 Pawel Kozlowski 14 April 2022, 17:19:54 UTC test(core): add more tests for the standalone injector (#45687) This commit reorganizes the tests around the EnvironmentInjector and its use for standalone injectors, and adds a number of new test cases. PR Close #45687 20 April 2022, 23:01:56 UTC
3616d7e Pawel Kozlowski 31 March 2022, 14:24:18 UTC refactor(core): implement standalone injectors (#45687) This commit implements the `StandaloneFeature` which provides for the creation of standalone injectors, for those components which need them. The feature-based implementation ensures the machinery for standalone injectors is properly tree-shakable. PR Close #45687 20 April 2022, 23:01:56 UTC
9f79513 Alex Rickabaugh 18 April 2022, 23:44:03 UTC refactor(core): support standalone components in importProvidersFrom (#45687) This commit refactors `importProvidersFrom` to support pulling providers from the dependencies of a standalone component, in addition to NgModules. Tests will be added in a future commit when standalone components can be created without calling private APIs. PR Close #45687 20 April 2022, 23:01:55 UTC
5a10fc4 Alex Rickabaugh 31 March 2022, 18:54:55 UTC feat(core): implement standalone directives, components, and pipes (#45687) This commit exposes the `standalone` flag on `@Directive`, `@Component`, and `@Pipe`, effectively making standalone components a part of Angular's public API. As part of this operation, it also implements JIT compilation for standalone types. Standalone types are Angular-decorated types which act as their own "declarations", where they would otherwise be declared in an NgModule. Marking an Angular type as standalone means that it can be used directly in other standalone components and in NgModules, without needing an associated NgModule to depend on it. In the case of a standalone component, template dependencies which would otherwise be specified by an NgModule are instead specified directly on the component itself, via the `imports` field. Other standalone types can be imported, as well as NgModules. PR Close #45687 20 April 2022, 23:01:55 UTC
bb6e11c Alex Rickabaugh 19 April 2022, 15:06:09 UTC refactor(compiler-cli): reorganize importProvidersFrom to avoid cycles (#45687) This commit extracts the `importProvidersFrom` function and associated machinery into a separate file, as opposed to being colocated with `R3Injector`. Separating these functions will mitigate potential future circular dependencies as `importProvidersFrom` starts being used in different parts of the codebase. PR Close #45687 20 April 2022, 23:01:55 UTC
dea8c86 dario-piotrowicz 22 February 2022, 22:38:47 UTC feat(router): add ariaCurrentWhenActive input to RouterLinkActive directive (#45167) add the ariaCurrentWhenActive input to the RouterLinkActive directive so that users can easily set the aria-current property to their active router links resolves #35051 PR Close #45167 20 April 2022, 22:14:01 UTC
d8226de Dylan Hunn 20 April 2022, 21:46:22 UTC release: cut the v14.0.0-next.14 release (#45704) PR Close #45704 20 April 2022, 21:47:03 UTC
f14763e Dylan Hunn 20 April 2022, 21:38:11 UTC docs: release notes for the v13.3.4 release (#45703) PR Close #45703 20 April 2022, 21:41:58 UTC
1d2f5c1 Andrew Scott 18 April 2022, 21:57:19 UTC refactor(router): deprecate no longer needed resolver fields (#45597) DEPRECATED: The `resolver` argument of the `RouterOutletContract.activateWith` function and the `resolver` field of the `OutletContext` class are deprecated. Passing component factory resolvers are no longer needed. The `ComponentFactoryResolver`-related symbols were deprecated in `@angular/core` package since v13. PR Close #45597 20 April 2022, 19:57:37 UTC
f4fd1a8 Andrew Scott 18 April 2022, 21:56:26 UTC feat(router): Add `EnvironmentInjector` to `RouterOutlet.activateWith` (#45597) The current API for `activateWith` uses the deprecated `ComponentFactoryResolver`. The replacement for this is to use `EnvironmentInjector`. That is, instead of ``` const factory = componentFactoryResolver.resolveComponentFactory(component); location.createComponent(factory, location.length, injector); ``` the replacement would be ``` location.createComponent( component, {index: location.length, injector, environmentInjector}); ``` PR Close #45597 20 April 2022, 19:57:37 UTC
4e0957a Andrew Scott 12 April 2022, 00:36:41 UTC feat(router): Add ability to specify providers on a Route (#45673) Currently, the only way to specify new providers for a `Route` and the children is to create a new `NgModule` with those providers and use the `loadChildren` feature. This is pretty confusing and a wholly indirect way of accomplishing this task. With this commit, developers will be able to specify a list of providers directly on the `Route` itself. These providers will apply the that route and its children. This feature was inspired by the upcoming standalone components feature. This ties in there because, as mentioned before, the prior art for lazy loading configs was to load an `NgModule`. This loaded module contained new route configs _and_ could specify new providers. Separating those two concepts, there should be a way to load _just_ some new routes, but there should also be a way to specify new providers as well (something you could do in the `NgModule` world and now will be able to do in the world without any `NgModule` through this feature). PR Close #45673 20 April 2022, 18:32:07 UTC
ba45428 Andrew Kushnir 20 April 2022, 17:08:00 UTC ci: update payload size golden file (#45699) This commit updates the payload size for the Forms-related test app. The CI started to fail after merging https://github.com/angular/angular/commit/ff3f5a8d12e3243620e311b690a050e26493e539. The payload size increase is most likely accumulated. PR Close #45699 20 April 2022, 17:29:38 UTC
ff3f5a8 Dylan Hunn 19 April 2022, 20:17:07 UTC fix(forms): Fix a typing bug in FormBuilder. (#45684) Previously, the following code would fail to compile: ``` let form: FormGroup<{email: FormControl<string | null>}>; form = fb.group({ email: ['', Validators.required] }); ``` This is because the compiler was unable to properly infer the inner type of `ControlConfig` arrays in some cases. The same issue applies to `FormArray` as well under certain circumstances. This change cleans up the `FormBuilder` type signatures to always use the explicit Element type, and to catch `ControlConfig` types that might fall through. PR Close #45684 20 April 2022, 16:15:46 UTC
788f587 Andrew Kushnir 20 April 2022, 04:51:14 UTC fix(docs-infra): avoid internal symbols from being referenced during auto-linking (#45689) This commit adds extra logic to avoid internal and privately exported symbols from being referenced during auto-linking. Currently such symbols can be used for linking, thus resulting in a non-existing link and causing the linking process to fail. PR Close #45689 20 April 2022, 16:11:22 UTC
47e5b05 Adrian Kunz 16 February 2022, 20:52:32 UTC test(http): Add + to encoding test (#45111) Changes the existing test for query parameter encoding to include the + symbol and its expected encoding to %2B. PR Close #45111 20 April 2022, 16:00:19 UTC
76a9a24 Adrian Kunz 16 February 2022, 19:47:57 UTC fix(http): encode + signs in query params as %2B (angular#11058) (#45111) Servers always decode + as a space, which is undesirable when one actually wants to query for a plus. BREAKING CHANGE: Queries including + will now actually query for + instead of space. Most workarounds involving custom codecs will be unaffected. Possible server-side workarounds will need to be undone. Fixes angular#11058 PR Close #45111 20 April 2022, 16:00:19 UTC
b8d3389 Alex Rickabaugh 18 April 2022, 15:59:00 UTC test(compiler-cli): tests for standalone components/directives/pipes (#45672) This commit bundles tests for standalone components that are possible after previous implementation commits. Most new tests are compliance tests, but a test is also included to validate that the template type-checking system can work with standalone components as well. PR Close #45672 20 April 2022, 12:45:57 UTC
d3c0fa3 Alex Rickabaugh 19 April 2022, 20:15:39 UTC refactor(compiler-cli): propagate standalone flag in .d.ts metadata (#45672) This commit adds a type field to .d.ts metadata for directives, components, and pipes which carries a boolean literal indicating whether the given type is standalone or not. For backwards compatibility, this flag defaults to `false`. Tests are added to validate that standalone types coming from .d.ts files can be correctly imported into new standalone components. PR Close #45672 20 April 2022, 12:45:57 UTC
80d2cda Alex Rickabaugh 20 April 2022, 00:00:22 UTC test: set skipLibCheck on ngcc integration test (#45672) The ngcc integration test is in an awkward state: it's attempting to test that the current ngcc can process @angular/core at v12. We need to make a forwards-incompatible change to the typings of @angular/core, which means that the compiled typings from the current ngcc won't be compatible with core as of v12. To get around this and allow the integration test to have some value, we're disabling library checking for the time being. PR Close #45672 20 April 2022, 12:45:57 UTC
99b3af4 Alex Rickabaugh 18 April 2022, 16:58:23 UTC refactor(compiler-cli): emit isStandalone flag in partial declarations (#45672) This commit propagates the `isStandalone` flag for a component, directive, or pipe during partial compilation of a standalone declaration. This flag allows the linker to properly process a standalone declaration that it encounters. PR Close #45672 20 April 2022, 12:45:57 UTC
1244a14 Alex Rickabaugh 15 April 2022, 18:24:51 UTC refactor(compiler-cli): move standalone scope computation out of handler (#45672) Standalone component scopes were first implemented in the `ComponentDecoratorHandler` itself, due to an assumption that "standalone" allowed for a localized analysis of the component's dependencies. However, this is not strictly true. Other compiler machinery also needs to understand component scopes, including standalone component scopes. A good example is the template type-checking engine, which uses a `ComponentScopeReader` to build full metadata objects (that is, metadata that considers the entire inheritance chain) for type-checking purposes. Therefore, the `ComponentScopeReader` should be able to give the scope for a standalone component. To achieve this, a new `StandaloneComponentScopeReader` is implemented, and the return type of `ComponentScopeReader.getScopeForComponent` is expanded to express standalone scopes. This cleanly integrates the "standalone" concept into the existing machinery. PR Close #45672 20 April 2022, 12:45:56 UTC
d8086a1 Alex Rickabaugh 30 March 2022, 22:24:55 UTC refactor(compiler-cli): emit StandaloneFeature for standalone components (#45672) This commit adds an emit for standalone components of the `StandaloneFeature`, which will support creation of standalone injectors and any other mechanisms necessary for standalone component functionality at runtime. Using a feature allows for standalone functionality to be tree-shaken in applications that aren't using them. PR Close #45672 20 April 2022, 12:45:56 UTC
f9f8ef9 Alex Rickabaugh 30 March 2022, 22:16:56 UTC refactor(compiler-cli): emit NgModule dependencies of standalone components (#45672) This commit expands on the unified dependency tracking in the previous commit and adds tracking of NgModule dependencies. These are not used for standard components, but are emitted for standalone components to allow the runtime to roll up providers from those NgModules into standalone injectors. PR Close #45672 20 April 2022, 12:45:56 UTC
9b35787 Alex Rickabaugh 29 March 2022, 23:26:40 UTC refactor(compiler-cli): unify tracked template scope dependencies (#45672) Previously, the compiler tracked directives and pipes in template scopes separately. This commit refactors the scope system to unify them into a single data structure, disambiguated by a `kind` field. PR Close #45672 20 April 2022, 12:45:56 UTC
1527e8f Alex Rickabaugh 28 March 2022, 23:50:26 UTC refactor(core): change component emit to 'dependencies' (#45672) Previously, the compiler would represent template dependencies of a component in its component definition through separate fields (`directives`, `pipes`). This commit refactors the compiler/runtime interface to use a single field (`dependencies`). The runtime component definition object still has separate `directiveDefs` and `pipeDefs`, which are calculated from the `dependencies` when the definition is evaluated. This change is also reflected in partially compiled declarations. To ensure compatibility with partially compiled code already on NPM, the linker will still honor the old form of declaration (with separate fields). PR Close #45672 20 April 2022, 12:45:56 UTC
046dad1 Alex Rickabaugh 30 March 2022, 00:58:24 UTC fix(compiler-cli): fix issue with incremental tracking of APIs for pipes (#45672) `PipeSymbol` contains logic to detect changes in the public API surface of pipes, which includes the pipe name. However, the pipe handler inadvertently uses the pipe class name instead of the actual pipe name to initialize the `PipeSymbol`, which breaks incremental compilation when pipe names change. There is a test which attempts to verify that this logic is working, but the test actually passes for a different reason. The test swaps the names of 2 pipes that are both used in a component, and asserts that the component is re-emitted, theoretically because the public APIs of the pipes is changed. However, the emit order of the references to the pipes depends on the order in which they match in the template, which changes when the names are swapped. This ordering dependency is picked up by the semantic dependency tracking system, and is what actually causes the component to be re-emitted and therefore the pipe test to pass in spite of the bug with name tracking. This commit fixes the `PipeSymbol` initialization to use the correct pipe name. The test is still flawed in that it's sensitive to the ordering of pipe emits, but this ordering is due to change soon as a result of the standalone components work, so this issue will be resolved in a future commit. PR Close #45672 20 April 2022, 12:45:56 UTC
989e840 Andrew Scott 14 April 2022, 00:35:19 UTC fix(router): Remove unused string type for ActivatedRoute.component (#45625) BREAKING CHANGE: The type of `component` on `ActivatedRoute` and `ActivatedRouteSnapshot` includes `string`. In reality, this is not the case. The component cannot be anything other than a component class. PR Close #45625 20 April 2022, 03:21:35 UTC
4ad7c2e Mangalraj 15 April 2022, 23:06:51 UTC docs: Update aio/content/guide/setup-local.md (#45644) Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> PR Close #45644 20 April 2022, 03:20:39 UTC
89f9d28 Mangalraj 14 April 2022, 23:52:52 UTC docs: correct the example command to install angular (#45644) PR Close #45644 20 April 2022, 03:20:39 UTC
0231a36 Paul Gschwendtner 19 April 2022, 15:48:25 UTC build: preparation for primary branch rename in the Angular repos (#45681) Preparation for the framework repo as outlined our planning document. PR Close #45681 20 April 2022, 03:19:46 UTC
6c4d9eb Andrew Scott 19 April 2022, 20:15:06 UTC test(common): Fix flaky Location test (#45683) This test has proven to be flaky. This commit greatly simplifies the test and moves it to a more appropriate location (pun intended). PR Close #45683 20 April 2022, 03:17:56 UTC
5d15595 Saurabh Kamble 19 April 2022, 15:16:53 UTC Fix typo (#45680) PR Close #45680 19 April 2022, 16:26:12 UTC
ceffded George Kalpakas 17 April 2022, 09:12:20 UTC docs(common): fix links to locales in i18n guides (#45661) In PR #42230, the locale file generation process was modified so that generated locale files are no longer checked into the repository. Update a few links in the docs that pointed to the previously checked in files to point to other places where the files exist. PR Close #45661 19 April 2022, 16:17:33 UTC
c6feb0a Jeremy Elbourn 18 April 2022, 16:29:19 UTC build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668 19 April 2022, 16:15:39 UTC
f5299a3 Louis Gombert 18 April 2022, 14:59:00 UTC docs: update decorators proposal stage and link in glossary (#45669) PR Close #45669 19 April 2022, 16:14:36 UTC
63202b9 Andrew Kushnir 18 April 2022, 17:39:41 UTC test: reset counters before running a styling test (#45670) This commit updates one of the styling tests to reset perf counters, making it order-independent and non-flaky (previously the test got random failures depending on whether there are other tests invoked before). PR Close #45670 19 April 2022, 16:14:09 UTC
ea8256f Andrew Scott 15 April 2022, 23:54:17 UTC refactor(router): Move config loader tracking to the RouterConfigLoader (#45656) This wasn't exactly possible before because the `RouterConfigLoader` was not an Injectable so there wasn't a straightforward way to share information between `ApplyRedirects` and the preloader. They each had their own implementation so they needed to store the values on the `Route` so they both had access to them. I imagine this was the case because trying to inject `Router` (to get access to the events) into the preloader would have caused a circular dependency. This refactor co-locates the loading details with the loader itself rather than leaking implementation into the public route config and mutating the object in an awkward way. This also promotes `RouterConfigLoader` to a proper `Injectable` so data can be shared throughout the system. PR Close #45656 18 April 2022, 23:05:45 UTC
ec5cb0b Marko Kaznovac 18 April 2022, 09:38:36 UTC docs: use language agnostic mdn urls (#45666) PR Close #45666 18 April 2022, 21:10:16 UTC
3477364 Marko Kaznovac 18 April 2022, 09:34:46 UTC docs: fix mdn links (#45666) PR Close #45666 18 April 2022, 21:10:16 UTC
174ce7d Andrew Kushnir 05 April 2022, 04:28:01 UTC feat(core): add `ApplicationRef.destroy` method (#45624) This commit implements the `destroy` method on the `ApplicationRef` class. This feature is a preparation for the new logic to bootstrap (and teardown) standalone components (without going through the `NgModuleRef` destroy), which would return an instance of the `ApplicationRef` (the current bootstrap APIs return an instance of the `NgModuleRef`). PR Close #45624 18 April 2022, 21:09:47 UTC
aa966fd Andrew Scott 18 April 2022, 17:44:42 UTC refactor(router): Use `EnvironmentInjector` for lazy loading APIs (#45671) The `EnvironmentInjector` should be used instead of `Injector` for the lazy loading. A future refactor will further update `RouterOutlet` to use this injector to create the component rather the deprecated `ComponentFactoryResolver`. PR Close #45671 18 April 2022, 21:08:43 UTC
eb7661c Andrew Scott 11 April 2022, 23:09:26 UTC refactor(router): unbundle the lazy loaded routes from the lazy loaded module injector (#45593) In the standalone world, these concepts will no longer be one and the same. You can load routes without them being inside an `NgModule` with `RouterModule.forChild`. In addition, routes will be able to define their own providers, which will be included in an injector that is not necessarily lazy loaded. PR Close #45593 18 April 2022, 16:52:56 UTC
d9f550c Andrew Scott 11 April 2022, 22:22:30 UTC refactor(router): Refactor loaded config to track injectors rather than `NgModuleRef` (#45593) The `Injector` is really the piece of information that the `Router` is interested in keeping track of. Storing the `NgModuleRef` is somewhat confusing based on how it's used later on. `RouterOutlet` uses it for the `componentFactoryResolver`, but this is not needed anymore (and deprecated). In fact, we can get back to the `NgModuleRef` anyways using the injector. For now, that's what this change does. A different refactor will remove the use of the `componentFactoryResolver` altogether. Additionally, in the standalone world, we plan to implement a feature to allow defining `providers` directly on the `Route`. This means there won't be an associated `NgModuleRef` so this refactor prepares for that feature. PR Close #45593 18 April 2022, 16:52:56 UTC
3578e94 Alex Rickabaugh 13 April 2022, 00:04:55 UTC refactor(core): internally support `providedIn: environment` (#45626) This commit adds a new internal scope to `R3Injector` for `EnvironmentInjector`s specifically. This will allow us to scope services to the environment side of the injector hierarchy specifically, as opposed to the `'any'` scope which also includes view-side injectors created via `Injector.create`. For now, this functionality is not exposed publicly, but is available to use within `@angular/core` only. PR Close #45626 18 April 2022, 16:28:43 UTC
d5a6cd1 Alex Rickabaugh 12 April 2022, 22:15:04 UTC feat(core): implement EnvironmentInjector with adapter to NgModuleRef (#45626) This commit exposes a new `EnvironmentInjector` abstraction, which generalizes the "module injector" concept to injectors that are not based on NgModules. An EnvironmentInjector is a conceptual analogue of an `NgModuleRef` - it represents an injector on the former "module" DI hierarchy in Angular (now renamed to the "environment injector hierarchy"). Environment injectors are created via the `createEnvironmentInjector` function from a list of `Provider`s. For backwards compatibility with current code using `NgModuleRef`, `EnvironmentInjector`s are wrapped by an adapter `NgModuleRef` implementation, so injecting `NgModuleRef` always returns the latest `EnvironmentInjector`, even if that injector was not based on an NgModule. Conversely, NgModule-based `NgModuleRef`s created via `createNgModuleRef` are _also_ `EnvironmentInjector`s. PR Close #45626 18 April 2022, 16:28:42 UTC
b568a5e Andrew Kushnir 01 April 2022, 05:48:25 UTC feat(core): implement `importProvidersFrom` function (#45626) This commit implements the `importProvidersFrom` function that allows extracting a list of `Provider`s from a list of NgModule types. The R3Injector which implements DI at the "module" level for Angular is refactored to use this functionality under the hood. This commit also implements `INJECTOR_INITIALIZER`, a DI multi-provider token which is used to run initialization logic when an injector is created. PR Close #45626 18 April 2022, 16:28:42 UTC
a5a7fbc Alex Rickabaugh 14 April 2022, 18:51:06 UTC test(core): fix a crosstalk issue with locale ids (#45626) Previously there was a test ordering issue with the application_module_spec tests where the value of `getLocaleId()` depended on the order in which tests ran. Specifically, `setLocaleId()` lower-cases the current locale ID, so the measured value in a test depended on whether a previous test had called `setLocaleId()` (the difference between 'en-US' and 'en-us'). PR Close #45626 18 April 2022, 16:28:42 UTC
1fe255c Doug Parker 11 April 2022, 23:28:35 UTC refactor(compiler): add `original_code` to `goog.getMsg()` options (#45606) This links back each placeholder in a message to the original Angular template span which defines its expression. This is useful for understanding where each placeholder comes from in the context of the full message. PR Close #45606 18 April 2022, 16:26:16 UTC
8c83f12 Andrew Kushnir 15 April 2022, 20:03:10 UTC ci: add more reviewers to the `docs-packaging-and-releasing` group (#45652) Currently that group has just 2 reviewers, but we often update the files that belong to that group during the deprecation period. Adding more people would allow to balance the reviews better. PR Close #45652 18 April 2022, 16:24:57 UTC
57f8ab2 Kristiyan Kostadinov 16 April 2022, 05:13:37 UTC fix(core): better error message when directive extends a component (#45658) We throw an error when a directive is trying to extend a component, but we don't actually say which class is responsible which can be difficult to track down. These changes add the two class names to the error message. PR Close #45658 18 April 2022, 16:24:23 UTC
b29b95b Kristiyan Kostadinov 18 April 2022, 07:35:56 UTC fix(devtools): clean up menu layout (#45665) The menus weren't using the `mat-menu` component correctly which had led to some inconsistent spacing and the need for style overrides. These changes correctly wrap the menu content in `mat-menu-item` which has the added benefit of having keyboard support. I had to keep some of the overrides in order to preserve the dense layout of the menus. I've also cleaned up the component by: * Removing some unnecessary styles. * Switching single-class usages of `ngClass` to `class.` bindings. * Not using `br` tags for spacing. PR Close #45665 18 April 2022, 16:23:13 UTC
6835710 Renovate Bot 15 April 2022, 21:02:04 UTC build: lock file maintenance (#45457) PR Close #45457 15 April 2022, 21:38:16 UTC
0b64072 dario-piotrowicz 12 April 2022, 20:08:51 UTC fix(docs-infra): fix aio search-results issue with toolbar and notification (#45579) use border-top-width instead of padding-top as the strategy for moving the search-results panel down, this fixes the issue of the panel going behind the toolbar (which causes either overlapping text in the home page or the results scrollbar to be hidden behind the toolbar in other pages) PR Close #45579 15 April 2022, 21:22:14 UTC
9e69579 dario-piotrowicz 11 April 2022, 19:02:08 UTC fix(docs-infra): amend notification close button aria-label (#45579) move the aria-label used inside the close-button to the button itself (since otherwise the button's aria-label overrides the childs) PR Close #45579 15 April 2022, 21:22:14 UTC
d2436bf dario-piotrowicz 09 April 2022, 19:33:44 UTC feat(docs-infra): add close button to search-results aio panel (#45579) add a close button to the search-results aio panel so that the user can conveniently close it via keyboard this complements the focus trap implemented in PR #44989 (more here: https://github.com/angular/angular/pull/44989#issuecomment-1037287678) PR Close #45579 15 April 2022, 21:22:13 UTC
f57e46c ivanwonder 10 April 2022, 14:46:16 UTC fix(language-service): two-way binding completion should not remove the trailing quote (#45582) We allow the path to contain both the `t.BoundAttribute` and `t.BoundEvent` for two-way bindings but do not want the path to contain both the `t.BoundAttribute` with its children when the position is in the value span because we would then logically create a path that also contains the `PropertyWrite` from the `t.BoundEvent`. This early return condition ensures we target just `t.BoundAttribute` for this case and exclude `t.BoundEvent` children. Fixes https://github.com/angular/vscode-ng-language-service/issues/1626 PR Close #45582 15 April 2022, 20:53:48 UTC
c6e0e3f Andrew Kushnir 15 April 2022, 02:10:43 UTC fix(core): improve multiple components match error (#45645) This commit improves the error message that is thrown at runtime when multiple components match the same element. Now the error message contains names of classes that represent those components. PR Close #45645 15 April 2022, 20:52:19 UTC
2e97312 Andrew Kushnir 15 April 2022, 18:20:52 UTC test(core): add a test for multiple named interpolations with the same name (#45651) The test from this commit verifies that i18n logic can handle multiple named interpolations with the same name. PR Close #45651 15 April 2022, 20:51:55 UTC
96fd29c Andrew Scott 04 April 2022, 23:33:25 UTC fix(router): validate lazy loaded configs (#45526) Lazy loaded configs are not validated at runtime like the initial set of routes are. This change also validates lazy loaded configs right after they're loaded. BREAKING CHANGE: Lazy loaded configs are now also validated once loaded like the initial set of routes are. Lazy loaded modules which have invalid Route configs will now error. Note that this is only done in dev mode so there is no production impact of this change. Fixes #25431 PR Close #45526 15 April 2022, 19:30:44 UTC
f13295f Dmitrij Kuba 13 April 2022, 19:59:26 UTC perf(router): cancel the navigation instantly if at least one resolver doesn't emit any value (#45621) Recently the navigation was on hold even at least one resolver didn't emit any value and completed, but another ones still are in progress to resolve any value. The changes cancel the navigation instantly if at least one resolver doesn't emit any value and completed. PR Close #45621 15 April 2022, 17:06:26 UTC
770ea92 Renovate Bot 15 April 2022, 03:34:14 UTC build: update dependency @microsoft/api-extractor to v7.22.2 (#45641) PR Close #45641 15 April 2022, 16:27:39 UTC
back to top