https://github.com/torvalds/linux
Revision ba9b40810bb43e6bf73b395012b98633c03f7f59 authored by Colin Ian King on 07 January 2020, 12:39:01 UTC, committed by Greg Kroah-Hartman on 08 January 2020, 16:34:18 UTC
Currently when an error occurs when calling devm_gpiod_get_optional or
calling gpiod_to_irq it causes an uninitialized error return in variable
'error' to be returned.  Fix this by ensuring the error variable is set
from da8xx_ohci->oc_gpio and oc_irq.

Thanks to Dan Carpenter for spotting the uninitialized error in the
gpiod_to_irq failure case.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200107123901.101190-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 96a0c12
History
Tip revision: ba9b40810bb43e6bf73b395012b98633c03f7f59 authored by Colin Ian King on 07 January 2020, 12:39:01 UTC
usb: ohci-da8xx: ensure error return on variable error is set
Tip revision: ba9b408
File Mode Size
bridge
dp-mst
afbc.rst -rw-r--r-- 7.3 KB
amdgpu-dc.rst -rw-r--r-- 2.0 KB
amdgpu.rst -rw-r--r-- 4.7 KB
drivers.rst -rw-r--r-- 318 bytes
drm-client.rst -rw-r--r-- 295 bytes
drm-internals.rst -rw-r--r-- 7.3 KB
drm-kms-helpers.rst -rw-r--r-- 10.2 KB
drm-kms.rst -rw-r--r-- 15.2 KB
drm-mm.rst -rw-r--r-- 19.6 KB
drm-uapi.rst -rw-r--r-- 13.5 KB
i915.rst -rw-r--r-- 18.9 KB
index.rst -rw-r--r-- 347 bytes
introduction.rst -rw-r--r-- 5.3 KB
kms-properties.csv -rw-r--r-- 7.5 KB
komeda-kms.rst -rw-r--r-- 15.2 KB
mcde.rst -rw-r--r-- 287 bytes
meson.rst -rw-r--r-- 1.7 KB
msm-crash-dump.rst -rw-r--r-- 2.4 KB
pl111.rst -rw-r--r-- 221 bytes
tegra.rst -rw-r--r-- 7.2 KB
todo.rst -rw-r--r-- 20.7 KB
tve200.rst -rw-r--r-- 204 bytes
v3d.rst -rw-r--r-- 759 bytes
vc4.rst -rw-r--r-- 2.1 KB
vga-switcheroo.rst -rw-r--r-- 1.9 KB
vgaarbiter.rst -rw-r--r-- 8.0 KB
vkms.rst -rw-r--r-- 3.7 KB
xen-front.rst -rw-r--r-- 1010 bytes

back to top