https://github.com/torvalds/linux
Revision ba9b40810bb43e6bf73b395012b98633c03f7f59 authored by Colin Ian King on 07 January 2020, 12:39:01 UTC, committed by Greg Kroah-Hartman on 08 January 2020, 16:34:18 UTC
Currently when an error occurs when calling devm_gpiod_get_optional or calling gpiod_to_irq it causes an uninitialized error return in variable 'error' to be returned. Fix this by ensuring the error variable is set from da8xx_ohci->oc_gpio and oc_irq. Thanks to Dan Carpenter for spotting the uninitialized error in the gpiod_to_irq failure case. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios") Signed-off-by: Colin Ian King <colin.king@canonical.com> Cc: stable <stable@vger.kernel.org> Acked-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/20200107123901.101190-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 96a0c12
Tip revision: ba9b40810bb43e6bf73b395012b98633c03f7f59 authored by Colin Ian King on 07 January 2020, 12:39:01 UTC
usb: ohci-da8xx: ensure error return on variable error is set
usb: ohci-da8xx: ensure error return on variable error is set
Tip revision: ba9b408
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...