Skip to main content

Browse the archive

Revision bb2dcd2457bb8826006f7f70f7c03389dea1414c authored by Dhruba Borthakur on 21 September 2012, 17:47:08 UTC, committed by Dhruba Borthakur on 21 September 2012, 17:55:38 UTC 
Segfault in DoCompactionWork caused by buffer overflow
 
Summary:
The code was allocating 200 bytes on the stack but it
writes 256 bytes into the array.

x8a8ea5 std::_Rb_tree<>::erase()
    @     0x7f134bee7eb0 (unknown)
    @           0x8a8ea5 std::_Rb_tree<>::erase()
    @           0x8a35d6 leveldb::DBImpl::CleanupCompaction()
    @           0x8a7810 leveldb::DBImpl::BackgroundCompaction()
    @           0x8a804d leveldb::DBImpl::BackgroundCall()
    @           0x8c4eff leveldb::(anonymous namespace)::PosixEnv::BGThreadWrapper()
    @     0x7f134b3c010d start_thread
    @     0x7f134bf9f10d clone

Test Plan: run db_bench with overwrite option

Reviewers: heyongqiang

Reviewed By: heyongqiang

Differential Revision: https://reviews.facebook.net/D5595
1 parent 9e84834
Raw File
.arcconfig 
{
  "project_id" : "leveldb",
  "conduit_uri" : "https://reviews.facebook.net/",
  "copyright_holder" : ""
}
back to top