https://github.com/torvalds/linux
Revision bb74fc1bf3072bd3ab4ed5f43afd287a63baf2d7 authored by Mario Kleiner on 12 February 2016, 19:30:30 UTC, committed by Dave Airlie on 17 February 2016, 04:19:00 UTC
drm_vblank_offdelay can have three different types of values: < 0 is to be always treated the same as dev->vblank_disable_immediate = 0 is to be treated as "never disable vblanks" > 0 is to be treated as disable immediate if kms driver wants it that way via dev->vblank_disable_immediate. Otherwise it is a disable timeout in msecs. This got broken in Linux 3.18+ for the implementation of drm_vblank_on. If the user specified a value of zero which should always reenable vblank irqs in this function, a kms driver could override the users choice by setting vblank_disable_immediate to true. This patch fixes the regression and keeps the user in control. v2: Only reenable vblank if there are clients left or the user requested to "never disable vblanks" via offdelay 0. Enabling vblanks even in the "delayed disable" case (offdelay > 0) was specifically added by Ville in commit cd19e52aee922 ("drm: Kick start vblank interrupts at drm_vblank_on()"), but after discussion it turns out that this was done by accident. Citing Ville: "I think it just ended up as a mess due to changing some of the semantics of offdelay<0 vs. offdelay==0 vs. disable_immediate during the review of the series. So yeah, given how drm_vblank_put() works now, I'd just make this check for offdelay==0." Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: <stable@vger.kernel.org> # 3.18+ Cc: michel@daenzer.net Cc: vbabka@suse.cz Cc: ville.syrjala@linux.intel.com Cc: daniel.vetter@ffwll.ch Cc: dri-devel@lists.freedesktop.org Cc: alexander.deucher@amd.com Cc: christian.koenig@amd.com Signed-off-by: Dave Airlie <airlied@redhat.com>
1 parent c61934e
Tip revision: bb74fc1bf3072bd3ab4ed5f43afd287a63baf2d7 authored by Mario Kleiner on 12 February 2016, 19:30:30 UTC
drm: Fix treatment of drm_vblank_offdelay in drm_vblank_on() (v2)
drm: Fix treatment of drm_vblank_offdelay in drm_vblank_on() (v2)
Tip revision: bb74fc1
File | Mode | Size |
---|---|---|
6lowpan_i.h | -rw-r--r-- | 623 bytes |
Kconfig | -rw-r--r-- | 2.7 KB |
Makefile | -rw-r--r-- | 823 bytes |
core.c | -rw-r--r-- | 2.2 KB |
debugfs.c | -rw-r--r-- | 1.3 KB |
iphc.c | -rw-r--r-- | 25.4 KB |
nhc.c | -rw-r--r-- | 5.3 KB |
nhc.h | -rw-r--r-- | 4.3 KB |
nhc_dest.c | -rw-r--r-- | 860 bytes |
nhc_fragment.c | -rw-r--r-- | 868 bytes |
nhc_ghc_ext_dest.c | -rw-r--r-- | 880 bytes |
nhc_ghc_ext_frag.c | -rw-r--r-- | 892 bytes |
nhc_ghc_ext_hop.c | -rw-r--r-- | 868 bytes |
nhc_ghc_ext_route.c | -rw-r--r-- | 885 bytes |
nhc_ghc_icmpv6.c | -rw-r--r-- | 823 bytes |
nhc_ghc_udp.c | -rw-r--r-- | 781 bytes |
nhc_hop.c | -rw-r--r-- | 843 bytes |
nhc_ipv6.c | -rw-r--r-- | 807 bytes |
nhc_mobility.c | -rw-r--r-- | 868 bytes |
nhc_routing.c | -rw-r--r-- | 855 bytes |
nhc_udp.c | -rw-r--r-- | 5.7 KB |
Computing file changes ...