Revision bbfbf04c2d4ef673f657175456f6693c9225748a authored by Masahiro Yamada on 14 June 2018, 05:27:45 UTC, committed by Linus Walleij on 23 July 2018, 21:13:31 UTC
If a GPIO chip is a part of a hierarchy IRQ domain, there is no
way to specify the trigger type when gpio(d)_to_irq() allocates an
interrupt on-the-fly.

Currently, uniphier_gpio_to_irq() sets IRQ_TYPE_NONE, but it causes
an error in the .alloc() hook of the parent domain.
(drivers/irq/irq-uniphier-aidet.c)

Even if we change irq-uniphier-aidet.c to accept the NONE type,
GIC complains about it since commit 83a86fbb5b56 ("irqchip/gic:
Loudly complain about the use of IRQ_TYPE_NONE").

Instead, use IRQ_TYPE_LEVEL_HIGH as a temporary value when an irq
is allocated.  irq_set_irq_type() will override it when the irq is
really requested.

Fixes: dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")
Reported-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 906402a
History
File Mode Size
Kconfig -rw-r--r-- 892 bytes
Makefile -rw-r--r-- 458 bytes
aaci.c -rw-r--r-- 24.8 KB
aaci.h -rw-r--r-- 6.9 KB
pxa2xx-ac97-lib.c -rw-r--r-- 8.7 KB
pxa2xx-ac97.c -rw-r--r-- 6.8 KB
pxa2xx-pcm-lib.c -rw-r--r-- 4.9 KB
pxa2xx-pcm.c -rw-r--r-- 2.9 KB
pxa2xx-pcm.h -rw-r--r-- 828 bytes

back to top