Revision bbfbf04c2d4ef673f657175456f6693c9225748a authored by Masahiro Yamada on 14 June 2018, 05:27:45 UTC, committed by Linus Walleij on 23 July 2018, 21:13:31 UTC
If a GPIO chip is a part of a hierarchy IRQ domain, there is no
way to specify the trigger type when gpio(d)_to_irq() allocates an
interrupt on-the-fly.

Currently, uniphier_gpio_to_irq() sets IRQ_TYPE_NONE, but it causes
an error in the .alloc() hook of the parent domain.
(drivers/irq/irq-uniphier-aidet.c)

Even if we change irq-uniphier-aidet.c to accept the NONE type,
GIC complains about it since commit 83a86fbb5b56 ("irqchip/gic:
Loudly complain about the use of IRQ_TYPE_NONE").

Instead, use IRQ_TYPE_LEVEL_HIGH as a temporary value when an irq
is allocated.  irq_set_irq_type() will override it when the irq is
really requested.

Fixes: dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")
Reported-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 906402a
History
File Mode Size
ac97
ali5451
asihpi
au88x0
aw2
ca0106
cs46xx
cs5535audio
ctxfi
echoaudio
emu10k1
hda
ice1712
korg1212
lola
lx6464es
mixart
nm256
oxygen
pcxhr
riptide
rme9652
trident
vx222
ymfpci
Kconfig -rw-r--r-- 25.3 KB
Makefile -rw-r--r-- 2.2 KB
ad1889.c -rw-r--r-- 26.0 KB
ad1889.h -rw-r--r-- 7.9 KB
ak4531_codec.c -rw-r--r-- 17.0 KB
als300.c -rw-r--r-- 21.9 KB
als4000.c -rw-r--r-- 30.9 KB
atiixp.c -rw-r--r-- 45.1 KB
atiixp_modem.c -rw-r--r-- 35.2 KB
azt3328.c -rw-r--r-- 82.3 KB
azt3328.h -rw-r--r-- 15.5 KB
bt87x.c -rw-r--r-- 29.6 KB
cmipci.c -rw-r--r-- 101.4 KB
cs4281.c -rw-r--r-- 63.8 KB
cs5530.c -rw-r--r-- 7.0 KB
ens1370.c -rw-r--r-- 78.4 KB
ens1371.c -rw-r--r-- 38 bytes
es1938.c -rw-r--r-- 55.2 KB
es1968.c -rw-r--r-- 78.7 KB
fm801.c -rw-r--r-- 41.5 KB
intel8x0.c -rw-r--r-- 91.9 KB
intel8x0m.c -rw-r--r-- 37.1 KB
maestro3.c -rw-r--r-- 81.7 KB
rme32.c -rw-r--r-- 57.6 KB
rme96.c -rw-r--r-- 71.0 KB
sis7019.c -rw-r--r-- 39.7 KB
sis7019.h -rw-r--r-- 13.3 KB
sonicvibes.c -rw-r--r-- 51.0 KB
via82xx.c -rw-r--r-- 77.0 KB
via82xx_modem.c -rw-r--r-- 34.1 KB

back to top