Revision bc4ef7592f657ae81b017207a1098817126ad4cb authored by David Sterba on 13 November 2015, 12:44:28 UTC, committed by Chris Mason on 11 February 2016, 15:01:59 UTC
The value of ctx->pos in the last readdir call is supposed to be set to INT_MAX due to 32bit compatibility, unless 'pos' is intentially set to a larger value, then it's LLONG_MAX. There's a report from PaX SIZE_OVERFLOW plugin that "ctx->pos++" overflows (https://forums.grsecurity.net/viewtopic.php?f=1&t=4284), on a 64bit arch, where the value is 0x7fffffffffffffff ie. LLONG_MAX before the increment. We can get to that situation like that: * emit all regular readdir entries * still in the same call to readdir, bump the last pos to INT_MAX * next call to readdir will not emit any entries, but will reach the bump code again, finds pos to be INT_MAX and sets it to LLONG_MAX Normally this is not a problem, but if we call readdir again, we'll find 'pos' set to LLONG_MAX and the unconditional increment will overflow. The report from Victor at (http://thread.gmane.org/gmane.comp.file-systems.btrfs/49500) with debugging print shows that pattern: Overflow: e Overflow: 7fffffff Overflow: 7fffffffffffffff PAX: size overflow detected in function btrfs_real_readdir fs/btrfs/inode.c:5760 cicus.935_282 max, count: 9, decl: pos; num: 0; context: dir_context; CPU: 0 PID: 2630 Comm: polkitd Not tainted 4.2.3-grsec #1 Hardware name: Gigabyte Technology Co., Ltd. H81ND2H/H81ND2H, BIOS F3 08/11/2015 ffffffff81901608 0000000000000000 ffffffff819015e6 ffffc90004973d48 ffffffff81742f0f 0000000000000007 ffffffff81901608 ffffc90004973d78 ffffffff811cb706 0000000000000000 ffff8800d47359e0 ffffc90004973ed8 Call Trace: [<ffffffff81742f0f>] dump_stack+0x4c/0x7f [<ffffffff811cb706>] report_size_overflow+0x36/0x40 [<ffffffff812ef0bc>] btrfs_real_readdir+0x69c/0x6d0 [<ffffffff811dafc8>] iterate_dir+0xa8/0x150 [<ffffffff811e6d8d>] ? __fget_light+0x2d/0x70 [<ffffffff811dba3a>] SyS_getdents+0xba/0x1c0 Overflow: 1a [<ffffffff811db070>] ? iterate_dir+0x150/0x150 [<ffffffff81749b69>] entry_SYSCALL_64_fastpath+0x12/0x83 The jump from 7fffffff to 7fffffffffffffff happens when new dir entries are not yet synced and are processed from the delayed list. Then the code could go to the bump section again even though it might not emit any new dir entries from the delayed list. The fix avoids entering the "bump" section again once we've finished emitting the entries, both for synced and delayed entries. References: https://forums.grsecurity.net/viewtopic.php?f=1&t=4284 Reported-by: Victor <services@swwu.com> CC: stable@vger.kernel.org Signed-off-by: David Sterba <dsterba@suse.com> Tested-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com> Signed-off-by: Chris Mason <clm@fb.com>
1 parent 43d871f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.5 KB |
Makefile | -rw-r--r-- | 374 bytes |
caif_dev.c | -rw-r--r-- | 12.8 KB |
caif_socket.c | -rw-r--r-- | 26.4 KB |
caif_usb.c | -rw-r--r-- | 5.3 KB |
cfcnfg.c | -rw-r--r-- | 14.3 KB |
cfctrl.c | -rw-r--r-- | 15.8 KB |
cfdbgl.c | -rw-r--r-- | 1.5 KB |
cfdgml.c | -rw-r--r-- | 2.9 KB |
cffrml.c | -rw-r--r-- | 4.5 KB |
cfmuxl.c | -rw-r--r-- | 6.3 KB |
cfpkt_skbuff.c | -rw-r--r-- | 8.4 KB |
cfrfml.c | -rw-r--r-- | 6.4 KB |
cfserl.c | -rw-r--r-- | 4.3 KB |
cfsrvl.c | -rw-r--r-- | 5.5 KB |
cfutill.c | -rw-r--r-- | 2.8 KB |
cfveil.c | -rw-r--r-- | 2.5 KB |
cfvidl.c | -rw-r--r-- | 1.7 KB |
chnl_net.c | -rw-r--r-- | 13.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...