Revision bca5c2c550f16d2dc2d21ffb7b4712bd0a7d32a9 authored by Andres Salomon on 12 July 2008, 20:47:54 UTC, committed by Linus Torvalds on 12 July 2008, 21:33:41 UTC
Cortland Setlow pointed out a bug in ov7670.c where the result from ov7670_read() was just being checked for !0, rather than <0. This made me realize that ov7670_read's semantics were rather confusing; it both fills in 'value' with the result, and returns it. This is goes against general kernel convention; so rather than fixing callers, let's fix the function. This makes ov7670_read return <0 in the case of an error, and 0 upon success. Thus, code like: res = ov7670_read(...); if (!res) goto error; ..will work properly. Signed-off-by: Cortland Setlow <csetlow@tower-research.com> Signed-off-by: Andres Salomon <dilinger@debian.org> Acked-by: Jonathan Corbet <corbet@lwn.net> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 05d81d2
| File | Mode | Size |
|---|---|---|
| AUTHORS | -rw-r--r-- | 2.4 KB |
| CHANGES | -rw-r--r-- | 39.8 KB |
| Makefile | -rw-r--r-- | 443 bytes |
| README | -rw-r--r-- | 32.5 KB |
| TODO | -rw-r--r-- | 5.2 KB |
| asn1.c | -rw-r--r-- | 14.2 KB |
| cifs_debug.c | -rw-r--r-- | 21.9 KB |
| cifs_debug.h | -rw-r--r-- | 2.3 KB |
| cifs_dfs_ref.c | -rw-r--r-- | 8.6 KB |
| cifs_fs_sb.h | -rw-r--r-- | 2.2 KB |
| cifs_spnego.c | -rw-r--r-- | 4.0 KB |
| cifs_spnego.h | -rw-r--r-- | 1.6 KB |
| cifs_unicode.c | -rw-r--r-- | 2.2 KB |
| cifs_unicode.h | -rw-r--r-- | 7.9 KB |
| cifs_uniupr.h | -rw-r--r-- | 12.6 KB |
| cifsacl.c | -rw-r--r-- | 20.4 KB |
| cifsacl.h | -rw-r--r-- | 2.3 KB |
| cifsencrypt.c | -rw-r--r-- | 12.5 KB |
| cifsencrypt.h | -rw-r--r-- | 1.2 KB |
| cifsfs.c | -rw-r--r-- | 30.2 KB |
| cifsfs.h | -rw-r--r-- | 4.8 KB |
| cifsglob.h | -rw-r--r-- | 21.4 KB |
| cifspdu.h | -rw-r--r-- | 80.4 KB |
| cifsproto.h | -rw-r--r-- | 15.8 KB |
| cifssmb.c | -rw-r--r-- | 167.7 KB |
| cn_cifs.h | -rw-r--r-- | 1.3 KB |
| connect.c | -rw-r--r-- | 108.6 KB |
| dir.c | -rw-r--r-- | 16.8 KB |
| dns_resolve.c | -rw-r--r-- | 3.7 KB |
| dns_resolve.h | -rw-r--r-- | 1.3 KB |
| export.c | -rw-r--r-- | 2.3 KB |
| fcntl.c | -rw-r--r-- | 3.6 KB |
| file.c | -rw-r--r-- | 56.9 KB |
| inode.c | -rw-r--r-- | 49.5 KB |
| ioctl.c | -rw-r--r-- | 2.9 KB |
| link.c | -rw-r--r-- | 8.6 KB |
| md4.c | -rw-r--r-- | 4.5 KB |
| md5.c | -rw-r--r-- | 10.6 KB |
| md5.h | -rw-r--r-- | 1.1 KB |
| misc.c | -rw-r--r-- | 23.1 KB |
| netmisc.c | -rw-r--r-- | 37.6 KB |
| nterr.c | -rw-r--r-- | 33.5 KB |
| nterr.h | -rw-r--r-- | 29.7 KB |
| ntlmssp.h | -rw-r--r-- | 4.0 KB |
| readdir.c | -rw-r--r-- | 34.0 KB |
| rfc1002pdu.h | -rw-r--r-- | 2.8 KB |
| sess.c | -rw-r--r-- | 17.7 KB |
| smbdes.c | -rw-r--r-- | 10.1 KB |
| smbencrypt.c | -rw-r--r-- | 7.4 KB |
| smberr.h | -rw-r--r-- | 7.4 KB |
| transport.c | -rw-r--r-- | 28.4 KB |
| xattr.c | -rw-r--r-- | 10.5 KB |
Computing file changes ...
