Revision bca5c2c550f16d2dc2d21ffb7b4712bd0a7d32a9 authored by Andres Salomon on 12 July 2008, 20:47:54 UTC, committed by Linus Torvalds on 12 July 2008, 21:33:41 UTC
Cortland Setlow pointed out a bug in ov7670.c where the result from ov7670_read() was just being checked for !0, rather than <0. This made me realize that ov7670_read's semantics were rather confusing; it both fills in 'value' with the result, and returns it. This is goes against general kernel convention; so rather than fixing callers, let's fix the function. This makes ov7670_read return <0 in the case of an error, and 0 upon success. Thus, code like: res = ov7670_read(...); if (!res) goto error; ..will work properly. Signed-off-by: Cortland Setlow <csetlow@tower-research.com> Signed-off-by: Andres Salomon <dilinger@debian.org> Acked-by: Jonathan Corbet <corbet@lwn.net> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 05d81d2
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 324 bytes |
| cache.c | -rw-r--r-- | 2.9 KB |
| cnode.c | -rw-r--r-- | 4.1 KB |
| coda_int.h | -rw-r--r-- | 434 bytes |
| coda_linux.c | -rw-r--r-- | 5.1 KB |
| dir.c | -rw-r--r-- | 16.8 KB |
| file.c | -rw-r--r-- | 6.2 KB |
| inode.c | -rw-r--r-- | 6.5 KB |
| pioctl.c | -rw-r--r-- | 2.4 KB |
| psdev.c | -rw-r--r-- | 10.2 KB |
| symlink.c | -rw-r--r-- | 1.2 KB |
| sysctl.c | -rw-r--r-- | 1.3 KB |
| upcall.c | -rw-r--r-- | 22.7 KB |
Computing file changes ...
