Revision bca5c2c550f16d2dc2d21ffb7b4712bd0a7d32a9 authored by Andres Salomon on 12 July 2008, 20:47:54 UTC, committed by Linus Torvalds on 12 July 2008, 21:33:41 UTC
Cortland Setlow pointed out a bug in ov7670.c where the result from ov7670_read() was just being checked for !0, rather than <0. This made me realize that ov7670_read's semantics were rather confusing; it both fills in 'value' with the result, and returns it. This is goes against general kernel convention; so rather than fixing callers, let's fix the function. This makes ov7670_read return <0 in the case of an error, and 0 upon success. Thus, code like: res = ov7670_read(...); if (!res) goto error; ..will work properly. Signed-off-by: Cortland Setlow <csetlow@tower-research.com> Signed-off-by: Andres Salomon <dilinger@debian.org> Acked-by: Jonathan Corbet <corbet@lwn.net> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 05d81d2
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 161 bytes |
README | -rw-r--r-- | 279 bytes |
bitmap.c | -rw-r--r-- | 3.6 KB |
dir.c | -rw-r--r-- | 2.5 KB |
file.c | -rw-r--r-- | 922 bytes |
fsync.c | -rw-r--r-- | 3.0 KB |
inode.c | -rw-r--r-- | 15.2 KB |
namei.c | -rw-r--r-- | 5.7 KB |
truncate.c | -rw-r--r-- | 727 bytes |
Computing file changes ...