Revision bcb9e41080deaae9be60c0d483fe015db9b6d9c4 authored by Cheng Chang on 01 June 2020, 22:17:58 UTC, committed by Facebook GitHub Bot on 01 June 2020, 22:19:40 UTC
Summary: Currently we rely on `BlockContents` to implicitly free the allocated scratch buffer, but when IO error happens, it doesn't make sense to construct the `BlockContents` which might be corrupted. In the stress test, we find that `assert(req.result.size() == block_size(handle));` fails because of potential IO errors. In this PR, we explicitly free the scratch buffer on error without constructing `BlockContents`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6903 Test Plan: watch stress test Reviewed By: anand1976 Differential Revision: D21823869 Pulled By: cheng-chang fbshipit-source-id: 5603fc80e9bf3f44a9d7250ddebd871afe1eb89f
1 parent 038e02d
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .github | ||
| buckifier | ||
| build_tools | ||
| cache | ||
| cmake | ||
| coverage | ||
| db | ||
| db_stress_tool | ||
| docs | ||
| env | ||
| examples | ||
| file | ||
| hdfs | ||
| include | ||
| java | ||
| logging | ||
| memory | ||
| memtable | ||
| monitoring | ||
| options | ||
| port | ||
| table | ||
| test_util | ||
| third-party | ||
| tools | ||
| trace_replay | ||
| util | ||
| utilities | ||
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 966 bytes |
| .lgtm.yml | -rw-r--r-- | 67 bytes |
| .travis.yml | -rw-r--r-- | 8.2 KB |
| .watchmanconfig | -rw-r--r-- | 130 bytes |
| AUTHORS | -rw-r--r-- | 322 bytes |
| CMakeLists.txt | -rw-r--r-- | 42.5 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.3 KB |
| CONTRIBUTING.md | -rw-r--r-- | 706 bytes |
| COPYING | -rw-r--r-- | 17.7 KB |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.5 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 117.9 KB |
| INSTALL.md | -rw-r--r-- | 7.5 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 1.1 KB |
| LICENSE.Apache | -rw-r--r-- | 11.1 KB |
| LICENSE.leveldb | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 79.0 KB |
| README.md | -rw-r--r-- | 1.9 KB |
| ROCKSDB_LITE.md | -rw-r--r-- | 1.0 KB |
| TARGETS | -rw-r--r-- | 38.3 KB |
| USERS.md | -rw-r--r-- | 7.0 KB |
| Vagrantfile | -rw-r--r-- | 1017 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| appveyor.yml | -rw-r--r-- | 3.8 KB |
| defs.bzl | -rw-r--r-- | 1.9 KB |
| issue_template.md | -rw-r--r-- | 294 bytes |
| src.mk | -rw-r--r-- | 35.6 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
