https://github.com/torvalds/linux
Revision bdca0f9b1eabb24373e2307fe492f428f5928abc authored by Michal Januszewski on 06 May 2009, 23:02:56 UTC, committed by Linus Torvalds on 06 May 2009, 23:36:10 UTC
The software fillrect routines do not work properly when the number of pixels per machine word is not an integer. To see that, run the following command on a fbdev console with a 24bpp video mode, using a non-accelerated driver such as (u)vesafb: reset ; echo -e '\e[41mtest\e[K' The expected result is 'test' displayed on a line with red background. Instead of that, 'test' has a red background, but the rest of the line (rendered using fillrect()) contains a distored colorful pattern. This patch fixes the problem by correctly computing rotation shifts. It has been tested in a 24bpp mode on 32- and 64-bit little-endian machines. Signed-off-by: Michal Januszewski <spock@gentoo.org> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 184101b
Tip revision: bdca0f9b1eabb24373e2307fe492f428f5928abc authored by Michal Januszewski on 06 May 2009, 23:02:56 UTC
fbdev: fix fillrect for 24bpp modes
fbdev: fix fillrect for 24bpp modes
Tip revision: bdca0f9
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.4 KB |
| Kconfig.iosched | -rw-r--r-- | 1.9 KB |
| Makefile | -rw-r--r-- | 582 bytes |
| as-iosched.c | -rw-r--r-- | 38.8 KB |
| blk-barrier.c | -rw-r--r-- | 9.7 KB |
| blk-core.c | -rw-r--r-- | 58.1 KB |
| blk-exec.c | -rw-r--r-- | 2.7 KB |
| blk-integrity.c | -rw-r--r-- | 9.9 KB |
| blk-ioc.c | -rw-r--r-- | 4.0 KB |
| blk-map.c | -rw-r--r-- | 8.0 KB |
| blk-merge.c | -rw-r--r-- | 10.2 KB |
| blk-settings.c | -rw-r--r-- | 14.7 KB |
| blk-softirq.c | -rw-r--r-- | 4.1 KB |
| blk-sysfs.c | -rw-r--r-- | 10.5 KB |
| blk-tag.c | -rw-r--r-- | 9.8 KB |
| blk-timeout.c | -rw-r--r-- | 5.8 KB |
| blk.h | -rw-r--r-- | 3.3 KB |
| bsg.c | -rw-r--r-- | 23.3 KB |
| cfq-iosched.c | -rw-r--r-- | 63.6 KB |
| cmd-filter.c | -rw-r--r-- | 5.4 KB |
| compat_ioctl.c | -rw-r--r-- | 21.6 KB |
| deadline-iosched.c | -rw-r--r-- | 11.4 KB |
| elevator.c | -rw-r--r-- | 27.1 KB |
| genhd.c | -rw-r--r-- | 28.6 KB |
| ioctl.c | -rw-r--r-- | 8.6 KB |
| noop-iosched.c | -rw-r--r-- | 2.6 KB |
| scsi_ioctl.c | -rw-r--r-- | 17.2 KB |
Computing file changes ...
