https://github.com/torvalds/linux
Revision bdca0f9b1eabb24373e2307fe492f428f5928abc authored by Michal Januszewski on 06 May 2009, 23:02:56 UTC, committed by Linus Torvalds on 06 May 2009, 23:36:10 UTC
The software fillrect routines do not work properly when the number of
pixels per machine word is not an integer.  To see that, run the following
command on a fbdev console with a 24bpp video mode, using a
non-accelerated driver such as (u)vesafb:

  reset ; echo -e '\e[41mtest\e[K'

The expected result is 'test' displayed on a line with red background.
Instead of that, 'test' has a red background, but the rest of the line
(rendered using fillrect()) contains a distored colorful pattern.

This patch fixes the problem by correctly computing rotation shifts.  It
has been tested in a 24bpp mode on 32- and 64-bit little-endian machines.

Signed-off-by: Michal Januszewski <spock@gentoo.org>
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 184101b
History
Tip revision: bdca0f9b1eabb24373e2307fe492f428f5928abc authored by Michal Januszewski on 06 May 2009, 23:02:56 UTC
fbdev: fix fillrect for 24bpp modes
Tip revision: bdca0f9
File Mode Size
firmware_class
kobject
kprobes
markers
tracepoints
Kconfig -rw-r--r-- 1.0 KB
Makefile -rw-r--r-- 100 bytes

back to top