Revision be14eb619108fa8b7120eb2c42d66d5f623ae10e authored by Brian King on 10 September 2010, 07:03:21 UTC, committed by Jens Axboe on 10 September 2010, 07:03:21 UTC
While testing CPU DLPAR, the following problem was discovered. We were DLPAR removing the first CPU, which in this case was logical CPUs 0-3. CPUs 0-2 were already marked offline and we were in the process of offlining CPU 3. After marking the CPU inactive and offline in cpu_disable, but before the cpu was completely idle (cpu_die), we ended up in __make_request on CPU 3. There we looked at the topology map to see which CPU to complete the I/O on and found no CPUs in the cpu_sibling_map. This resulted in the block layer setting the completion cpu to be NR_CPUS, which then caused an oops when we tried to complete the I/O. Fix this by sanity checking the value we return from blk_cpu_to_group to be a valid cpu value. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
1 parent edce682
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 323 bytes |
| acl.c | -rw-r--r-- | 7.0 KB |
| acl.h | -rw-r--r-- | 831 bytes |
| aops.c | -rw-r--r-- | 29.9 KB |
| bmap.c | -rw-r--r-- | 31.2 KB |
| bmap.h | -rw-r--r-- | 1.7 KB |
| dentry.c | -rw-r--r-- | 2.7 KB |
| dir.c | -rw-r--r-- | 46.9 KB |
| dir.h | -rw-r--r-- | 2.1 KB |
| export.c | -rw-r--r-- | 5.8 KB |
| file.c | -rw-r--r-- | 19.3 KB |
| gfs2.h | -rw-r--r-- | 524 bytes |
| glock.c | -rw-r--r-- | 46.9 KB |
| glock.h | -rw-r--r-- | 7.3 KB |
| glops.c | -rw-r--r-- | 11.3 KB |
| glops.h | -rw-r--r-- | 1.0 KB |
| incore.h | -rw-r--r-- | 16.2 KB |
| inode.c | -rw-r--r-- | 26.6 KB |
| inode.h | -rw-r--r-- | 4.2 KB |
| lock_dlm.c | -rw-r--r-- | 5.4 KB |
| log.c | -rw-r--r-- | 24.0 KB |
| log.h | -rw-r--r-- | 1.8 KB |
| lops.c | -rw-r--r-- | 18.9 KB |
| lops.h | -rw-r--r-- | 2.9 KB |
| main.c | -rw-r--r-- | 4.9 KB |
| meta_io.c | -rw-r--r-- | 10.1 KB |
| meta_io.h | -rw-r--r-- | 2.5 KB |
| ops_fstype.c | -rw-r--r-- | 36.0 KB |
| ops_inode.c | -rw-r--r-- | 30.6 KB |
| quota.c | -rw-r--r-- | 37.6 KB |
| quota.h | -rw-r--r-- | 1.8 KB |
| recovery.c | -rw-r--r-- | 14.0 KB |
| recovery.h | -rw-r--r-- | 1.2 KB |
| rgrp.c | -rw-r--r-- | 46.2 KB |
| rgrp.h | -rw-r--r-- | 2.5 KB |
| super.c | -rw-r--r-- | 32.9 KB |
| super.h | -rw-r--r-- | 2.0 KB |
| sys.c | -rw-r--r-- | 15.7 KB |
| sys.h | -rw-r--r-- | 600 bytes |
| trace_gfs2.h | -rw-r--r-- | 10.6 KB |
| trans.c | -rw-r--r-- | 4.6 KB |
| trans.h | -rw-r--r-- | 1.1 KB |
| util.c | -rw-r--r-- | 8.0 KB |
| util.h | -rw-r--r-- | 5.0 KB |
| xattr.c | -rw-r--r-- | 33.6 KB |
| xattr.h | -rw-r--r-- | 2.1 KB |
Computing file changes ...
