Revision be14eb619108fa8b7120eb2c42d66d5f623ae10e authored by Brian King on 10 September 2010, 07:03:21 UTC, committed by Jens Axboe on 10 September 2010, 07:03:21 UTC
While testing CPU DLPAR, the following problem was discovered. We were DLPAR removing the first CPU, which in this case was logical CPUs 0-3. CPUs 0-2 were already marked offline and we were in the process of offlining CPU 3. After marking the CPU inactive and offline in cpu_disable, but before the cpu was completely idle (cpu_die), we ended up in __make_request on CPU 3. There we looked at the topology map to see which CPU to complete the I/O on and found no CPUs in the cpu_sibling_map. This resulted in the block layer setting the completion cpu to be NR_CPUS, which then caused an oops when we tried to complete the I/O. Fix this by sanity checking the value we return from blk_cpu_to_group to be a valid cpu value. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
1 parent edce682
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 5.7 KB |
| LICENCE | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 751 bytes |
| README.Locking | -rw-r--r-- | 7.0 KB |
| TODO | -rw-r--r-- | 1.9 KB |
| acl.c | -rw-r--r-- | 9.5 KB |
| acl.h | -rw-r--r-- | 1022 bytes |
| background.c | -rw-r--r-- | 4.4 KB |
| build.c | -rw-r--r-- | 10.9 KB |
| compr.c | -rw-r--r-- | 10.2 KB |
| compr.h | -rw-r--r-- | 3.0 KB |
| compr_lzo.c | -rw-r--r-- | 2.3 KB |
| compr_rtime.c | -rw-r--r-- | 2.9 KB |
| compr_rubin.c | -rw-r--r-- | 8.8 KB |
| compr_zlib.c | -rw-r--r-- | 5.8 KB |
| debug.c | -rw-r--r-- | 25.6 KB |
| debug.h | -rw-r--r-- | 8.4 KB |
| dir.c | -rw-r--r-- | 23.0 KB |
| erase.c | -rw-r--r-- | 14.5 KB |
| file.c | -rw-r--r-- | 9.2 KB |
| fs.c | -rw-r--r-- | 19.3 KB |
| gc.c | -rw-r--r-- | 43.9 KB |
| ioctl.c | -rw-r--r-- | 557 bytes |
| jffs2_fs_i.h | -rw-r--r-- | 1.6 KB |
| jffs2_fs_sb.h | -rw-r--r-- | 5.1 KB |
| malloc.c | -rw-r--r-- | 7.4 KB |
| nodelist.c | -rw-r--r-- | 21.7 KB |
| nodelist.h | -rw-r--r-- | 17.7 KB |
| nodemgmt.c | -rw-r--r-- | 27.7 KB |
| os-linux.h | -rw-r--r-- | 7.5 KB |
| read.c | -rw-r--r-- | 6.9 KB |
| readinode.c | -rw-r--r-- | 43.3 KB |
| scan.c | -rw-r--r-- | 35.5 KB |
| security.c | -rw-r--r-- | 2.1 KB |
| summary.c | -rw-r--r-- | 23.5 KB |
| summary.h | -rw-r--r-- | 6.3 KB |
| super.c | -rw-r--r-- | 7.7 KB |
| symlink.c | -rw-r--r-- | 1.8 KB |
| wbuf.c | -rw-r--r-- | 36.5 KB |
| write.c | -rw-r--r-- | 21.3 KB |
| writev.c | -rw-r--r-- | 1.8 KB |
| xattr.c | -rw-r--r-- | 37.7 KB |
| xattr.h | -rw-r--r-- | 4.1 KB |
| xattr_trusted.c | -rw-r--r-- | 1.4 KB |
| xattr_user.c | -rw-r--r-- | 1.4 KB |
Computing file changes ...
