Revision be14eb619108fa8b7120eb2c42d66d5f623ae10e authored by Brian King on 10 September 2010, 07:03:21 UTC, committed by Jens Axboe on 10 September 2010, 07:03:21 UTC
While testing CPU DLPAR, the following problem was discovered.
We were DLPAR removing the first CPU, which in this case was
logical CPUs 0-3. CPUs 0-2 were already marked offline and
we were in the process of offlining CPU 3. After marking
the CPU inactive and offline in cpu_disable, but before the
cpu was completely idle (cpu_die), we ended up in __make_request
on CPU 3. There we looked at the topology map to see which CPU
to complete the I/O on and found no CPUs in the cpu_sibling_map.
This resulted in the block layer setting the completion cpu
to be NR_CPUS, which then caused an oops when we tried to
complete the I/O.

Fix this by sanity checking the value we return from blk_cpu_to_group
to be a valid cpu value.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
1 parent edce682
History
File Mode Size
Kconfig -rw-r--r-- 717 bytes
Makefile -rw-r--r-- 607 bytes
af_rds.c -rw-r--r-- 14.0 KB
bind.c -rw-r--r-- 5.1 KB
cong.c -rw-r--r-- 12.0 KB
connection.c -rw-r--r-- 13.6 KB
ib.c -rw-r--r-- 8.8 KB
ib.h -rw-r--r-- 11.6 KB
ib_cm.c -rw-r--r-- 21.3 KB
ib_rdma.c -rw-r--r-- 16.2 KB
ib_recv.c -rw-r--r-- 27.4 KB
ib_ring.c -rw-r--r-- 4.8 KB
ib_send.c -rw-r--r-- 26.1 KB
ib_stats.c -rw-r--r-- 2.8 KB
ib_sysctl.c -rw-r--r-- 4.6 KB
info.c -rw-r--r-- 6.5 KB
info.h -rw-r--r-- 934 bytes
iw.c -rw-r--r-- 8.8 KB
iw.h -rw-r--r-- 12.3 KB
iw_cm.c -rw-r--r-- 20.8 KB
iw_rdma.c -rw-r--r-- 24.2 KB
iw_recv.c -rw-r--r-- 26.0 KB
iw_ring.c -rw-r--r-- 4.8 KB
iw_send.c -rw-r--r-- 29.1 KB
iw_stats.c -rw-r--r-- 2.8 KB
iw_sysctl.c -rw-r--r-- 4.2 KB
loop.c -rw-r--r-- 5.4 KB
loop.h -rw-r--r-- 137 bytes
message.c -rw-r--r-- 10.1 KB
page.c -rw-r--r-- 5.9 KB
rdma.c -rw-r--r-- 18.0 KB
rdma.h -rw-r--r-- 2.2 KB
rdma_transport.c -rw-r--r-- 5.5 KB
rdma_transport.h -rw-r--r-- 629 bytes
rds.h -rw-r--r-- 22.2 KB
recv.c -rw-r--r-- 15.3 KB
send.c -rw-r--r-- 27.7 KB
stats.c -rw-r--r-- 4.3 KB
sysctl.c -rw-r--r-- 3.6 KB
tcp.c -rw-r--r-- 8.7 KB
tcp.h -rw-r--r-- 2.8 KB
tcp_connect.c -rw-r--r-- 4.2 KB
tcp_listen.c -rw-r--r-- 5.1 KB
tcp_recv.c -rw-r--r-- 9.4 KB
tcp_send.c -rw-r--r-- 7.5 KB
tcp_stats.c -rw-r--r-- 2.3 KB
threads.c -rw-r--r-- 8.6 KB
transport.c -rw-r--r-- 3.4 KB

back to top