Revision be7fcf1d1701a5266dd36eab4978476f63d1bd57 authored by Dan Carpenter on 14 May 2019, 10:34:51 UTC, committed by Paolo Bonzini on 24 May 2019, 19:27:04 UTC
The code is trying to check that all the padding is zeroed out and it
does this:
entry->padding[0] == entry->padding[1] == entry->padding[2] == 0
Assume everything is zeroed correctly, then the first comparison is
true, the next comparison is false and false is equal to zero so the
overall condition is true. This bug doesn't affect run time very
badly, but the code should instead just check that all three paddings
are zero individually.
Also the error message was copy and pasted from an earlier error and it
wasn't correct.
Fixes: 7edcb7343327 ("KVM: selftests: Add hyperv_cpuid test")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent 2eb06c3
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 361 bytes |
| compat.c | -rw-r--r-- | 2.2 KB |
| ipc_sysctl.c | -rw-r--r-- | 6.2 KB |
| mq_sysctl.c | -rw-r--r-- | 2.9 KB |
| mqueue.c | -rw-r--r-- | 40.3 KB |
| msg.c | -rw-r--r-- | 30.5 KB |
| msgutil.c | -rw-r--r-- | 3.7 KB |
| namespace.c | -rw-r--r-- | 4.6 KB |
| sem.c | -rw-r--r-- | 62.1 KB |
| shm.c | -rw-r--r-- | 43.0 KB |
| syscall.c | -rw-r--r-- | 5.1 KB |
| util.c | -rw-r--r-- | 22.8 KB |
| util.h | -rw-r--r-- | 9.7 KB |
Computing file changes ...
