Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
Revision bfbb30618b3204dc62f9fc36b82b98f307f1a6a2 authored by Paul Gschwendtner on 06 February 2024, 14:06:49 UTC, committed by Jessica Janiuk on 06 February 2024, 17:33:23 UTC 
fix(compiler-cli): do not error due to multiple components named equally (#54273)
 
Currently, when two components are named `TestComponent`, and both would
use e.g. control flow. Templates would be generated by the compiler and
those would conflict at runtime because the names for the template
functions are not ensured to be unique.

This seems like a more general problem that could be tackled in the
future in the template pipeline by always using the `ConstantPool`, but
for now, we should be good already, given us ensuring the `baseName`'s are
always unique.

PR Close #54273
1 parent 19fae76
History
Tip revision: bfbb30618b3204dc62f9fc36b82b98f307f1a6a2 authored by Paul Gschwendtner on 06 February 2024, 14:06:49 UTC
fix(compiler-cli): do not error due to multiple components named equally (#54273)
Tip revision: bfbb306
File Mode Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
adev
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore -rw-r--r-- 1.6 KB
.bazelrc -rw-r--r-- 7.7 KB
.bazelversion -rw-r--r-- 6 bytes
.clang-format -rw-r--r-- 73 bytes
.editorconfig -rw-r--r-- 245 bytes
.gitattributes -rw-r--r-- 146 bytes
.gitignore -rw-r--r-- 1004 bytes
.gitmessage -rw-r--r-- 7.2 KB
.mailmap -rw-r--r-- 51 bytes
.npmrc -rw-r--r-- 21 bytes
.nvmrc -rw-r--r-- 8 bytes
.prettierrc -rw-r--r-- 157 bytes
.pullapprove.yml -rw-r--r-- 52.3 KB
.yarnrc -rw-r--r-- 130 bytes
BUILD.bazel -rw-r--r-- 2.5 KB
CHANGELOG.md -rw-r--r-- 266.9 KB
CHANGELOG_ARCHIVE.md -rw-r--r-- 997.0 KB
CODE_OF_CONDUCT.md -rw-r--r-- 3.6 KB
CONTRIBUTING.md -rw-r--r-- 15.7 KB
LICENSE -rw-r--r-- 1.1 KB
README.md -rw-r--r-- 5.5 KB
SECURITY.md -rw-r--r-- 403 bytes
WORKSPACE -rw-r--r-- 8.9 KB
browser-providers.conf.d.ts -rw-r--r-- 387 bytes
browser-providers.conf.js -rw-r--r-- 1.9 KB
gulpfile.js -rw-r--r-- 572 bytes
karma-js.conf.js -rw-r--r-- 6.0 KB
package.json -rw-r--r-- 9.9 KB
packages.bzl -rw-r--r-- 3.8 KB
renovate.json -rw-r--r-- 3.0 KB
tsconfig-tslint.json -rw-r--r-- 171 bytes
tslint.json -rw-r--r-- 5.3 KB
yarn.bzl -rw-r--r-- 77 bytes
yarn.lock -rw-r--r-- 780.1 KB
yarn.lock.readme.md -rw-r--r-- 1.3 KB

README.md

back to top