Revision - bfcfd44 - xattr: fix check for simultaneous glibc header inclusion - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

27 March 2024, 02:37:15 UTC

Revision bfcfd44cce2774f19daeb59fb4e43fc9aa80e7b8 authored by Filipe Brandenburger on 29 August 2014, 22:18:51 UTC, committed by Linus Torvalds on 29 August 2014, 23:28:16 UTC

xattr: fix check for simultaneous glibc header inclusion

The guard was introduced in commit ea1a8217b06b ("xattr: guard against
simultaneous glibc header inclusion") but it is using #ifdef to check
for a define that is either set to 1 or 0.  Fix it to use #if instead.

* Without this patch:

  $ { echo "#include <sys/xattr.h>"; echo "#include <linux/xattr.h>"; } | gcc -E -Iinclude/uapi - >/dev/null
  include/uapi/linux/xattr.h:19:0: warning: "XATTR_CREATE" redefined [enabled by default]
   #define XATTR_CREATE 0x1 /* set value, fail if attr already exists */
   ^
  /usr/include/x86_64-linux-gnu/sys/xattr.h:32:0: note: this is the location of the previous definition
   #define XATTR_CREATE XATTR_CREATE
   ^

* With this patch:

  $ { echo "#include <sys/xattr.h>"; echo "#include <linux/xattr.h>"; } | gcc -E -Iinclude/uapi - >/dev/null
  (no warnings)

Signed-off-by: Filipe Brandenburger <filbranden@google.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
Cc: Allan McRae <allan@archlinux.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 parent b41d34b

Files
Changes

Tip revision: bfcfd44cce2774f19daeb59fb4e43fc9aa80e7b8 authored by Filipe Brandenburger on 29 August 2014, 22:18:51 UTC
xattr: fix check for simultaneous glibc header inclusion

Tip revision: bfcfd44

File	Mode	Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.gitignore	-rw-r--r--	1.1 KB
.mailmap	-rw-r--r--	4.7 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	93.8 KB
Kbuild	-rw-r--r--	2.5 KB
Kconfig	-rw-r--r--	252 bytes
MAINTAINERS	-rw-r--r--	279.0 KB
Makefile	-rw-r--r--	52.8 KB
README	-rw-r--r--	18.3 KB
REPORTING-BUGS	-rw-r--r--	7.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

xattr: fix check for simultaneous glibc header inclusion

README