Revision bfeda41d06d85ad9d52f2413cfc2b77be5022f75 authored by Omar Sandoval on 07 February 2017, 23:33:20 UTC, committed by Ingo Molnar on 08 February 2017, 07:21:31 UTC
Since KERN_CONT became meaningful again, lockdep stack traces have had
annoying extra newlines, like this:

[    5.561122] -> #1 (B){+.+...}:
[    5.561528]
[    5.561532] [<ffffffff810d8873>] lock_acquire+0xc3/0x210
[    5.562178]
[    5.562181] [<ffffffff816f6414>] mutex_lock_nested+0x74/0x6d0
[    5.562861]
[    5.562880] [<ffffffffa01aa3c3>] init_btrfs_fs+0x21/0x196 [btrfs]
[    5.563717]
[    5.563721] [<ffffffff81000472>] do_one_initcall+0x52/0x1b0
[    5.564554]
[    5.564559] [<ffffffff811a3af6>] do_init_module+0x5f/0x209
[    5.565357]
[    5.565361] [<ffffffff81122f4d>] load_module+0x218d/0x2b80
[    5.566020]
[    5.566021] [<ffffffff81123beb>] SyS_finit_module+0xeb/0x120
[    5.566694]
[    5.566696] [<ffffffff816fd241>] entry_SYSCALL_64_fastpath+0x1f/0xc2

That's happening because each printk() call now gets printed on its own
line, and we do a separate call to print the spaces before the symbol.
Fix it by doing the printk() directly instead of using the
print_ip_sym() helper.

Additionally, the symbol address isn't very helpful, so let's get rid of
that, too. The final result looks like this:

[    5.194518] -> #1 (B){+.+...}:
[    5.195002]        lock_acquire+0xc3/0x210
[    5.195439]        mutex_lock_nested+0x74/0x6d0
[    5.196491]        do_one_initcall+0x52/0x1b0
[    5.196939]        do_init_module+0x5f/0x209
[    5.197355]        load_module+0x218d/0x2b80
[    5.197792]        SyS_finit_module+0xeb/0x120
[    5.198251]        entry_SYSCALL_64_fastpath+0x1f/0xc2

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-team@fb.com
Fixes: 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")
Link: http://lkml.kernel.org/r/43b4e114724b2bdb0308fa86cb33aa07d3d67fad.1486510315.git.osandov@fb.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 926af62
History
File Mode Size
acpica
apei
arm64
dptf
nfit
pmic
Kconfig -rw-r--r-- 16.5 KB
Makefile -rw-r--r-- 3.2 KB
ac.c -rw-r--r-- 11.0 KB
acpi_amba.c -rw-r--r-- 2.8 KB
acpi_apd.c -rw-r--r-- 4.4 KB
acpi_cmos_rtc.c -rw-r--r-- 2.1 KB
acpi_configfs.c -rw-r--r-- 5.9 KB
acpi_dbg.c -rw-r--r-- 18.2 KB
acpi_extlog.c -rw-r--r-- 8.7 KB
acpi_ipmi.c -rw-r--r-- 17.0 KB
acpi_lpat.c -rw-r--r-- 4.4 KB
acpi_lpss.c -rw-r--r-- 24.9 KB
acpi_memhotplug.c -rw-r--r-- 10.3 KB
acpi_pad.c -rw-r--r-- 12.4 KB
acpi_platform.c -rw-r--r-- 3.8 KB
acpi_pnp.c -rw-r--r-- 13.7 KB
acpi_processor.c -rw-r--r-- 17.3 KB
acpi_video.c -rw-r--r-- 54.3 KB
acpi_watchdog.c -rw-r--r-- 3.0 KB
battery.c -rw-r--r-- 38.5 KB
battery.h -rw-r--r-- 220 bytes
bgrt.c -rw-r--r-- 2.7 KB
blacklist.c -rw-r--r-- 5.3 KB
bus.c -rw-r--r-- 32.1 KB
button.c -rw-r--r-- 16.3 KB
cm_sbs.c -rw-r--r-- 2.8 KB
container.c -rw-r--r-- 3.3 KB
cppc_acpi.c -rw-r--r-- 35.0 KB
custom_method.c -rw-r--r-- 2.1 KB
debugfs.c -rw-r--r-- 422 bytes
device_pm.c -rw-r--r-- 31.6 KB
device_sysfs.c -rw-r--r-- 16.5 KB
dock.c -rw-r--r-- 17.1 KB
ec.c -rw-r--r-- 53.5 KB
ec_sys.c -rw-r--r-- 3.5 KB
event.c -rw-r--r-- 4.2 KB
evged.c -rw-r--r-- 3.8 KB
fan.c -rw-r--r-- 10.6 KB
glue.c -rw-r--r-- 9.0 KB
gsi.c -rw-r--r-- 2.6 KB
hed.c -rw-r--r-- 2.3 KB
internal.h -rw-r--r-- 8.3 KB
ioapic.c -rw-r--r-- 5.6 KB
numa.c -rw-r--r-- 12.7 KB
nvs.c -rw-r--r-- 4.6 KB
osi.c -rw-r--r-- 13.1 KB
osl.c -rw-r--r-- 39.1 KB
pci_irq.c -rw-r--r-- 14.1 KB
pci_link.c -rw-r--r-- 24.2 KB
pci_mcfg.c -rw-r--r-- 8.3 KB
pci_root.c -rw-r--r-- 24.5 KB
pci_slot.c -rw-r--r-- 5.1 KB
power.c -rw-r--r-- 22.3 KB
proc.c -rw-r--r-- 3.6 KB
processor_core.c -rw-r--r-- 11.4 KB
processor_driver.c -rw-r--r-- 8.6 KB
processor_idle.c -rw-r--r-- 38.0 KB
processor_pdc.c -rw-r--r-- 4.6 KB
processor_perflib.c -rw-r--r-- 20.1 KB
processor_thermal.c -rw-r--r-- 6.5 KB
processor_throttling.c -rw-r--r-- 31.2 KB
property.c -rw-r--r-- 23.4 KB
reboot.c -rw-r--r-- 1.3 KB
resource.c -rw-r--r-- 21.4 KB
sbs.c -rw-r--r-- 20.2 KB
sbshc.c -rw-r--r-- 7.2 KB
sbshc.h -rw-r--r-- 960 bytes
scan.c -rw-r--r-- 53.7 KB
sleep.c -rw-r--r-- 22.0 KB
sleep.h -rw-r--r-- 412 bytes
spcr.c -rw-r--r-- 2.4 KB
sysfs.c -rw-r--r-- 25.0 KB
tables.c -rw-r--r-- 21.2 KB
thermal.c -rw-r--r-- 32.0 KB
utils.c -rw-r--r-- 18.9 KB
video_detect.c -rw-r--r-- 11.8 KB
wakeup.c -rw-r--r-- 2.7 KB

back to top