Revision bfeda41d06d85ad9d52f2413cfc2b77be5022f75 authored by Omar Sandoval on 07 February 2017, 23:33:20 UTC, committed by Ingo Molnar on 08 February 2017, 07:21:31 UTC
Since KERN_CONT became meaningful again, lockdep stack traces have had
annoying extra newlines, like this:

[    5.561122] -> #1 (B){+.+...}:
[    5.561528]
[    5.561532] [<ffffffff810d8873>] lock_acquire+0xc3/0x210
[    5.562178]
[    5.562181] [<ffffffff816f6414>] mutex_lock_nested+0x74/0x6d0
[    5.562861]
[    5.562880] [<ffffffffa01aa3c3>] init_btrfs_fs+0x21/0x196 [btrfs]
[    5.563717]
[    5.563721] [<ffffffff81000472>] do_one_initcall+0x52/0x1b0
[    5.564554]
[    5.564559] [<ffffffff811a3af6>] do_init_module+0x5f/0x209
[    5.565357]
[    5.565361] [<ffffffff81122f4d>] load_module+0x218d/0x2b80
[    5.566020]
[    5.566021] [<ffffffff81123beb>] SyS_finit_module+0xeb/0x120
[    5.566694]
[    5.566696] [<ffffffff816fd241>] entry_SYSCALL_64_fastpath+0x1f/0xc2

That's happening because each printk() call now gets printed on its own
line, and we do a separate call to print the spaces before the symbol.
Fix it by doing the printk() directly instead of using the
print_ip_sym() helper.

Additionally, the symbol address isn't very helpful, so let's get rid of
that, too. The final result looks like this:

[    5.194518] -> #1 (B){+.+...}:
[    5.195002]        lock_acquire+0xc3/0x210
[    5.195439]        mutex_lock_nested+0x74/0x6d0
[    5.196491]        do_one_initcall+0x52/0x1b0
[    5.196939]        do_init_module+0x5f/0x209
[    5.197355]        load_module+0x218d/0x2b80
[    5.197792]        SyS_finit_module+0xeb/0x120
[    5.198251]        entry_SYSCALL_64_fastpath+0x1f/0xc2

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-team@fb.com
Fixes: 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")
Link: http://lkml.kernel.org/r/43b4e114724b2bdb0308fa86cb33aa07d3d67fad.1486510315.git.osandov@fb.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 926af62
History
File Mode Size
governors
Kconfig -rw-r--r-- 1.0 KB
Kconfig.arm -rw-r--r-- 2.4 KB
Kconfig.mips -rw-r--r-- 618 bytes
Kconfig.powerpc -rw-r--r-- 480 bytes
Makefile -rw-r--r-- 1.2 KB
coupled.c -rw-r--r-- 25.6 KB
cpuidle-arm.c -rw-r--r-- 3.7 KB
cpuidle-at91.c -rw-r--r-- 1.6 KB
cpuidle-big_little.c -rw-r--r-- 6.7 KB
cpuidle-calxeda.c -rw-r--r-- 2.2 KB
cpuidle-clps711x.c -rw-r--r-- 1.5 KB
cpuidle-cps.c -rw-r--r-- 4.4 KB
cpuidle-exynos.c -rw-r--r-- 3.4 KB
cpuidle-kirkwood.c -rw-r--r-- 2.3 KB
cpuidle-mvebu-v7.c -rw-r--r-- 3.3 KB
cpuidle-powernv.c -rw-r--r-- 9.1 KB
cpuidle-pseries.c -rw-r--r-- 5.9 KB
cpuidle-ux500.c -rw-r--r-- 3.2 KB
cpuidle-zynq.c -rw-r--r-- 2.0 KB
cpuidle.c -rw-r--r-- 15.6 KB
cpuidle.h -rw-r--r-- 2.0 KB
driver.c -rw-r--r-- 9.4 KB
dt_idle_states.c -rw-r--r-- 6.5 KB
dt_idle_states.h -rw-r--r-- 177 bytes
governor.c -rw-r--r-- 2.1 KB
sysfs.c -rw-r--r-- 16.1 KB

back to top