Revision - c1885fc - Fixes to bounds inference on shift_left (#5477) - origin: https://github.com/halide/Halide

visit type:

https://github.com/halide/Halide

21 March 2024, 02:33:35 UTC

Revision c1885fc710ddebff3e50023e662e9f822a7f2a3d authored by Alexander Root on 04 December 2020, 00:14:07 UTC, committed by GitHub on 04 December 2020, 00:14:07 UTC

Fixes to bounds inference on shift_left (#5477)

* Add shift_left fix for signed integers by possibly negative values + regression test

* add required condition on shift_left integer fix

* add type check to shift_left minimum condition

* fix constant folding of shifts with |b| >= type.bits() for types that allow overflow (failes correctness/simplify test)

* make regression tests use scoped bindings

* change condition in case int24/int48 proposal happens soon

* revert changes based on overflow expectations

* add more regression tests

* clarify comment

* add shift_left min handler for b only UB

* fix clang-tidy complaint

* relax shift_left of non-negative value constraint

* pull case outside of unnecessary preconditions

* fix clang-format complaint

* fix broken precondition

* add typecheck to possibly save a can_prove() call

* add easy-out type check to precondition

* Add descriptive comment to bug fix + add another early-exit precondition

Co-authored-by: Steven Johnson <srj@google.com>

1 parent 28f9aef

Files
Changes

Permalinks

Tip revision: c1885fc710ddebff3e50023e662e9f822a7f2a3d authored by Alexander Root on 04 December 2020, 00:14:07 UTC
Fixes to bounds inference on shift_left (#5477)

Tip revision: c1885fc

File	Mode	Size
.github
apps
cmake
dependencies
doc
packaging
python_bindings
src
test
tools
tutorial
util
.clang-format	-rw-r--r--	1.4 KB
.clang-format-ignore	-rw-r--r--	265 bytes
.clang-tidy	-rw-r--r--	1.8 KB
.gitattributes	-rw-r--r--	342 bytes
.gitignore	-rw-r--r--	1.1 KB
.gitmodules	-rw-r--r--	0 bytes
CMakeLists.txt	-rw-r--r--	4.2 KB
CMakePresets.json	-rw-r--r--	2.4 KB
CODE_OF_CONDUCT.md	-rw-r--r--	3.5 KB
LICENSE.txt	-rw-r--r--	3.2 KB
Makefile	-rw-r--r--	94.7 KB
README.md	-rw-r--r--	20.6 KB
README_cmake.md	-rw-r--r--	68.6 KB
README_rungen.md	-rw-r--r--	12.1 KB
README_webassembly.md	-rw-r--r--	7.5 KB
run-clang-format.sh	-rwxr-xr-x	1.4 KB
run-clang-tidy.sh	-rwxr-xr-x	3.0 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/halide/Halide

Fixes to bounds inference on shift_left (#5477)

README.md