Revision c22889e76cb9b7fd8a4710d9bf53e827aaa907e4 authored by Shuhei Kadowaki on 24 August 2021, 04:21:29 UTC, committed by Shuhei Kadowaki on 26 October 2021, 14:45:33 UTC
Currently our constant-prop' heuristics work in the following way:
1. `const_prop_entry_heuristic`
2. `const_prop_argument_heuristic` & `const_prop_rettype_heuristic`
3. `force_const_prop` custom heuristic & `!const_prop_function_heuristic`
4. `MethodInstance` specialization and `const_prop_methodinstance_heuristic`
This PR changes it so that the step 1. now works like:
1. `force_const_prop` custom heuristic & `const_prop_entry_heuristic`
and the steps 2., 3. and 4. don't change
This change particularly allows us to more forcibly constant-propagate
for `getproperty` and `setproperty!`, and inline them more, e.g.:
```julia
mutable struct Foo
val
_::Int
end
function setter(xs)
for x in xs
x.val = nothing # `setproperty!` can be inlined with this PR
end
end
```
It might be useful because now we can intervene into the constant-prop'
heuristic in a more reliable way with the `aggressive_constprop` interface.
I did the simple benchmark below, and it looks like this change doesn't
cause the latency problem for this particular example:
```zsh
~/julia master aviatesk@amdci2 6s
❯ ./usr/bin/julia -e '@time using Plots; @time plot(rand(10,3))'
3.708500 seconds (7.28 M allocations: 506.128 MiB, 3.45% gc time, 1.13% compilation time)
2.817794 seconds (3.45 M allocations: 195.127 MiB, 7.84% gc time, 53.76% compilation time)
~/julia avi/forceconstantprop aviatesk@amdci2 6s
❯ ./usr/bin/julia -e '@time using Plots; @time plot(rand(10,3))'
3.622109 seconds (7.02 M allocations: 481.710 MiB, 4.19% gc time, 1.17% compilation time)
2.863419 seconds (3.44 M allocations: 194.210 MiB, 8.02% gc time, 53.53% compilation time)
```
1 parent da71d29
intrinsics.h
// This file is a part of Julia. License is MIT: https://julialang.org/license
#define INTRINSICS \
/* wrap and unwrap */ \
ADD_I(bitcast, 2) \
/* arithmetic */ \
ADD_I(neg_int, 1) \
ADD_I(add_int, 2) \
ADD_I(sub_int, 2) \
ADD_I(mul_int, 2) \
ADD_I(sdiv_int, 2) \
ADD_I(udiv_int, 2) \
ADD_I(srem_int, 2) \
ADD_I(urem_int, 2) \
ADD_I(add_ptr, 2) \
ADD_I(sub_ptr, 2) \
ADD_I(neg_float, 1) \
ADD_I(add_float, 2) \
ADD_I(sub_float, 2) \
ADD_I(mul_float, 2) \
ADD_I(div_float, 2) \
ADD_I(rem_float, 2) \
ADD_I(fma_float, 3) \
ADD_I(muladd_float, 3) \
/* fast arithmetic */ \
ALIAS(neg_float_fast, neg_float) \
ALIAS(add_float_fast, add_float) \
ALIAS(sub_float_fast, sub_float) \
ALIAS(mul_float_fast, mul_float) \
ALIAS(div_float_fast, div_float) \
ALIAS(rem_float_fast, rem_float) \
/* same-type comparisons */ \
ADD_I(eq_int, 2) \
ADD_I(ne_int, 2) \
ADD_I(slt_int, 2) \
ADD_I(ult_int, 2) \
ADD_I(sle_int, 2) \
ADD_I(ule_int, 2) \
ADD_I(eq_float, 2) \
ADD_I(ne_float, 2) \
ADD_I(lt_float, 2) \
ADD_I(le_float, 2) \
ALIAS(eq_float_fast, eq_float) \
ALIAS(ne_float_fast, ne_float) \
ALIAS(lt_float_fast, lt_float) \
ALIAS(le_float_fast, le_float) \
ADD_I(fpiseq, 2) \
/* bitwise operators */ \
ADD_I(and_int, 2) \
ADD_I(or_int, 2) \
ADD_I(xor_int, 2) \
ADD_I(not_int, 1) \
ADD_I(shl_int, 2) \
ADD_I(lshr_int, 2) \
ADD_I(ashr_int, 2) \
ADD_I(bswap_int, 1) \
ADD_I(ctpop_int, 1) \
ADD_I(ctlz_int, 1) \
ADD_I(cttz_int, 1) \
/* conversion */ \
ADD_I(sext_int, 2) \
ADD_I(zext_int, 2) \
ADD_I(trunc_int, 2) \
ADD_I(fptoui, 2) \
ADD_I(fptosi, 2) \
ADD_I(uitofp, 2) \
ADD_I(sitofp, 2) \
ADD_I(fptrunc, 2) \
ADD_I(fpext, 2) \
/* checked arithmetic */ \
ADD_I(checked_sadd_int, 2) \
ADD_I(checked_uadd_int, 2) \
ADD_I(checked_ssub_int, 2) \
ADD_I(checked_usub_int, 2) \
ADD_I(checked_smul_int, 2) \
ADD_I(checked_umul_int, 2) \
ADD_I(checked_sdiv_int, 2) \
ADD_I(checked_udiv_int, 2) \
ADD_I(checked_srem_int, 2) \
ADD_I(checked_urem_int, 2) \
/* functions */ \
ADD_I(abs_float, 1) \
ADD_I(copysign_float, 2) \
ADD_I(flipsign_int, 2) \
ADD_I(ceil_llvm, 1) \
ADD_I(floor_llvm, 1) \
ADD_I(trunc_llvm, 1) \
ADD_I(rint_llvm, 1) \
ADD_I(sqrt_llvm, 1) \
ADD_I(sqrt_llvm_fast, 1) \
/* pointer access */ \
ADD_I(pointerref, 3) \
ADD_I(pointerset, 4) \
/* pointer atomics */ \
ADD_I(atomic_fence, 1) \
ADD_I(atomic_pointerref, 2) \
ADD_I(atomic_pointerset, 3) \
ADD_I(atomic_pointerswap, 3) \
ADD_I(atomic_pointermodify, 4) \
ADD_I(atomic_pointerreplace, 5) \
/* c interface */ \
ADD_I(cglobal, 2) \
ALIAS(llvmcall, llvmcall) \
/* object access */ \
ADD_I(arraylen, 1) \
/* hidden intrinsics */ \
ADD_HIDDEN(cglobal_auto, 1)
enum intrinsic {
#define ADD_I(func, nargs) func,
#define ADD_HIDDEN ADD_I
#define ALIAS ADD_I
INTRINSICS
#undef ADD_I
#undef ADD_HIDDEN
#undef ALIAS
num_intrinsics
};
Computing file changes ...
