Revision c46d533b22267557a6b20db8f7eb8d77449627e6 authored by Paul Gschwendtner on 16 December 2021, 13:11:53 UTC, committed by Andrew Scott on 05 January 2022, 23:20:20 UTC
To make our test output i.e. devmode output more aligned
with what we produce in the NPM packages, or to be more
aligned with what Angular applications will usually consume,
the devmode output is switched from ES5 to ES2015.

Additionally various tsconfigs (outside of Bazel) have been
updated to match with the other parts of the build. The rules
are:

ES2015 for test configurations, ES2020 for actual code that will
end up being shipped (this includes the IDE-only tsconfigs).

PR Close #44505
1 parent 8388151
Raw File
tslint.json
{
  "rulesDirectory": [
    "tools/tslint",
    "node_modules/@angular/dev-infra-private/tslint-rules",
    "node_modules/vrsource-tslint-rules/rules",
    "node_modules/tslint-eslint-rules/dist/rules",
    "node_modules/tslint-no-toplevel-property-access/rules"
  ],
  "rules": {
    // The first rule needs to be `ts-node-loader` which sets up `ts-node` within TSLint so
    // that rules written in TypeScript can be loaded without needing to be transpiled.
    "ts-node-loader": true,
    // Custom rules written in TypeScript.
    "require-internal-with-underscore": true,
    "no-implicit-override-abstract": true,
    "validate-import-for-esm-cjs-interop": [true, {
      // The following CommonJS modules have type definitions that suggest the existence of
      // named exports. This is not true at runtime when imported from an ES module (because
      // the ESM interop only exposes statically-discoverable named exports). Instead
      // default imports should be used to ensure compatibility with both ESM or CommonJS.
      "noNamedExports": ["typescript", "minimist", "magic-string", "semver", "yargs", "glob", "cluster", "convert-source-map"],
      // The following CommonJS modules appear to have a default export available (due to the `esModuleInterop` flag),
      // but at runtime with CJS (e.g. for devmode output/tests) there is no default export as these modules set
      // `__esModule`. This does not match with what happens in ESM NodeJS runtime where NodeJS exposes
      // `module.exports` as `export default`. Instead, named exports should be used for compat with CJS/ESM.
      "noDefaultExport": [],
      // List of modules which are incompatible and should never be imported at all.
      "incompatibleModules": {
        // `@babel/core` and `@babel/types` suggest named exports which do not exist at runtime within ESM
        // (as these named exports are not statically discoverable by NodeJS). At the same time, these modules
        // set `__esModule` and the default import does not exist for CJS at runtime (e.g. breaking tests).
        "@babel/core": "This module is incompatible with the ESM/CJS interop. Use the custom interop file.",
        "@babel/types": "This module is incompatible with the ESM/CJS interop. Use the custom interop file and import the `types` namespace."
      }
    }],
    "eofline": true,
    "file-header": [
      true,
      {
        "match": "Copyright Google LLC",
        "allow-single-line-comments": false
      }
    ],
    "no-console": [
      true,
      "log"
    ],
    "no-construct": true,
    "no-duplicate-imports": true,
    "no-duplicate-variable": true,
    "no-var-keyword": true,
    "prefer-literal": [
      true,
      "object"
    ],
    "no-toplevel-property-access": [
      true,
      "packages/animations/src/",
      "packages/animations/browser/",
      "packages/common/src/",
      "packages/core/src/",
      "packages/elements/src/",
      "packages/forms/src/",
      "packages/platform-browser/src/",
      "packages/router/src/"
    ],
    "semicolon": [
      true
    ],
    "variable-name": [
      true,
      "ban-keywords"
    ],
    "no-inner-declarations": [
      true,
      "function"
    ],
    "no-debugger": true,
    "ban": [
      true,
      {"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
      {"name": "fit", "message": "Don't keep jasmine focus methods."}
    ]
  },
  "jsRules": {
    // The first rule needs to be `ts-node-loader` which sets up `ts-node` within TSLint so
    // that rules written in TypeScript can be loaded without needing to be transpiled.
    "ts-node-loader": true,
    // Custom rules written in TypeScript.
    "require-internal-with-underscore": true,

    "eofline": true,
    "file-header": [
      true,
      {
        "match": "Copyright Google LLC",
        "allow-single-line-comments": false
      }
    ],
    "no-console": [
      true,
      "log"
    ],
    "no-duplicate-imports": true,
    "no-duplicate-variable": true,
    "semicolon": [
      true
    ],
    "variable-name": [
      true,
      "ban-keywords"
    ],
    "no-inner-declarations": [
      true,
      "function"
    ],
    "ban": [
      true,
      {"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
      {"name": "fit", "message": "Don't keep jasmine focus methods."}
    ]
  },
  "linterOptions": {
    "exclude": [
      "**/node_modules/**/*",
      // Ignore AIO and integration tests.
      "./aio/**/*",
      "./integration/**/*",
      // Ignore output directories
      "./built/**/*",
      "./dist/**/*",
      "./bazel-out/**/*",
      // Ignore special files
      "**/*.externs.js",
      // Ignore test files
      "./packages/compiler-cli/test/compliance/test_cases/**/*",
      "./packages/localize/**/test_files/**/*",
      "./tools/public_api_guard/**/*.d.ts",
      "./modules/benchmarks_external/**/*",
      // Ignore zone.js directory
      // TODO(JiaLiPassion): add zone.js back later
      "./packages/zone.js/**/*"
    ]
  }
}
back to top