Revision c4e18497d8fd92eef2c6e7eadcc1a107ccd115ea authored by Guenter Roeck on 20 December 2012, 23:05:42 UTC, committed by Linus Torvalds on 21 December 2012, 01:40:20 UTC
Commit 263a523d18bc ("linux/kernel.h: Fix warning seen with W=1 due to change in DIV_ROUND_CLOSEST") fixes a warning seen with W=1 due to change in DIV_ROUND_CLOSEST. Unfortunately, the C compiler converts divide operations with unsigned divisors to unsigned, even if the dividend is signed and negative (for example, -10 / 5U = 858993457). The C standard says "If one operand has unsigned int type, the other operand is converted to unsigned int", so the compiler is not to blame. As a result, DIV_ROUND_CLOSEST(0, 2U) and similar operations now return bad values, since the automatic conversion of expressions such as "0 - 2U/2" to unsigned was not taken into account. Fix by checking for the divisor variable type when deciding which operation to perform. This fixes DIV_ROUND_CLOSEST(0, 2U), but still returns bad values for negative dividends divided by unsigned divisors. Mark the latter case as unsupported. One observed effect of this problem is that the s2c_hwmon driver reports a value of 4198403 instead of 0 if the ADC reads 0. Other impact is unpredictable. Problem is seen if the divisor is an unsigned variable or constant and the dividend is less than (divisor/2). Signed-off-by: Guenter Roeck <linux@roeck-us.net> Reported-by: Juergen Beisert <jbe@pengutronix.de> Tested-by: Juergen Beisert <jbe@pengutronix.de> Cc: Jean Delvare <khali@linux-fr.org> Cc: <stable@vger.kernel.org> [3.7.x] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 154b454
File | Mode | Size |
---|---|---|
.gitignore | -rw-r--r-- | 12 bytes |
Kconfig | -rw-r--r-- | 1.3 KB |
Makefile | -rw-r--r-- | 758 bytes |
asymmetric_keys.h | -rw-r--r-- | 518 bytes |
asymmetric_type.c | -rw-r--r-- | 6.7 KB |
public_key.c | -rw-r--r-- | 2.6 KB |
public_key.h | -rw-r--r-- | 962 bytes |
rsa.c | -rw-r--r-- | 6.6 KB |
signature.c | -rw-r--r-- | 1.3 KB |
x509.asn1 | -rw-r--r-- | 1.6 KB |
x509_cert_parser.c | -rw-r--r-- | 11.9 KB |
x509_parser.h | -rw-r--r-- | 1.3 KB |
x509_public_key.c | -rw-r--r-- | 6.8 KB |
x509_rsakey.asn1 | -rw-r--r-- | 130 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...