| c5947ae | Michael Gratton | 17 October 2019, 00:35:49 UTC | gtestutils: Allow whole test suites to be skipped Before executing a test squite, check that its name isn't present in the list of skipped paths and if so, skip the whole suite. Per other cases, report it skipped only if in verbose mode. This enables skipping a whole test suite using `-s /suite-name`. Fixes #1908 | 24 November 2019, 23:06:47 UTC |
| cca92a1 | Michael Gratton | 17 October 2019, 00:33:35 UTC | gtestutils: Fix documentation bug Tests with '/subprocess' can only be forced to run by `-p`, not `-s`. | 17 October 2019, 00:33:35 UTC |
| 3dec72b | Philip Withnall | 14 October 2019, 13:10:39 UTC | Merge branch 'wip/lantw/use-uname-as-a-fallback-to-get-os-info' into 'master' Use uname as a fallback to get OS info See merge request GNOME/glib!1165 | 14 October 2019, 13:10:39 UTC |
| d219b35 | Ting-Wei Lan | 13 October 2019, 12:44:24 UTC | gutils: Use uname to report OS info when there is no os-release file There are a lot of Unix-like systems which have not implemented the os-release spec. On such system, we can use POSIX uname function as a fallback to get basic information of the system. | 14 October 2019, 12:42:08 UTC |
| 00abf67 | Ting-Wei Lan | 13 October 2019, 09:36:57 UTC | gutils: Only use the default OS name on Linux /etc/os-release is a spec designed for Linux. While other OSes can implement it, it doesn't make sense to use Linux as the default value on systems which don't use Linux. | 14 October 2019, 12:25:51 UTC |
| 89ad928 | Ting-Wei Lan | 13 October 2019, 09:15:53 UTC | gutils: Do not translate OS names The code is intended to provide an interface similar to /etc/os-release, but /etc/os-release isn't designed to be translated. | 14 October 2019, 12:25:51 UTC |
| 493909b | Philip Withnall | 14 October 2019, 12:12:06 UTC | Merge branch 'osinfo' into 'master' Add Windows support to g_get_os_info() See merge request GNOME/glib!1160 | 14 October 2019, 12:12:06 UTC |
| fc2f566 | Руслан Ижбулатов | 09 October 2019, 20:36:03 UTC | Add Windows support to g_get_os_info() Most of the info returned is static, the only thing that changes is the OS version. This code relies on g_win32_check_windows_version() providing accurate information (hopefully, MS won't nix RtlGetVersion() on which we use for that) and supplements it with information from the registry for Windows >= 8.1. | 11 October 2019, 06:07:26 UTC |
| c7dd1ae | Philip Withnall | 10 October 2019, 14:55:20 UTC | Merge branch '1896-use-after-free-when-calling-g_dbus_connection_flush_sync-in-a-dedicated-thread' into 'master' Resolve "Use after free when calling g_dbus_connection_flush_sync() in a dedicated thread" Closes #1896 See merge request GNOME/glib!1158 | 10 October 2019, 14:55:20 UTC |
| 822f8ba | Milan Crha | 10 October 2019, 14:55:20 UTC | Fix use-after-free when calling g_dbus_connection_flush_sync() When the _g_dbus_worker_flush_sync() schedules the 'data' and releases the worker->write_lock, it is possible for the GDBus worker thread thread to finish the D-Bus call and acquire the worker->write_lock before the _g_dbus_worker_flush_sync() re-acquires it in the if (data != NULL) body. When that happens, the ostream_flush_cb() increases the worker->write_num_messages_flushed and then releases the worker->write_lock. The write lock is reacquired by the _g_dbus_worker_flush_sync(), which sees that the while condition is satisfied, thus it doesn't enter the loop body and immediately clears the data members and frees the data structure itself. The ostream_flush_cb() is still ongoing, possibly inside flush_data_list_complete(), where it accesses the FlushData, which can be in any stage of being freed. Instead, add an explicit boolean flag indicating when the flush is truly finished. Closes #1896 | 10 October 2019, 14:55:20 UTC |
| c975657 | Philip Withnall | 10 October 2019, 14:53:42 UTC | Merge branch 'wip/tingping/localhost-is-local' into 'master' Always resolve localhost to loopback address See merge request GNOME/glib!616 | 10 October 2019, 14:53:42 UTC |
| a50a08f | Philip Withnall | 10 October 2019, 14:06:13 UTC | Merge branch 'datetime-docs' into 'master' gdatetime: Document RFC 3339 extensions when parsing ISO 8601 See merge request GNOME/glib!1082 | 10 October 2019, 14:06:13 UTC |
| ea98aab | Philip Withnall | 10 October 2019, 14:06:13 UTC | gdatetime: Document RFC 3339 extensions when parsing ISO 8601 This is a follow-up to !1017. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 10 October 2019, 14:06:13 UTC |
| 168bdb1 | Philip Withnall | 10 October 2019, 14:01:21 UTC | Merge branch 'hash-me-faster' into 'master' hash: Remove an assertion from the hot path See merge request GNOME/glib!1161 | 10 October 2019, 14:01:21 UTC |
| ea99872 | Patrick Griffis | 05 February 2019, 13:53:44 UTC | Always resolve localhost to loopback address This always resolves "localhost" to a loopback address which has security benefits such as preventing a malicious dns server redirecting local connections and allows software to assume it is a secure hostname. This is being adopted by web browsers: - https://w3c.github.io/webappsec-secure-contexts/ - https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/RC9dSw-O3fE/E3_0XaT0BAAJ - https://chromium.googlesource.com/chromium/src.git/+/8da2a80724a9b896890602ff77ef2216cb951399 - https://bugs.webkit.org/show_bug.cgi?id=171934 - https://tools.ietf.org/html/draft-west-let-localhost-be-localhost-06 | 10 October 2019, 13:32:18 UTC |
| 01acb89 | Patrick Griffis | 05 February 2019, 13:50:09 UTC | tests: Don't block mainloop for delays in gnetworkaddress tests | 10 October 2019, 13:32:18 UTC |
| 1fb3628 | Matthias Clasen | 10 October 2019, 10:56:38 UTC | hash: Remove an assertion from the hot path This assert is using atomics and was showing up in some cache-heavy GTK profiles. Remove it. | 10 October 2019, 13:24:42 UTC |
| b50447b | Philip Withnall | 10 October 2019, 13:18:44 UTC | Merge branch 'issue1906' into 'master' gutils test: Don't assume that every Unix OS implements os-release(5) Closes #1906 See merge request GNOME/glib!1159 | 10 October 2019, 13:18:44 UTC |
| 0869cde | Philip Withnall | 10 October 2019, 13:15:39 UTC | Merge branch '1858-tutorial-deprecated-gobject-api' into 'master' Fix handling of private object members in GObject property tutorial Closes #1858 See merge request GNOME/glib!1069 | 10 October 2019, 13:15:39 UTC |
| 150b946 | Daniel Mustieles | 10 October 2019, 11:55:48 UTC | Updated Spanish translation | 10 October 2019, 11:55:48 UTC |
| d770e00 | Philip Withnall | 09 October 2019, 15:09:53 UTC | Merge branch 'wip/g-warning-once' into 'master' gmessages: Add g_warning_once() See merge request GNOME/glib!1028 | 09 October 2019, 15:09:53 UTC |
| 15e3b6f | Jonas Ådahl | 08 August 2019, 07:37:48 UTC | gmessages: Add g_warning_once() In many places the pattern static gboolean warned_once = FALSE; if (!warned_once) { g_warning ("This and that"); warned_once = TRUE; } is used to not spam the same warning message over and over again. Add a helper in glib for this, allowing the above statement to be changed to g_warning_once ("This and that"); | 09 October 2019, 14:39:31 UTC |
| f9a1970 | Simon McVittie | 09 October 2019, 13:11:08 UTC | gutils test: Don't assume that every Unix OS implements os-release(5) os-release(5) is widely implemented on Linux, but not necessarily ubiquitous: unusual or minimal Linux distributions might not have it. It could in principle be implemented by any other Unix OS, but in practice this has not yet happened. Closes: https://gitlab.gnome.org/GNOME/glib/issues/1906 Fixes: 349318e8 "gutils: Add g_get_os_info()" Signed-off-by: Simon McVittie <smcv@collabora.com> | 09 October 2019, 13:11:08 UTC |
| 35e2615 | Simon McVittie | 09 October 2019, 12:33:00 UTC | Merge branch 'android-warning-fixes' into 'master' Fix various compiler warnings on Android See merge request GNOME/glib!1157 | 09 October 2019, 12:33:00 UTC |
| 8492df9 | Philip Withnall | 08 October 2019, 12:52:13 UTC | gdbusaddress: Validate the noncefile attribute of nonce-tcp addresses Doing this mostly to fix a compiler warning about tautological assignments on Android. See the D-Bus specification: https://dbus.freedesktop.org/doc/dbus-specification.html#transports-nonce-tcp-sockets Signed-off-by: Philip Withnall <withnall@endlessm.com> | 08 October 2019, 12:53:01 UTC |
| e990038 | Philip Withnall | 08 October 2019, 12:50:59 UTC | gdbusaddress: Collapse two translatable strings into one Signed-off-by: Philip Withnall <withnall@endlessm.com> | 08 October 2019, 12:51:57 UTC |
| 3c4ff30 | Philip Withnall | 08 October 2019, 12:50:13 UTC | gunicollate: Remove tautological comparison As an unsigned integer, this variable is always greater than or equal to zero. Fixes a compiler warning on Android. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 08 October 2019, 12:50:13 UTC |
| e257e17 | Philip Withnall | 08 October 2019, 12:49:40 UTC | inotify: Fix some enum comparisons to integers `-1` isn’t a valid member of the enum, so cast to `int` first. This fixes a compiler warning on Android. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 08 October 2019, 12:49:40 UTC |
| 1bda4db | Ting-Wei Lan | 08 October 2019, 10:45:43 UTC | Update Chinese (Taiwan) translation | 08 October 2019, 10:45:43 UTC |
| 0d94ee3 | Philip Withnall | 08 October 2019, 10:33:40 UTC | Merge branch 'master' into 'master' Erase GI annotation: skip g_cancellable_source_new Closes #1877 See merge request GNOME/glib!1048 | 08 October 2019, 10:33:40 UTC |
| 45c91d7 | Philip Withnall | 08 October 2019, 10:30:24 UTC | Merge branch 'g-os-info' into 'master' gutils: Add g_get_os_info() See merge request GNOME/glib!1063 | 08 October 2019, 10:30:24 UTC |
| ab613ae | Philip Withnall | 08 October 2019, 10:26:45 UTC | Merge branch '1726-gdbus-codegen-h' into 'master' Resolve "Warn when method/signal uses type 'h' but lacks GDBus.C.UnixFD annotation" Closes #1726 See merge request GNOME/glib!1079 | 08 October 2019, 10:26:45 UTC |
| b229eed | Philip Withnall | 07 October 2019, 17:21:32 UTC | Merge branch 'str-printf-abort-oom' into 'master' Ensure that g_vasprintf will always abort on OOM and some docs fixes Closes #1622 See merge request GNOME/glib!1145 | 07 October 2019, 17:21:32 UTC |
| 109be1e | Daniel P. Berrangé | 04 October 2019, 14:04:01 UTC | glib: add parameter annotations for g_vasprintf and callers Document that g_vasprintf and g_strdup_printf are guaranteed to return a non-NULL string, unless the format string contains the locale sensitive conversions %lc or %ls. Further annotate that the output parameter for g_vasprintf and the format string for all functions must be non-NULL. Fixes #1622 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> | 07 October 2019, 16:29:34 UTC |
| 1403501 | Daniel P. Berrangé | 04 October 2019, 12:52:39 UTC | glib: ensure consistent abort-on-OOM with g_vasprintf & its callers The g_vasprintf method is called by g_strdup_vprintf, g_strdup_printf, g_string_append_vprintf and more. It has three different implementations depending on what the build target platform supports: 1. The gnulib impl appears to use the system malloc, but a '#define malloc g_malloc' causes it to use GLib's wrapper and thus abort on OOM. This mostly gets used on Windows platforms or UNIX platforms with broken printf formatting. 2. The main impl mostly used on modern Linux/UNIX calls the system vasprintf which uses the system malloc and does not abort on OOM. 3. The final impl used on remaining platforms calls system vsprintf on a buffer allocated by g_new, and thus always aborts on OOM. Of note is that impl 2 (using vasprintf) historically could abort on OOM, if the application had installed a non-system malloc impl with GLib. This was because the code would g_strndup the result from vasprintf() in that scenario. This was removed in: commit a3660532535f92cfac136435579ed4f23231f48c Author: Dan Winship <danw@gnome.org> Date: Fri Aug 7 09:46:49 2015 -0400 glib: remove deprecated g_mem_is_system_malloc() check in gprintf.c Having inconsistent OOM behaviour for the three impls is undesirable and aborting on OOM is normal pratice for GLib APIs. Thus we must thus ensure this happens in all impls of g_vasprintf. Fixes #1622 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> | 07 October 2019, 16:29:29 UTC |
| 4e12e7e | Philip Withnall | 07 October 2019, 13:22:30 UTC | Merge branch 'th/main-context-default-no-mutex' into 'master' gmain: use atomic operation instead of GMutex to access g_main_context_default() See merge request GNOME/glib!1135 | 07 October 2019, 13:22:30 UTC |
| 39dd2be | Thomas Haller | 07 October 2019, 13:22:30 UTC | gmain: use atomic operation instead of GMutex to access g_main_context_default() I think it is wasteful to use a mutex every time the default main context is accessed. Especially, as the default main context is used all the time. | 07 October 2019, 13:22:30 UTC |
| 038ec3d | Philip Withnall | 07 October 2019, 13:07:56 UTC | Merge branch 'add_array_steal_function' into 'master' Add g_array_steal(), g_ptr_array_steal() and g_byte_array_steal() Closes #285 See merge request GNOME/glib!1019 | 07 October 2019, 13:07:56 UTC |
| 7bada83 | Paolo Bonzini | 30 July 2019, 17:22:05 UTC | Add g_array_steal(), g_ptr_array_steal() and g_byte_array_steal() Closes issue #285 | 07 October 2019, 12:38:24 UTC |
| c88f106 | Philip Withnall | 07 October 2019, 09:23:41 UTC | Merge branch 'wip/oholy/gio-completion' into 'master' Several gio-tool bash completion fixes and improvements See merge request GNOME/glib!1153 | 07 October 2019, 09:23:41 UTC |
| a350fa5 | Philip Withnall | 07 October 2019, 09:04:06 UTC | Merge branch 'winhttp-handle-null-prgname' into 'master' gwinhttpvfs: Handle g_get_prgname() returning NULL See merge request GNOME/glib!1152 | 07 October 2019, 09:04:06 UTC |
| 419b7d0 | Philip Withnall | 07 October 2019, 08:53:01 UTC | Merge branch 'glib-g_ptr_array_sort_api_doc_example' | 07 October 2019, 08:53:01 UTC |
| 52c130f | Lee Bigelow | 01 August 2019, 08:30:01 UTC | Add full examples to g_ptr_array_sort() and g_ptr_array_sort_with_data() With changes by Emmanuel Fleury and Philip Withnall. Closes issue #9 | 07 October 2019, 08:50:51 UTC |
| acf55ad | Philip Withnall | 07 October 2019, 08:44:39 UTC | Merge branch 'solaris-build-fixes' into 'master' Solaris build fixes See merge request GNOME/glib!1146 | 07 October 2019, 08:44:39 UTC |
| b3bf1e2 | Ondrej Holy | 03 October 2019, 13:09:56 UTC | gio: Always include mounts in the results Mounts are currently completed only if the prefix looks like scheme, however, this doesn't work well if the mounts have also path component. Let's always include them to fix this issue. The mounts are cached by the volume monitors, so it should not significantly affect the performance. | 07 October 2019, 07:21:19 UTC |
| 8bc5210 | Ondrej Holy | 03 October 2019, 12:58:52 UTC | gio: Complete also activation roots of volumes Currently, "gio mount google-drive<tab>" isn't completed even though that volume exists for google-drive://oholy@redhat.com/. Let's use "gio mount -li" output to complete also activation roots of volumes. | 07 October 2019, 07:21:19 UTC |
| 3a1492e | Ondrej Holy | 03 October 2019, 12:44:57 UTC | gio: Fix completion of URIs without hostname part Currently, "gio list file:///h<tab>" doesn't complete "file:///home" because the result of "dirname file:///h" is not "file:///" but "file:/", which breaks the consequent logic. Let's subtract basename from the path in order to workaround this issue. | 07 October 2019, 07:21:09 UTC |
| bf2a102 | Christoph Reiter | 06 October 2019, 18:05:44 UTC | gwinhttpvfs: Handle g_get_prgname() returning NULL When prgname wasn't set NULL would be passed to g_utf8_to_utf16() resulting in "g_utf8_to_utf16: assertion 'str != NULL' failed" | 06 October 2019, 18:05:44 UTC |
| dd27d2b | Simon McVittie | 06 October 2019, 13:18:44 UTC | Merge branch 'patch-1' into 'master' gio/gfile: fix parameter reference for value_p See merge request GNOME/glib!1149 | 06 October 2019, 13:18:44 UTC |
| cb97f0e | Simon McVittie | 06 October 2019, 13:17:59 UTC | Merge branch 'dlech-master-patch-99473' into 'master' gio/gfileinfo: fix parameter references See merge request GNOME/glib!1148 | 06 October 2019, 13:17:59 UTC |
| 5ac73a0 | Simon McVittie | 06 October 2019, 13:17:17 UTC | Merge branch 'patch-2' into 'master' gio/gfile: fix parameter references to @contents See merge request GNOME/glib!1150 | 06 October 2019, 13:17:17 UTC |
| c46c31d | Simon McVittie | 06 October 2019, 13:16:23 UTC | Merge branch 'patch-3' into 'master' gio/gfile: fix typo in doc comment See merge request GNOME/glib!1151 | 06 October 2019, 13:16:23 UTC |
| 4723bf5 | David Lechner | 06 October 2019, 02:01:48 UTC | gio/gfile: fix typo in doc comment This fixes a typo in g_file_has_prefix() do comments. | 06 October 2019, 02:01:48 UTC |
| f71eca1 | David Lechner | 06 October 2019, 01:55:40 UTC | gio/gfile: fix parameter references to @contents Fix a number of occurrences where the parameter reference was missing the trailing 's' | 06 October 2019, 01:55:40 UTC |
| 5120f92 | David Lechner | 06 October 2019, 01:48:15 UTC | gio/gfile: fix parameter reference for value_p This fixes a parameter reference to @value_p in g_file_set_attribute() | 06 October 2019, 01:48:15 UTC |
| 5dee526 | David Lechner | 05 October 2019, 22:36:19 UTC | gio/gfileinfo: fix parameter references This fixes a couple of parameter references for @info in the doc comments. | 05 October 2019, 22:36:19 UTC |
| 25ed7d4 | Sebastian Dröge | 05 October 2019, 06:56:01 UTC | Merge branch 'gmodule-typo' into 'master' gmodule: fix typo in doc comment See merge request GNOME/glib!1147 | 05 October 2019, 06:56:01 UTC |
| 5a57bdb | David Lechner | 05 October 2019, 01:45:22 UTC | gmodule: fix typo in doc comment s/opended/opened/ | 05 October 2019, 01:45:22 UTC |
| 2b34f52 | Alan Coopersmith | 04 October 2019, 20:23:25 UTC | build: no --export-dynamic ldflags for Solaris Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> | 04 October 2019, 20:23:25 UTC |
| e5e1490 | Alan Coopersmith | 04 October 2019, 19:55:14 UTC | gunixmounts: Handle Solaris name of mnt_mntopts in place of mnt_opts Fixes build failure: ../gio/gunixmounts.c: In function ‘_g_get_unix_mounts’: ../gio/gunixmounts.c:742:53: error: ‘struct mnttab’ has no member named ‘mnt_opts’; did you mean ‘mnt_mntopts’? 742 | mntent.mnt_opts, | ^~~~~~~~ | mnt_mntopts Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> | 04 October 2019, 19:55:17 UTC |
| c08e7b9 | Emmanuele Bassi | 04 October 2019, 14:51:10 UTC | Merge branch 'switch_to_gnu99' into 'master' Switching from C gnu89 to C gnu99 standard See merge request GNOME/glib!1035 | 04 October 2019, 14:51:10 UTC |
| 66da7be | Philip Withnall | 04 October 2019, 13:55:44 UTC | 2.63.0 Signed-off-by: Philip Withnall <withnall@endlessm.com> | 04 October 2019, 13:55:44 UTC |
| d207e19 | Philip Withnall | 03 October 2019, 12:12:16 UTC | Merge branch 'wip/tingping/pkcs11' into 'master' gtlscertificate: Add pkcs11-uri property and constructor Closes #1809 See merge request GNOME/glib!933 | 03 October 2019, 12:12:16 UTC |
| b6d8efb | Patrick Griffis | 19 June 2019, 16:10:52 UTC | gtlscertificate: Add support for PKCS #11 backed certificates This adds properties to allow backends to expose PKCS #11 support. | 02 October 2019, 17:12:40 UTC |
| 0c40f3f | Philip Withnall | 02 October 2019, 15:54:19 UTC | Merge branch 'cross-installed-tests' into 'master' Always build tests if we enabled installed-tests See merge request GNOME/glib!1138 | 02 October 2019, 15:54:19 UTC |
| 406c8b0 | Philip Withnall | 02 October 2019, 15:40:09 UTC | Merge branch 'file-permissions-redux' into 'master' Fix handling of G_FILE_COPY_TARGET_DEFAULT_PERMISSIONS in g_file_copy() Closes #174 See merge request GNOME/glib!1134 | 02 October 2019, 15:40:09 UTC |
| 9a5a5c8 | Sebastian Dröge | 02 October 2019, 08:52:40 UTC | Merge branch 'exact-mtime' into 'master' g_file_info_get_modification_date_time: Calculate in integer domain See merge request GNOME/glib!1139 | 02 October 2019, 08:52:40 UTC |
| 14609b0 | Simon McVittie | 01 October 2019, 22:27:53 UTC | g_file_info_get_modification_date_time: Calculate in integer domain g_date_time_add_seconds() and g_date_time_add_full() use floating-point seconds, which can result in the value varying slightly from what's actually on disk. This causes intermittent test failures in gio/tests/g-file-info.c on Debian i386, where we set a file's mtime to be 50µs later, then read it back and sometimes find that it is only 49µs later than the previous value. I've only seen this happen on i386, which means it might be to do with different floating-point rounding when a value is stored in the 80-bit legacy floating point registers rather than in double precision. g_date_time_add() takes a GTimeSpan, which is in microseconds; conveniently, that's exactly what we get from the GFileInfo. Bug-Debian: https://bugs.debian.org/941547 Signed-off-by: Simon McVittie <smcv@collabora.com> | 02 October 2019, 07:30:35 UTC |
| 788c01d | Ask Hjorth Larsen | 02 October 2019, 03:54:08 UTC | Updated Danish translation | 02 October 2019, 03:54:08 UTC |
| 42d8e17 | Simon McVittie | 01 October 2019, 18:51:48 UTC | Always build tests if we enabled installed-tests If we're cross-compiling, the installed-tests are useful even if we can't run them on the build machine: we can copy them to the host machine (possibly via a distro package like Debian's libglib2.0-tests) and run them there. While I'm changing the build-tests condition anyway, deduplicate it. Based on a patch by Helmut Grohne. Bug-Debian: https://bugs.debian.org/941509 Signed-off-by: Simon McVittie <smcv@collabora.com> | 01 October 2019, 19:12:16 UTC |
| 90bdc2f | Ignacio Casal Quinteiro | 01 October 2019, 13:03:28 UTC | Merge branch 'gregistry-key-name-len' into 'master' gregistrysettings: bump key name length to 2048 See merge request GNOME/glib!1137 | 01 October 2019, 13:03:28 UTC |
| 9239f26 | Ignacio Casal Quinteiro | 30 September 2019, 16:13:17 UTC | gregistrysettings: bump key name length to 128 32 is just too low for key names, specially since the registry has a limit of 16,383 chars. Giving that, 128 is a good bump for now. | 01 October 2019, 12:35:43 UTC |
| eb21257 | Philip Withnall | 30 September 2019, 13:23:51 UTC | tests: Expand g_file_copy() tests to test DEFAULT_PERMS flag Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 67772b6 | Philip Withnall | 27 September 2019, 16:43:29 UTC | tests: Unconditionally enable the file permissions test Skip it on systems which don’t support it, rather than compiling it out. That gives us more information from test runs about which tests are being run on which architectures. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| bfdc5fc | Philip Withnall | 27 September 2019, 16:42:03 UTC | glocalfileinfo: Only return file mode, not type, as UNIX_MODE attribute As with the previous commit, `st_mode` contains both the file type (regular file, directory, symlink, special, etc.) and the file mode. For `G_FILE_ATTRIBUTE_ID_UNIX_MODE`, we only want the file mode — so mask `st_mode` with `~S_IFMT`. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 5dd5269 | Philip Withnall | 27 September 2019, 16:33:01 UTC | glocalfileoutputstream: Only pass file mode, not type, to chmod() chmod() technically only accepts file modes, not the file type and mode as returned by stat(). Filter by `S_IFMT` to avoid sending the file type (regular file, directory, symbolic link, etc.). In practice, chmod() ignores anything except the file mode, but we might as well comply with the specification. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 674ba78 | Philip Withnall | 27 September 2019, 16:31:42 UTC | gfile: Document a few nullable vfuncs `GFile` always checks whether these vfuncs are `NULL` before calling them, so document that it’s safe for implementations of `GFile` to not implement them. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 7d2bce8 | Philip Withnall | 27 September 2019, 16:28:40 UTC | glocalfile: Don’t define unsupported copy vfunc The caller assumes that an unimplemented vfunc means that copying is unsupported (and falls back to its internal copy implementation), so there’s no point in implementing the vfunc just to unconditionally return `G_IO_ERROR_NOT_SUPPORTED`. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 1b7ab81 | Philip Withnall | 27 September 2019, 16:27:24 UTC | glocalfile: Don’t define symlink vfunc if it’s unsupported Rather than defining a vfunc which only ever returns `G_IO_ERROR_NOT_SUPPORTED`, just don’t define the vfunc at all. The caller in `GFile` interprets this as symlinks not being supported — so we get the same behaviour, but without spending a vfunc call on it. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 775014d | Philip Withnall | 27 September 2019, 16:25:56 UTC | gfile: Use a more specific error message if symlinks are not supported The string is already translated in `GLocalFile`, so this doesn’t introduce a new translatable string. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:40:55 UTC |
| 2268f36 | Philip Withnall | 27 September 2019, 16:24:36 UTC | gio-tool: Add a --default-permissions argument to `gio copy` This sets the `G_FILE_COPY_DEFAULT_PERMS` flag on the operation, creating the copied file with default permissions rather than the same permissions as the source file. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #174 | 30 September 2019, 13:40:50 UTC |
| 53f6ede | Philip Withnall | 27 September 2019, 14:02:32 UTC | gfile: Don’t copy files as private if using default permissions If a copy operation is started with `G_FILE_COPY_TARGET_DEFAULT_PERMS`, don’t create the destination file as private. Instead, create it with the process’ current umask (i.e. ‘default permissions’). This is a partial re-work of commit d8f8f4d637ce43f8699ba94c9b, with input from Ondrej Holy. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #174 | 30 September 2019, 13:40:43 UTC |
| 51d73ef | Philip Withnall | 27 September 2019, 13:46:18 UTC | gfile: Factor out flags when copying files This introduces no functional changes; just reduces duplication in the code a little. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 13:24:38 UTC |
| c27be68 | Sebastian Dröge | 30 September 2019, 11:53:52 UTC | Merge branch '1897-cmpmem-null-handling' into 'master' gtestutils: Allow cmpmem() arguments to be NULL iff lengths are zero Closes #1897 See merge request GNOME/glib!1133 | 30 September 2019, 11:53:52 UTC |
| 55997a0 | Philip Withnall | 30 September 2019, 11:00:30 UTC | gtestutils: Allow cmpmem() arguments to be NULL iff lengths are zero Document this and add a test. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1897 | 30 September 2019, 11:05:55 UTC |
| 61509ea | Sebastian Dröge | 30 September 2019, 11:05:15 UTC | Merge branch 'python-version' into 'master' build: Bump Python requirement to ≥ 3.5 See merge request GNOME/glib!1132 | 30 September 2019, 11:05:15 UTC |
| bbbdc27 | Philip Withnall | 30 September 2019, 10:23:20 UTC | build: Bump Python requirement to ≥ 3.5 We already depend on Meson 0.49.2, which depends on Python 3.5, so we’ve actually implicitly had this requirement for a while. Might as well make it explicit. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 30 September 2019, 10:23:20 UTC |
| 3ede078 | Sebastian Dröge | 30 September 2019, 06:09:48 UTC | Merge branch 'patch-1' into 'master' gio/gfileinfo: fix param reference in doc comment See merge request GNOME/glib!1131 | 30 September 2019, 06:09:48 UTC |
| 2a4b9eb | David Lechner | 29 September 2019, 01:03:22 UTC | gio/gfileinfo: fix param reference in doc comment The actual parameter name in g_file_attribute_matcher_new() attributes, so change the param reference to match. This way, doc tools can create a proper link. | 29 September 2019, 01:03:22 UTC |
| 349318e | Robert Ancell | 27 August 2019, 07:50:35 UTC | gutils: Add g_get_os_info() Add a new function that gets OS information for /etc/os-release. | 27 September 2019, 03:47:03 UTC |
| 6192fd4 | Philip Withnall | 26 September 2019, 14:01:06 UTC | Merge branch 'gspawn' into 'master' gspawn: Optimize fd closing on AIX and BSDs Closes #1638 See merge request GNOME/glib!574 | 26 September 2019, 14:01:06 UTC |
| 1097b50 | Philip Withnall | 26 September 2019, 13:13:01 UTC | gspawn: Retry on EBUSY errors from dup2() `man dup2` says that on Linux, dup2() can return `EBUSY` if the operation needs to be retried (in addition to returning `EINTR` in other cases where it needs to be retried). Signed-off-by: Philip Withnall <withnall@endlessm.com> | 26 September 2019, 13:13:01 UTC |
| eae72c3 | Philip Withnall | 26 September 2019, 13:10:36 UTC | gspawn: Rewrite some retry loops to use `while` rather than `goto` This introduces no functional changes, but does make the code easier to understand. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 26 September 2019, 13:10:36 UTC |
| 8af823c | Ting-Wei Lan | 20 September 2019, 14:36:30 UTC | gspawn: Use fdwalk provided by system only when it is known to be safe All uses of fdwalk in gspawn are between fork and exec, which means only async-signal safe functions can be called if the parent process has multiple threads. Since fdwalk is not a standard API, we should not assume it is safe to use unless the manual of the system explicitly says it is async-signal safe. Fixes: #1638 | 26 September 2019, 13:07:32 UTC |
| 8af0ba9 | Sebastian Dröge | 26 September 2019, 08:01:15 UTC | Merge branch 'diagnosticfix' into 'master' Improve GLIB_DEPRECATED_MACRO_FOR output See merge request GNOME/glib!1130 | 26 September 2019, 08:01:15 UTC |
| 64cd20d | Sebastian Dröge | 26 September 2019, 07:59:19 UTC | Merge branch 'android-warning-fix' into 'master' gdate: Fix tautological comparison warnings on Android See merge request GNOME/glib!1129 | 26 September 2019, 07:59:19 UTC |
| 91cb171 | Stephan Bergmann | 26 September 2019, 06:42:30 UTC | Improve GLIB_DEPRECATED_MACRO_FOR output See the mailing list thread <https://lists.fedoraproject.org/archives/list/ devel@lists.fedoraproject.org/thread/SZ676IHHSLOQD6UN2I5J5VKXJ5P5SOVO/> "glib-2.0 G_CONST_RETURN causing GCC 'warning: const' on F31", where the GCC diagnostic > test.c:2:13: warning: const > 2 | G_CONST_RETURN char * f(); > | ^~~~~~~ had confused me, and "Deprecated pre-processor symbol, repace with const" is probably a better warning message than just "const". (That recent GCC only prints "Deprecated pre-processor symbol, repace with " appears to be a bug in GCC that GLIB_UNAVAILABLE_MACRO already suffers from, too. Recent Clang correctly prints "Deprecated pre-processor symbol, repace with const".) | 26 September 2019, 07:06:30 UTC |
| 00c04fd | Philip Withnall | 25 September 2019, 14:17:37 UTC | gdate: Fix tautological comparison warnings on Android Android is emitting `-Wtautological-constant-out-of-range-compare` warnings when compiling the validation functions for the enum types for `GDate`. Fix that by comparing as integers. Signed-off-by: Philip Withnall <withnall@endlessm.com> | 25 September 2019, 14:17:37 UTC |
| 02a7af7 | Philip Withnall | 25 September 2019, 13:43:51 UTC | Merge branch 'fileinfo-mention-attr-usecs' into 'master' fileinfo: Mention that usec mtimes are set See merge request GNOME/glib!1126 | 25 September 2019, 13:43:51 UTC |
| 1015bfb | Matthew Leeds | 25 September 2019, 13:43:51 UTC | fileinfo: Mention that usec mtimes are set g_file_info_set_modification_time() and g_file_info_set_modification_date_time() set the G_FILE_ATTRIBUTE_TIME_MODIFIED_USEC attribute in addition to G_FILE_ATTRIBUTE_TIME_MODIFIED, so microsecond precision is available when provided by the caller, so mention both attributes in the docs. | 25 September 2019, 13:43:51 UTC |
