Revision c5ddeceba0404d2f64a1187e1f7eb55d7b70df49 authored by Levi Tamasi on 16 July 2020, 01:52:12 UTC, committed by Facebook GitHub Bot on 16 July 2020, 01:53:54 UTC
Summary:
Periodic syncing of blob files is handled by a lower layer, namely by
`WritableFileWriter`; the `NeedsFsync` method of `BlobFile` and the
`last_fsync_` member variable are actually unused and thus can be
removed. See also https://github.com/facebook/rocksdb/pull/7125 .

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7138

Test Plan: `make check`

Reviewed By: zhichao-cao

Differential Revision: D22562981

Pulled By: ltamasi

fbshipit-source-id: c235aad94a7c27120528c9ec270a7a5b9154e49f
1 parent a7feebd
History
File Mode Size
__init__.py -rw-r--r-- 95 bytes
block_cache_pysim.py -rw-r--r-- 68.4 KB
block_cache_pysim.sh -rw-r--r-- 5.2 KB
block_cache_pysim_test.py -rw-r--r-- 21.3 KB
block_cache_trace_analyzer.cc -rw-r--r-- 92.9 KB
block_cache_trace_analyzer.h -rw-r--r-- 16.3 KB
block_cache_trace_analyzer_plot.py -rw-r--r-- 23.3 KB
block_cache_trace_analyzer_test.cc -rw-r--r-- 27.5 KB
block_cache_trace_analyzer_tool.cc -rw-r--r-- 799 bytes

back to top