Revision c71380ff0b199f1e8be5ca46dd91262f7fbe4cb4 authored by Nikolay Aleksandrov on 19 September 2013, 13:02:36 UTC, committed by David S. Miller on 19 September 2013, 18:15:53 UTC
This bug was introduced by commit 7a163bfb7ce50895bbe67300ea610d31b9c09230 ("netconsole: avoid a crash with multiple sysfs writers"). In store_enabled() we have the following sequence: acquire nt->mutex then rtnl, but in the netconsole netdev notifier we have rtnl then nt->mutex effectively leading to a deadlock. The NULL pointer dereference that the above commit tries to fix is actually due to another bug in netpoll_cleanup(). This is fixed by dropping the mutex from the netdev notifier as it's already protected by rtnl. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d0fe8c8
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.7 KB |
Makefile | -rw-r--r-- | 380 bytes |
acl.c | -rw-r--r-- | 9.4 KB |
acl.h | -rw-r--r-- | 1.5 KB |
balloc.c | -rw-r--r-- | 44.5 KB |
dir.c | -rw-r--r-- | 17.7 KB |
ext2.h | -rw-r--r-- | 27.5 KB |
file.c | -rw-r--r-- | 2.8 KB |
ialloc.c | -rw-r--r-- | 18.3 KB |
inode.c | -rw-r--r-- | 44.8 KB |
ioctl.c | -rw-r--r-- | 4.4 KB |
namei.c | -rw-r--r-- | 9.9 KB |
super.c | -rw-r--r-- | 42.0 KB |
symlink.c | -rw-r--r-- | 1.3 KB |
xattr.c | -rw-r--r-- | 27.9 KB |
xattr.h | -rw-r--r-- | 3.4 KB |
xattr_security.c | -rw-r--r-- | 1.9 KB |
xattr_trusted.c | -rw-r--r-- | 1.4 KB |
xattr_user.c | -rw-r--r-- | 1.5 KB |
xip.c | -rw-r--r-- | 2.0 KB |
xip.h | -rw-r--r-- | 759 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...