Revision c71380ff0b199f1e8be5ca46dd91262f7fbe4cb4 authored by Nikolay Aleksandrov on 19 September 2013, 13:02:36 UTC, committed by David S. Miller on 19 September 2013, 18:15:53 UTC
This bug was introduced by commit
7a163bfb7ce50895bbe67300ea610d31b9c09230 ("netconsole: avoid a crash with
multiple sysfs writers"). In store_enabled() we have the following
sequence: acquire nt->mutex then rtnl, but in the netconsole netdev
notifier we have rtnl then nt->mutex effectively leading to a deadlock.
The NULL pointer dereference that the above commit tries to fix is
actually due to another bug in netpoll_cleanup(). This is fixed by dropping
the mutex from the netdev notifier as it's already protected by rtnl.
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d0fe8c8
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.0 KB |
| Makefile | -rw-r--r-- | 305 bytes |
| budget.c | -rw-r--r-- | 23.8 KB |
| commit.c | -rw-r--r-- | 20.6 KB |
| compress.c | -rw-r--r-- | 6.6 KB |
| debug.c | -rw-r--r-- | 83.4 KB |
| debug.h | -rw-r--r-- | 12.4 KB |
| dir.c | -rw-r--r-- | 32.1 KB |
| file.c | -rw-r--r-- | 45.1 KB |
| find.c | -rw-r--r-- | 30.1 KB |
| gc.c | -rw-r--r-- | 27.9 KB |
| io.c | -rw-r--r-- | 33.3 KB |
| ioctl.c | -rw-r--r-- | 5.2 KB |
| journal.c | -rw-r--r-- | 42.4 KB |
| key.h | -rw-r--r-- | 14.5 KB |
| log.c | -rw-r--r-- | 19.3 KB |
| lprops.c | -rw-r--r-- | 35.9 KB |
| lpt.c | -rw-r--r-- | 58.6 KB |
| lpt_commit.c | -rw-r--r-- | 51.7 KB |
| master.c | -rw-r--r-- | 10.5 KB |
| misc.h | -rw-r--r-- | 8.3 KB |
| orphan.c | -rw-r--r-- | 25.0 KB |
| recovery.c | -rw-r--r-- | 43.2 KB |
| replay.c | -rw-r--r-- | 29.0 KB |
| sb.c | -rw-r--r-- | 23.1 KB |
| scan.c | -rw-r--r-- | 9.5 KB |
| shrinker.c | -rw-r--r-- | 9.5 KB |
| super.c | -rw-r--r-- | 59.9 KB |
| tnc.c | -rw-r--r-- | 87.0 KB |
| tnc_commit.c | -rw-r--r-- | 26.8 KB |
| tnc_misc.c | -rw-r--r-- | 12.7 KB |
| ubifs-media.h | -rw-r--r-- | 22.7 KB |
| ubifs.h | -rw-r--r-- | 61.1 KB |
| xattr.c | -rw-r--r-- | 15.3 KB |
Computing file changes ...
