https://github.com/torvalds/linux
Revision c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC, committed by David S. Miller on 19 December 2018, 18:27:58 UTC
per comment from Leon in rdma mailing list
https://lkml.org/lkml/2018/10/31/312 :

Please don't forget to remove user triggered WARN_ON.
https://lwn.net/Articles/769365/
"Greg Kroah-Hartman raised the problem of core kernel API code that will
use WARN_ON_ONCE() to complain about bad usage; that will not generate
the desired result if WARN_ON_ONCE() is configured to crash the machine.
He was told that the code should just call pr_warn() instead, and that
the called function should return an error in such situations. It was
generally agreed that any WARN_ON() or WARN_ON_ONCE() calls that can be
triggered from user space need to be fixed."

in addition harden rds_sendmsg to detect and overcome issues with
invalid sg count and fail the sendmsg.

Suggested-by: Leon Romanovsky <leon@kernel.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: shamir rabinovitch <shamir.rabinovitch@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ea01007
History
Tip revision: c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC
net/rds: remove user triggered WARN_ON in rds_sendmsg
Tip revision: c75ab8a
File Mode Size
Kconfig -rw-r--r-- 5.0 KB
Makefile -rw-r--r-- 1.0 KB
devres.c -rw-r--r-- 7.7 KB
extcon-adc-jack.c -rw-r--r-- 5.5 KB
extcon-arizona.c -rw-r--r-- 44.9 KB
extcon-axp288.c -rw-r--r-- 12.8 KB
extcon-gpio.c -rw-r--r-- 4.7 KB
extcon-intel-cht-wc.c -rw-r--r-- 10.9 KB
extcon-intel-int3496.c -rw-r--r-- 4.9 KB
extcon-max14577.c -rw-r--r-- 20.9 KB
extcon-max3355.c -rw-r--r-- 3.7 KB
extcon-max77693.c -rw-r--r-- 36.1 KB
extcon-max77843.c -rw-r--r-- 25.8 KB
extcon-max8997.c -rw-r--r-- 19.9 KB
extcon-palmas.c -rw-r--r-- 13.6 KB
extcon-qcom-spmi-misc.c -rw-r--r-- 4.3 KB
extcon-rt8973a.c -rw-r--r-- 19.0 KB
extcon-rt8973a.h -rw-r--r-- 8.1 KB
extcon-sm5502.c -rw-r--r-- 19.1 KB
extcon-sm5502.h -rw-r--r-- 10.9 KB
extcon-usb-gpio.c -rw-r--r-- 7.9 KB
extcon-usbc-cros-ec.c -rw-r--r-- 14.0 KB
extcon.c -rw-r--r-- 35.9 KB
extcon.h -rw-r--r-- 2.5 KB

back to top