Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 09:02:56 UTC
Revision c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC, committed by David S. Miller on 19 December 2018, 18:27:58 UTC 
net/rds: remove user triggered WARN_ON in rds_sendmsg
 
per comment from Leon in rdma mailing list
https://lkml.org/lkml/2018/10/31/312 :

Please don't forget to remove user triggered WARN_ON.
https://lwn.net/Articles/769365/
"Greg Kroah-Hartman raised the problem of core kernel API code that will
use WARN_ON_ONCE() to complain about bad usage; that will not generate
the desired result if WARN_ON_ONCE() is configured to crash the machine.
He was told that the code should just call pr_warn() instead, and that
the called function should return an error in such situations. It was
generally agreed that any WARN_ON() or WARN_ON_ONCE() calls that can be
triggered from user space need to be fixed."

in addition harden rds_sendmsg to detect and overcome issues with
invalid sg count and fail the sendmsg.

Suggested-by: Leon Romanovsky <leon@kernel.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: shamir rabinovitch <shamir.rabinovitch@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ea01007
History
Tip revision: c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC
net/rds: remove user triggered WARN_ON in rds_sendmsg
Tip revision: c75ab8a
File Mode Size
Kconfig -rw-r--r-- 2.8 KB
Makefile -rw-r--r-- 580 bytes
core-card.c -rw-r--r-- 19.5 KB
core-cdev.c -rw-r--r-- 46.2 KB
core-device.c -rw-r--r-- 34.1 KB
core-iso.c -rw-r--r-- 10.6 KB
core-topology.c -rw-r--r-- 14.8 KB
core-transaction.c -rw-r--r-- 35.8 KB
core.h -rw-r--r-- 7.3 KB
init_ohci1394_dma.c -rw-r--r-- 9.6 KB
net.c -rw-r--r-- 41.6 KB
nosy-user.h -rw-r--r-- 629 bytes
nosy.c -rw-r--r-- 17.6 KB
nosy.h -rw-r--r-- 9.8 KB
ohci.c -rw-r--r-- 105.8 KB
ohci.h -rw-r--r-- 7.0 KB
sbp2.c -rw-r--r-- 46.7 KB
back to top