https://github.com/torvalds/linux
Revision c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC, committed by David S. Miller on 19 December 2018, 18:27:58 UTC
per comment from Leon in rdma mailing list
https://lkml.org/lkml/2018/10/31/312 :

Please don't forget to remove user triggered WARN_ON.
https://lwn.net/Articles/769365/
"Greg Kroah-Hartman raised the problem of core kernel API code that will
use WARN_ON_ONCE() to complain about bad usage; that will not generate
the desired result if WARN_ON_ONCE() is configured to crash the machine.
He was told that the code should just call pr_warn() instead, and that
the called function should return an error in such situations. It was
generally agreed that any WARN_ON() or WARN_ON_ONCE() calls that can be
triggered from user space need to be fixed."

in addition harden rds_sendmsg to detect and overcome issues with
invalid sg count and fail the sendmsg.

Suggested-by: Leon Romanovsky <leon@kernel.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: shamir rabinovitch <shamir.rabinovitch@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ea01007
History
Tip revision: c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC
net/rds: remove user triggered WARN_ON in rds_sendmsg
Tip revision: c75ab8a
File Mode Size
Kconfig -rw-r--r-- 6.3 KB
Makefile -rw-r--r-- 1.6 KB
altera-cvp.c -rw-r--r-- 14.1 KB
altera-fpga2sdram.c -rw-r--r-- 4.9 KB
altera-freeze-bridge.c -rw-r--r-- 6.8 KB
altera-hps2fpga.c -rw-r--r-- 5.8 KB
altera-pr-ip-core-plat.c -rw-r--r-- 1.4 KB
altera-pr-ip-core.c -rw-r--r-- 5.0 KB
altera-ps-spi.c -rw-r--r-- 7.7 KB
dfl-afu-dma-region.c -rw-r--r-- 11.6 KB
dfl-afu-main.c -rw-r--r-- 14.5 KB
dfl-afu-region.c -rw-r--r-- 4.1 KB
dfl-afu.h -rw-r--r-- 2.9 KB
dfl-fme-br.c -rw-r--r-- 2.5 KB
dfl-fme-main.c -rw-r--r-- 6.3 KB
dfl-fme-mgr.c -rw-r--r-- 9.2 KB
dfl-fme-pr.c -rw-r--r-- 11.5 KB
dfl-fme-pr.h -rw-r--r-- 2.0 KB
dfl-fme-region.c -rw-r--r-- 2.1 KB
dfl-fme.h -rw-r--r-- 1.0 KB
dfl-pci.c -rw-r--r-- 6.1 KB
dfl.c -rw-r--r-- 25.8 KB
dfl.h -rw-r--r-- 12.1 KB
fpga-bridge.c -rw-r--r-- 12.3 KB
fpga-mgr.c -rw-r--r-- 19.2 KB
fpga-region.c -rw-r--r-- 8.5 KB
ice40-spi.c -rw-r--r-- 5.4 KB
machxo2-spi.c -rw-r--r-- 9.3 KB
of-fpga-region.c -rw-r--r-- 12.1 KB
socfpga-a10.c -rw-r--r-- 15.3 KB
socfpga.c -rw-r--r-- 17.0 KB
ts73xx-fpga.c -rw-r--r-- 4.3 KB
xilinx-pr-decoupler.c -rw-r--r-- 4.1 KB
xilinx-spi.c -rw-r--r-- 4.9 KB
zynq-fpga.c -rw-r--r-- 17.5 KB

back to top