Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC, committed by David S. Miller on 19 December 2018, 18:27:58 UTC 
net/rds: remove user triggered WARN_ON in rds_sendmsg
 
per comment from Leon in rdma mailing list
https://lkml.org/lkml/2018/10/31/312 :

Please don't forget to remove user triggered WARN_ON.
https://lwn.net/Articles/769365/
"Greg Kroah-Hartman raised the problem of core kernel API code that will
use WARN_ON_ONCE() to complain about bad usage; that will not generate
the desired result if WARN_ON_ONCE() is configured to crash the machine.
He was told that the code should just call pr_warn() instead, and that
the called function should return an error in such situations. It was
generally agreed that any WARN_ON() or WARN_ON_ONCE() calls that can be
triggered from user space need to be fixed."

in addition harden rds_sendmsg to detect and overcome issues with
invalid sg count and fail the sendmsg.

Suggested-by: Leon Romanovsky <leon@kernel.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: shamir rabinovitch <shamir.rabinovitch@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ea01007
History
Tip revision: c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC
net/rds: remove user triggered WARN_ON in rds_sendmsg
Tip revision: c75ab8a
File Mode Size
Kconfig -rw-r--r-- 685 bytes
Makefile -rw-r--r-- 402 bytes
channel.c -rw-r--r-- 25.9 KB
channel_mgmt.c -rw-r--r-- 36.0 KB
connection.c -rw-r--r-- 12.6 KB
hv.c -rw-r--r-- 11.4 KB
hv_balloon.c -rw-r--r-- 43.5 KB
hv_fcopy.c -rw-r--r-- 9.9 KB
hv_kvp.c -rw-r--r-- 20.0 KB
hv_snapshot.c -rw-r--r-- 10.2 KB
hv_trace.c -rw-r--r-- 114 bytes
hv_trace.h -rw-r--r-- 9.9 KB
hv_trace_balloon.h -rw-r--r-- 1.6 KB
hv_util.c -rw-r--r-- 14.0 KB
hv_utils_transport.c -rw-r--r-- 8.0 KB
hv_utils_transport.h -rw-r--r-- 2.1 KB
hyperv_vmbus.h -rw-r--r-- 10.8 KB
ring_buffer.c -rw-r--r-- 15.6 KB
vmbus_drv.c -rw-r--r-- 50.2 KB
back to top