https://github.com/torvalds/linux
Revision c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC, committed by David S. Miller on 19 December 2018, 18:27:58 UTC
per comment from Leon in rdma mailing list https://lkml.org/lkml/2018/10/31/312 : Please don't forget to remove user triggered WARN_ON. https://lwn.net/Articles/769365/ "Greg Kroah-Hartman raised the problem of core kernel API code that will use WARN_ON_ONCE() to complain about bad usage; that will not generate the desired result if WARN_ON_ONCE() is configured to crash the machine. He was told that the code should just call pr_warn() instead, and that the called function should return an error in such situations. It was generally agreed that any WARN_ON() or WARN_ON_ONCE() calls that can be triggered from user space need to be fixed." in addition harden rds_sendmsg to detect and overcome issues with invalid sg count and fail the sendmsg. Suggested-by: Leon Romanovsky <leon@kernel.org> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by: shamir rabinovitch <shamir.rabinovitch@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ea01007
Tip revision: c75ab8a55ac1083c232e4407f52b0cadae6c1e0e authored by shamir rabinovitch on 16 December 2018, 07:01:09 UTC
net/rds: remove user triggered WARN_ON in rds_sendmsg
net/rds: remove user triggered WARN_ON in rds_sendmsg
Tip revision: c75ab8a
| File | Mode | Size |
|---|---|---|
| hvc | ||
| ipwireless | ||
| serdev | ||
| serial | ||
| vt | ||
| Kconfig | -rw-r--r-- | 16.2 KB |
| Makefile | -rw-r--r-- | 1.2 KB |
| amiserial.c | -rw-r--r-- | 43.8 KB |
| cyclades.c | -rw-r--r-- | 108.9 KB |
| ehv_bytechan.c | -rw-r--r-- | 21.4 KB |
| goldfish.c | -rw-r--r-- | 11.9 KB |
| isicom.c | -rw-r--r-- | 40.5 KB |
| mips_ejtag_fdc.c | -rw-r--r-- | 35.2 KB |
| moxa.c | -rw-r--r-- | 52.1 KB |
| moxa.h | -rw-r--r-- | 8.5 KB |
| mxser.c | -rw-r--r-- | 70.1 KB |
| mxser.h | -rw-r--r-- | 4.5 KB |
| n_gsm.c | -rw-r--r-- | 78.3 KB |
| n_hdlc.c | -rw-r--r-- | 27.2 KB |
| n_null.c | -rw-r--r-- | 1.3 KB |
| n_r3964.c | -rw-r--r-- | 31.2 KB |
| n_tracerouter.c | -rw-r--r-- | 6.6 KB |
| n_tracesink.c | -rw-r--r-- | 6.6 KB |
| n_tracesink.h | -rw-r--r-- | 850 bytes |
| n_tty.c | -rw-r--r-- | 61.5 KB |
| nozomi.c | -rw-r--r-- | 46.8 KB |
| pty.c | -rw-r--r-- | 24.5 KB |
| rocket.c | -rw-r--r-- | 91.7 KB |
| rocket.h | -rw-r--r-- | 3.8 KB |
| rocket_int.h | -rw-r--r-- | 41.6 KB |
| synclink.c | -rw-r--r-- | 228.7 KB |
| synclink_gt.c | -rw-r--r-- | 130.9 KB |
| synclinkmp.c | -rw-r--r-- | 146.1 KB |
| sysrq.c | -rw-r--r-- | 26.4 KB |
| tty_audit.c | -rw-r--r-- | 5.6 KB |
| tty_baudrate.c | -rw-r--r-- | 6.6 KB |
| tty_buffer.c | -rw-r--r-- | 16.2 KB |
| tty_io.c | -rw-r--r-- | 85.2 KB |
| tty_ioctl.c | -rw-r--r-- | 23.7 KB |
| tty_jobctrl.c | -rw-r--r-- | 14.0 KB |
| tty_ldisc.c | -rw-r--r-- | 19.6 KB |
| tty_ldsem.c | -rw-r--r-- | 10.8 KB |
| tty_mutex.c | -rw-r--r-- | 1.1 KB |
| tty_port.c | -rw-r--r-- | 18.1 KB |
| vcc.c | -rw-r--r-- | 23.2 KB |
Computing file changes ...
