Revision - c7bf75d - fix(platform-browser): remove obsolete shim for Map comparison [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

07 August 2024, 03:31:07 UTC

Revision c7bf75dd5e7f3f80a3c2afb8586ae46f7258f349 authored by Samuel Littley on 04 April 2022, 10:46:21 UTC, committed by Jessica Janiuk on 12 April 2022, 18:43:37 UTC

fix(platform-browser): remove obsolete shim for Map comparison in Jasmine (#45521)

Angular now uses Jasmine 2.8 as a minimum version (required by
protractor; most of it is using ^3.5.0 which currently resolves to
3.99.0), which makes this shim obsolete - all versions of Jasmine used
have Map comparison built in.

This shim causes problems for custom equality checkers - when using a
Map containing types needing a custom equality check, this  fails
because the call to `jasmine.matchersUtil.equals` from the shim does not
use any of the custom equality matchers.

PR Close #45521

1 parent b5f39c5

Files
Changes

Permalinks

Tip revision: c7bf75dd5e7f3f80a3c2afb8586ae46f7258f349 authored by Samuel Littley on 04 April 2022, 10:46:21 UTC
fix(platform-browser): remove obsolete shim for Map comparison in Jasmine (#45521)

Tip revision: c7bf75d

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	2.8 KB
.bazelrc	-rw-r--r--	6.7 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	915 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	46.8 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.2 KB
CHANGELOG.md	-rw-r--r--	1022.4 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.9 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	5.0 KB
browser-providers.conf.js	-rw-r--r--	1.8 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	6.0 KB
package.json	-rw-r--r--	9.3 KB
renovate.json	-rw-r--r--	2.6 KB
test-events.js	-rw-r--r--	259 bytes
tsconfig-tslint.json	-rw-r--r--	171 bytes
tslint.json	-rw-r--r--	5.4 KB
yarn.lock	-rw-r--r--	704.9 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(platform-browser): remove obsolete shim for Map comparison in Jasmine (#45521)

README.md