Revision c825a43e288ecedeb55143e8e930233fbc2cbc3c authored by SamuelH-97 on 13 October 2022, 14:59:05 UTC, committed by GitHub on 13 October 2022, 14:59:05 UTC
* Remnant mass function moved from em_progenitors to conversions. Relevant NS functions moved to neutron_stars. Calls to these functions fixed to reflect new locations * no change, pushing to resolve issue with checkout * importing pycbc.tmpltbank rather than pycbc in attempt to resolve import issues (currently unresolved) * moved neutron stars code and eos data to new package and created __init__ file * Renamed em_progenitors as ns_functions and moved to neutron_stars package. Edited how said functions are imported elsewhere where necessary. Added neutron_stars package path to setup file * First suite of changes suggested in PR. Removes some cases of double imports and old code comments from during development * Removed the logging and sys calls. Changed the exception to a ValueError with clear error messages. Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com> * retrigger checks * EM-bright work * Constraint string substitutions for static args * Speed up remnant mass calculation (1st attempt) * Adding derivatives in ns_functions for root solver * Add to comment * Missing bracket * Fix bugs * Enable spherical or cartesian spins for m_rem calc * Reorganising neutron_stars module * Some fixes to isso solver * Adding 2D interpolation for ISSO radii * Refined bivariate interpolator for ISSO calc * Change in setup.py, needed for tox * Fix docstrings * Fixing doc strings * Remove old pycbc_dark_vs_bright_injections code * Added newline at end of file to conform to codeclimate check * removed trailing whitespace * removed trailing whitespaces * Removed imports outside of toplevel * removed trailing whitespaces * Empty-Commit, retrigger checks * correctly importing pickle and os.path at top of pg_isso_solver.py * Creating 3 variables in which previously repeated lines of calculation are performed (in need of new names, potenatially better solution available) * fixed issue with unnecessary indents * changed variables to functions after negecting to realise they relied on called variables. Still in need of more informative names, potentially room for more elegant solution * removed trailing whitespaces * Fixing error in trig functions (missing return) * removed functions aimed at avoiding repeated code. Deemed unnecessary * rectified mislabeled parameter chi_lims to bounds as required by function * introducing latest version of remnant mass function in coord_utils get_randm_mass function. Minor rewrite to earlier portion sof function to acommodate this change * added short description of concat_grid function * Moved ns_sequence_file initialisation above it's first use to avoid error * fixed issue with methods used to call variables in remnant mass function * introduced eos as a variable in the get_random_mass function in order to work with updated remnant_mass funtion * adding new lines between function definitions * re-introduced eta_nsbh in get_random_mass as it is required later in the function * moved module level imports to top of init file * moved module level imports back to bottom of init file as moving to top seemed to break code * removed trailing whitespace * Initialised input_is_array variable and added functionality to check if input variable is an array. If it is, input_is_array is set to True * resolved issue with undefined variable erroneously added in code which checks if an input is an array * addrd r prefix to doctring in an attempt to resolve issues related to use of backslashes * Replace code which checks if input is an array with more reliable method Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Updated docstrings to more accurately represent the forms of inputs and outputs in a number of functions * Fixed typo in docstring Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Reformatted code to agree with codeclimate Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Removed hardcoded output path for generate_isso_bivariate_interp() * Fix wrong import name * Updated comments in constraint function Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Remove ISSO interpolant, will bring back a better version later * Forgot a few things * Update pycbc/tmpltbank/coord_utils.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it> Co-authored-by: Samuel Higginbotham <samuel.higginbotham@ligo.org> Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com> Co-authored-by: Andrew Williamson <andrew.williamson@ligo.org> Co-authored-by: Tito Dal Canton <tito@dalcanton.it> Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> Co-authored-by: Tito Dal Canton <tito.canton@ligo.org>
1 parent b9b6fb3
File | Mode | Size |
---|---|---|
.github | ||
bin | ||
docker | ||
docs | ||
examples | ||
pycbc | ||
test | ||
tools | ||
.codeclimate.yml | -rw-r--r-- | 1.0 KB |
.gitignore | -rw-r--r-- | 95 bytes |
.landscape.yml | -rw-r--r-- | 348 bytes |
CODE_OF_CONDUCT.md | -rw-r--r-- | 3.3 KB |
CONTRIBUTING.md | -rw-r--r-- | 3.8 KB |
Dockerfile | -rw-r--r-- | 3.2 KB |
INSTALL | -rw-r--r-- | 1.8 KB |
LICENSE | -rw-r--r-- | 34.3 KB |
MANIFEST.in | -rw-r--r-- | 197 bytes |
README.md | -rw-r--r-- | 2.4 KB |
companion.txt | -rw-r--r-- | 534 bytes |
descr.rst | -rw-r--r-- | 1.3 KB |
pycbc.spec | -rw-r--r-- | 1.7 KB |
pyproject.toml | -rw-r--r-- | 618 bytes |
pytest.ini | -rw-r--r-- | 85 bytes |
requirements-igwn.txt | -rw-r--r-- | 97 bytes |
requirements.txt | -rw-r--r-- | 728 bytes |
setup.py | -rwxr-xr-x | 12.0 KB |
tox.ini | -rw-r--r-- | 1.4 KB |
Computing file changes ...