Revision - c9acb7b - fix(compiler-cli): preserve quotes in class member names (#38387) - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

19 April 2024, 08:24:33 UTC

Revision c9acb7b7e2fe3ca36b6d435b6253c9ea4e3559e4 authored by crisbeto on 09 August 2020, 08:10:35 UTC, committed by Andrew Kushnir on 10 August 2020, 22:26:46 UTC

fix(compiler-cli): preserve quotes in class member names (#38387)

When we were outputting class members for `setClassMetadata` calls,
we were using the string representation of the member name. This can
lead to us generating invalid code when the name contains dashes and
is quoted (e.g. `@Output() 'has-dashes' = new EventEmitter()`), because
the quotes will be stripped for the string representation.

These changes fix the issue by using the original name AST node that was
used for the declaration and which knows whether it's supposed to be
quoted or not.

Fixes #38311.

PR Close #38387

1 parent 545444d

Files
Changes

Permalinks

Tip revision: c9acb7b7e2fe3ca36b6d435b6253c9ea4e3559e4 authored by crisbeto on 09 August 2020, 08:10:35 UTC
fix(compiler-cli): preserve quotes in class member names (#38387)

Tip revision: c9acb7b

File	Mode	Size
.circleci
.devcontainer
.github
.ng-dev
.vscode
.yarn
aio
dev-infra
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	4.3 KB
.bazelrc	-rw-r--r--	6.2 KB
.bazelversion	-rw-r--r--	213 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	314 bytes
.gitignore	-rw-r--r--	726 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.nvmrc	-rw-r--r--	8 bytes
.pullapprove.yml	-rw-r--r--	44.1 KB
.yarnrc	-rw-r--r--	128 bytes
BUILD.bazel	-rw-r--r--	1.7 KB
CHANGELOG.md	-rw-r--r--	719.8 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	14.2 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	1.2 KB
WORKSPACE	-rw-r--r--	4.3 KB
browser-providers.conf.js	-rw-r--r--	8.9 KB
gulpfile.js	-rw-r--r--	1.2 KB
karma-js.conf.js	-rw-r--r--	7.6 KB
package.json	-rw-r--r--	8.3 KB
test-events.js	-rw-r--r--	259 bytes
test-main.js	-rw-r--r--	11.3 KB
tslint.json	-rw-r--r--	2.3 KB
yarn.lock	-rw-r--r--	676.1 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(compiler-cli): preserve quotes in class member names (#38387)

README.md