Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision caebd1b389708bf3d0465be829480fc706a68720 authored by Nir Dotan on 03 August 2018, 12:57:44 UTC, committed by David S. Miller on 03 August 2018, 19:28:01 UTC 
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
 
In previous patch mlxsw_afa_resource_del() was added to avoid a duplicate
resource detruction scenario.
For mirror actions, such duplicate destruction leads to a crash as in:

 # tc qdisc add dev swp49 ingress
 # tc filter add dev swp49 parent ffff: \
   protocol ip chain 100 pref 10 \
   flower skip_sw dst_ip 192.168.101.1 action drop
 # tc filter add dev swp49 parent ffff: \
   protocol ip pref 10 \
   flower skip_sw dst_ip 192.168.101.1 action goto chain 100 \
   action mirred egress mirror dev swp4

Therefore add a call to mlxsw_afa_resource_del() in
mlxsw_afa_mirror_destroy() in order to clear that resource
from rule's resources.

Fixes: d0d13c1858a1 ("mlxsw: spectrum_acl: Add support for mirror action")
Signed-off-by: Nir Dotan <nird@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7cc6169
History
Tip revision: caebd1b389708bf3d0465be829480fc706a68720 authored by Nir Dotan on 03 August 2018, 12:57:44 UTC
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
Tip revision: caebd1b
File Mode Size
Kconfig -rw-r--r-- 1.2 KB
Makefile -rw-r--r-- 182 bytes
vxfs.h -rw-r--r-- 9.6 KB
vxfs_bmap.c -rw-r--r-- 7.8 KB
vxfs_dir.h -rw-r--r-- 3.2 KB
vxfs_extern.h -rw-r--r-- 2.7 KB
vxfs_fshead.c -rw-r--r-- 5.2 KB
vxfs_fshead.h -rw-r--r-- 2.5 KB
vxfs_immed.c -rw-r--r-- 2.6 KB
vxfs_inode.c -rw-r--r-- 9.2 KB
vxfs_inode.h -rw-r--r-- 5.7 KB
vxfs_lookup.c -rw-r--r-- 7.2 KB
vxfs_olt.c -rw-r--r-- 3.8 KB
vxfs_olt.h -rw-r--r-- 4.3 KB
vxfs_subr.c -rw-r--r-- 4.5 KB
vxfs_super.c -rw-r--r-- 8.8 KB
back to top