Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision caebd1b389708bf3d0465be829480fc706a68720 authored by Nir Dotan on 03 August 2018, 12:57:44 UTC, committed by David S. Miller on 03 August 2018, 19:28:01 UTC 
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
 
In previous patch mlxsw_afa_resource_del() was added to avoid a duplicate
resource detruction scenario.
For mirror actions, such duplicate destruction leads to a crash as in:

 # tc qdisc add dev swp49 ingress
 # tc filter add dev swp49 parent ffff: \
   protocol ip chain 100 pref 10 \
   flower skip_sw dst_ip 192.168.101.1 action drop
 # tc filter add dev swp49 parent ffff: \
   protocol ip pref 10 \
   flower skip_sw dst_ip 192.168.101.1 action goto chain 100 \
   action mirred egress mirror dev swp4

Therefore add a call to mlxsw_afa_resource_del() in
mlxsw_afa_mirror_destroy() in order to clear that resource
from rule's resources.

Fixes: d0d13c1858a1 ("mlxsw: spectrum_acl: Add support for mirror action")
Signed-off-by: Nir Dotan <nird@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7cc6169
History
Tip revision: caebd1b389708bf3d0465be829480fc706a68720 authored by Nir Dotan on 03 August 2018, 12:57:44 UTC
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
Tip revision: caebd1b
File Mode Size
Kconfig -rw-r--r-- 2.4 KB
Makefile -rw-r--r-- 317 bytes
compat.c -rw-r--r-- 3.3 KB
dquot.c -rw-r--r-- 79.1 KB
kqid.c -rw-r--r-- 3.2 KB
netlink.c -rw-r--r-- 2.8 KB
quota.c -rw-r--r-- 24.6 KB
quota_tree.c -rw-r--r-- 18.2 KB
quota_tree.h -rw-r--r-- 728 bytes
quota_v1.c -rw-r--r-- 6.6 KB
quota_v2.c -rw-r--r-- 11.8 KB
quotaio_v1.h -rw-r--r-- 1.3 KB
quotaio_v2.h -rw-r--r-- 2.6 KB
back to top